Step to reproduce 1 create a new presentation 2 create a new style inherit from text for example 3 save presentation 4 reopen presentation ==> lost of inherit Rem opening a existing presentation loose inherit for all styles so I think we can add data-loss for this bug (to be confirmed) Of course, it works fine with LO 4.2.4
Hi I reproduce on windows 7/64 & Version: 4.3.0.0.beta2 Build ID: a06aa316117a6ff0f05c697c82831c227812d810 So I set status to New Was ok with Version: 4.2.5.1 Build ID: 881bb88abfe2992c6cede97c23e64a9885de87de Regards Pierre-Yves
Still in 4.3.0RC2...
When I save a file in 4.3.x and open in 4.5.x, it is still OK > The information is lost on opening
of course one can link styles again, but boxes will also have changed size and so, which is a PITA to repair...
4.3.0 is in two days, and this data-loss bug is not solved. Too bad
bibisect range: dd1050b182260a26a1d0ba6d0ef3a6fecc3f4e07..c59b3d6c5c8096486730007d9b9b053793b90b1e regression from: commit e955433c3574cb602dedba96bc645898f97858bf Author: Tobias Lippert <drtl@fastmail.fm> AuthorDate: Wed Mar 5 19:51:58 2014 +0100 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Mon Mar 10 12:10:15 2014 -0500 Use SfxStyleSheetIterator to iterate over style sheets in sd/stlsheet.cxx
Dear all, sorry for introducing that regression. I was not aware of it until Martin added me to the cc list. I have written a fix which works on my machine. I am not familiar with the inheritance. Please check whether I tested it correctly. I have tested it as follows: 1. Create a new draw document 2. Open Styles and Formatting 3. Right-click the style "text" 4. Choose new in the context menu 5. Enter any name 6. Save document 7. Close document 8. Re-open document Without the fix, the new style is on the same level as "Default" With the fix, the new style is one level below "text" I will submit a fix asap and ask someone in the irc to review it.
The link to the fix can be found below. I did an end-to-end test, as described in the comment above. I will add a unittest for the fix later, but the fix should help to resolve the bug in 4.3.0. https://gerrit.libreoffice.org/#/c/10309/
Tobias Lippert committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=61cf536f0400284a5ff85d1a84c9dee72ead3fbf fdo#80020 Fix regression for style sheet inheritance The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tobias Lippert committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=980b3fc921b6c22634ea63cd7aa264b520da0ce4&h=libreoffice-4-3 fdo#80020 Fix regression for style sheet inheritance It will be available in LibreOffice 4.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tobias Lippert committed a patch related to this issue. It has been pushed to "libreoffice-4-3-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e662655c6afacc9c67d2381411d838e2be16d3ed&h=libreoffice-4-3-0 fdo#80020 Fix regression for style sheet inheritance It will be available already in LibreOffice 4.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Let's call this fixed.
YEP ! No problem with 4.3.0.3
Varun committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=91949b62505b4159ad930dca89d2cc9eba082807 Added Test for tdf#80020 Impress style inheritance It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (dataloss) [NinjaEdit]