Bug 80815 - UI: The information on the Autorepair on app startup fails to explain the possibility of the "Cancel" button
Summary: UI: The information on the Autorepair on app startup fails to explain the pos...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-02 15:53 UTC by M i
Modified: 2014-10-30 15:09 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
add-disable-autorecovery.patch (11.67 KB, patch)
2014-07-03 00:13 UTC, Douglas Mencken
Details

Note You need to log in before you can comment on or make changes to this bug.
Description M i 2014-07-02 15:53:44 UTC
Sometimes, the Autorepair on startup fails.

The autorepair will trig on each start forever, though.

On /failed/ autorepair, it would be great with an option to make it never autorepair again, just so that you don't need to google for undocumented features and look up hidden system files to manually force it not to attempt to autorepair that particular file again.
Comment 1 M i 2014-07-02 16:01:34 UTC
Aha, so, the Cancel button actually has this effect already - this is not so clear, Cancel sounds more like that you want to Autorepair it on the next app start again.

Perhaps this can be clarified somehow.
Comment 2 Cor Nouws 2014-07-02 20:44:44 UTC
Hi Mikael,

Thanks for the issue and your extra comment. I agree: it is not clear in the text that is on top of that dialog.

Set to New.

ciao,
Cor
Comment 3 Douglas Mencken 2014-07-03 00:13:37 UTC
Created attachment 102174 [details]
add-disable-autorecovery.patch

add possibility to --disable-autorecovery before building

This controls whether to build document auto-recovery feature or not.
Comment 4 Douglas Mencken 2014-07-03 00:14:56 UTC
My ideas are more radical.

``I dunno why do you love this useless annoying "feature" so much. Actually, it would be much better to completely remove this functionality from the source.''

I made a patch which turns this "feature" off. But upstream rejected it.
So I attached it to this report (maybe somebody will want it too).

https://gerrit.libreoffice.org/#/c/10032/
Comment 5 M i 2014-07-03 01:02:31 UTC
Umm.. in my frame of reference, autorecovery is a very good default functionality.

I vote for Cor's suggestion i.e. clarify the description of what the Cancel button actually does.
Comment 6 Commit Notification 2014-10-30 15:08:32 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6ac621f1e07c2717d69880866522056996fe9546

Resolves: fdo#80815 rename Cancel and explain what it will do

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2014-10-30 15:09:31 UTC
hopefully that helps clarify what the (now renamed) button does