Presently the zoom drop down only has 25, 50, 75, 100, 150 and 200 percent, while View > Zoom also contains entire page, page width, and optimal view.
Nice addition - thanks :)
Created attachment 113085 [details]
Using SvxZoomItem instead of SfxUInt16Item to include Zoom Type
It uses SvxZoomItem (a class derived from SfxUInt16Item) to enable the 3 required ZoomTypes in the dropdown created by View -> Zoom
Thanks Rishabh for uploaded what i'm assuming is the patched file to solve the problem. Is the file uploaded ./sw/source/uibase/ribbar/workctrl.cxx?
Do you know how to set the patch through git and gerrit?
Have you submitted a license statement?
If the answer to any of the above two questions is no, it would be useful to go to the links below for further information.
Yes it is intended for sw/source/uibsase/ribbar/workctrl.cxx .Thanks for guiding me as this is my first patch to libreoffice
Congrats and look forward to seeing your patch added to gerrit. When you are creating the commit message for this patch, start it off with 'fdo#81073' so that it gets referenced to this bug.
pushed the changes. Sorry for being late.
The build fails on mac-os and windows. Any suggestions for debugging?
I checked your patch at gerrit - https://gerrit.libreoffice.org/#/c/14365/ - and i've had patches that also claim to have failed the automatic build (e.g. https://gerrit.libreoffice.org/#/c/14311/) wherein i only changed a text label, so i wouldnt think to much of that error.
So all you need to do is fix up your commit message as Adolfo suggested and then i think the patch will get through.
(In reply to Rishabh from comment #7)
> The build fails on mac-os and windows. Any suggestions for debugging?
Don’t worry too much about Jenkins right now – if you have tested your change locally, and LibreOffice builds fine with it, then it’s fine. Jenkins is mostly to ensure that big changes do not break the CI process and master is always buildable.
You can ask questions in our development list: libreoffice at lists.freedesktop.org.
Pushed the changes. Up for the review
Seems you have pushed 4 different patches, so firstly it would be good to cancel the other 3 by setting them as 'Abandon', and you should be aware that you can amend your patch when you make changes to it, so that it isnt submit as another patch. You can do this with 'git commit --amend'.
I have abandoned the previous 3 patches. I am still learning git .
Rishabh Kumar committed a patch related to this issue.
It has been pushed to "master":
tdf#81073 :Addition of text zoom levels to print preview zoom
It will be available in 4.5.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.