Created attachment 103460 [details] presentation indicating the loss of the latest edition in open obejcts for editing LibreOffice Impress is not saving latest editions. When editing a text box in Impress and I click on Save file, the editions of the text box are lost. The attached sample shows it. This file is a presentation that were PPT/PPTX in a previous life. To see the bug: 1) Open the file 2) edit the text in the first slide 3) click on Save in the toolbar 4) close the file 5) reopen the file Effect: your edition in the text box are lost. To circumvent this bug: Option 1 Click out of the text box to commit the latest edition, only then save the file. Option 2 close the file. A warning box will inform the edition were not saved. Click to save it. Option 3 Select all content of the text box Delete the text box Create a new text box Copy back the contents into the new text box. Expected behaviour: File saved with the latest edition of the text box.
Hello Olivier, I could not reproduce your bug, so I changed the status to resolved-worksforme. If this is still a bug for you change the status back to unconfirmed and provide more information if possible. You might consider upgrading LO to a later version since it worked for me on 4.2.5.2. I tested using: x86-64 Windows 8 LO Version: 4.2.5.2 Build ID: 61cb170a04bb1f12e77c884eab9192be736ec5f5
This has to be a pptx file; not reproducible with .odp for me, but I can reproduce with a pptx. Another interesting thing: In this scenario - after saving, the "save status" shows that the file has been saved. But when closing the document, it becomes unsaved again, and the user is asked whether to save the changes.
Reverse bibisect log. 31e7246cfaec71905ec7ce61e8fd3e5a7a528842 is the first bad commit commit 31e7246cfaec71905ec7ce61e8fd3e5a7a528842 Author: Jenkins Build User <tdf@pollux.tdf> Date: Wed Nov 23 05:48:23 2016 +0100 source 2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee # bad: [1bfd8dda84f0dd2c5662b64f382637d75b8bf227] source 6238f71ddbdc766e733b1c808a4fa7d66f7bde87 # good: [33e60eae04c889baf52713a73dc9944015408914] source 5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start '1bfd8dda84f0dd2c5662b64f382637d75b8bf227' 'oldest' # good: [964789dfd0674f0447da363a8c52114097796fa3] source e473e0e1b9bc354d53908cb0ca84db06c3051fe2 git bisect good 964789dfd0674f0447da363a8c52114097796fa3 # good: [82e6762ef9ce5acd3ee832074a327ac43d94173a] source 6f345e1e6e2d7f6fdbd746dfd0c91843a5ff2d10 git bisect good 82e6762ef9ce5acd3ee832074a327ac43d94173a # good: [b496470a254d264be0b15764e76d3ae0cff325da] source 1bbf7f653b6b159afb0bf2c34dd463f58333852c git bisect good b496470a254d264be0b15764e76d3ae0cff325da # good: [85b3496336990ff6a25b39bcb67a0564136455dc] source 2fdbe655bb63dd40fda9b684c5715f21fd5ab639 git bisect good 85b3496336990ff6a25b39bcb67a0564136455dc # good: [ffbec3ff409c86716ff193e2bb0d8b3bc8d238b2] source 3aec456ba8a0d1f9aef2fc1735d1861fe9d3a98c git bisect good ffbec3ff409c86716ff193e2bb0d8b3bc8d238b2 # bad: [1ae480f04b8805fb56cd253a3ec64aa8a1c8a335] source 60a596b48d670828c8c71658e45de7296a1848c6 git bisect bad 1ae480f04b8805fb56cd253a3ec64aa8a1c8a335 # good: [c82cafd44786a8a0eebc7cb205cb948253876e40] source 7c18387dd46391f033af504792b33b6ff4a4e9ad git bisect good c82cafd44786a8a0eebc7cb205cb948253876e40 # bad: [0d59d8931f12618635f331a68eac24d88b01e486] source f965a629fba10ecba7bad938a0c1c9c3db1e510d git bisect bad 0d59d8931f12618635f331a68eac24d88b01e486 # good: [a43f3df23407df6e48695f4ad78a55e87f1829c2] source 50244309501d738e7314fa79785db139c826f8d7 git bisect good a43f3df23407df6e48695f4ad78a55e87f1829c2 # bad: [f69f131d0e7246a3f56a6db799a3f65f72764126] source 1daf867d72d60155cff49a7dfe98c36071ed994b git bisect bad f69f131d0e7246a3f56a6db799a3f65f72764126 # good: [d2cd41153576208ac0ace75a8e641951e36b2a99] source 9b910bd62eaf000171c669692c40056ff47e4d76 git bisect good d2cd41153576208ac0ace75a8e641951e36b2a99 # bad: [31e7246cfaec71905ec7ce61e8fd3e5a7a528842] source 2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee git bisect bad 31e7246cfaec71905ec7ce61e8fd3e5a7a528842 # good: [d5eee0b434530b918f2d8a9e676c018563080219] source ab9c578ed17cfd9c9a49f22d83f33b0546faedba git bisect good d5eee0b434530b918f2d8a9e676c018563080219 # first bad commit: [31e7246cfaec71905ec7ce61e8fd3e5a7a528842] source 2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee
This is fixed in 5.3beta2, but not in 5.2.4.2. Reverse bibisect results with bibisect-linux-64-5.3 repo (bisected to single commit): https://cgit.freedesktop.org/libreoffice/core/commit/?id=2ad50c9a8c8411a57bbbd7a52734e72ffc4cc0ee author David Tardon <dtardon@redhat.com> 2016-11-22 08:07:54 (GMT) committer David Tardon <dtardon@redhat.com> 2016-11-22 20:37:17 (GMT) "avoid loss of text in edited placeholder How to reproduce: 1. Create an empty presentation. 2. Save it. 3. Click at one of the text placeholders and write something. 4. Save again. 5. Reload. The placeholder is missing. (Actually, it's still there, but empty and 0-size.) This only happens if a11y is enabled." Needs backporting to 5.2 branch.
Jan Holesovsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6106fea591f685bc1fd5b65ade86e2e45dbc58e1 tdf#81754: Unit test for the loss of text on save of pptx. It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
David, could you backport your commit identified in comment 4, which fixes this bug to 5.2? Thanks!