Bug 82137 - Extracting libreoffice tarball changes the permissions of the parent directory.
Summary: Extracting libreoffice tarball changes the permissions of the parent directory.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:4.4.0 target:4.2.7 target:4.3.1
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-04 16:21 UTC by Armin K
Modified: 2014-08-06 18:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Armin K 2014-08-04 16:21:09 UTC
When extracting the tarball as root user, the ownership and permissions of the directory the tar command has been run from change to non-desirable values:

# mkdir src
# cd src
# ls -la
drwxr-xr-x 2 root  root  4096 Aug  4 18:16 .
# tar xf ../libreoffice-4.3.0.4.tar.xz 
# ls -la
drwx------   3 10003 users 4096 Jul 25 08:46 .
drwxr-xr-x 149 10003 users 4096 Jul 25 08:46 libreoffice-4.3.0.4

When ran as normal user, only the permissions of the parent directory get changed, as normal user can't change ownership. This is undesirable for end users. Please fix it.

We can fix it with --no-overwrite-dir tar parameter, but it really should be fixed not to do it in the first place.
Comment 1 David Tardon 2014-08-04 17:15:44 UTC
You should also not build as root.
Comment 2 Armin K 2014-08-04 17:17:30 UTC
Sorry, but I think I mentioned extracting, not building. Even when *extracting* as normal user, the permissions of the parent directory got changed which can lead to big trouble, depending on what else that directory might be used for.
Comment 3 famobr 2014-08-05 20:16:09 UTC
I confirm that. Need to create a build directory to extract LO, for this reason. In my case, it is x86 (IA 32).
Comment 4 Christian Lohmaier 2014-08-06 18:14:27 UTC
the tarballs for the sources are created with 

http://cgit.freedesktop.org/libreoffice/core/tree/bin/lo-pack-sources

while the permission change is indeed undesirable (and easy to fix), the ownership one is a self-created problem/see no fault here.
Comment 5 Commit Notification 2014-08-06 18:15:39 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ca2b6fca9eb975886f6796e6086ddf79be387d5

fdo#82137 don't include working directory in tarballs



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2014-08-06 18:19:29 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-4-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f37f7b8b0d99b274e2eadc4eff232ea670cb6fd&h=libreoffice-4-2

fdo#82137 don't include working directory in tarballs


It will be available in LibreOffice 4.2.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2014-08-06 18:21:14 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-4-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=47cb8a41ffe7221814307ad72e58bdc735c1812c&h=libreoffice-4-3

fdo#82137 don't include working directory in tarballs


It will be available in LibreOffice 4.3.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2014-08-06 18:22:57 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-4-3-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=780a9b98220a89b48a29526a18a79d365e7f82ce&h=libreoffice-4-3-1

fdo#82137 don't include working directory in tarballs


It will be available already in LibreOffice 4.3.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.