Bug 82400 - FILEOPEN: PPTX files open with multiple undos already added
Summary: FILEOPEN: PPTX files open with multiple undos already added
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0
Keywords: filter:pptx
Depends on:
Blocks: Undo-Redo PPTX ModifiedStatus
  Show dependency treegraph
 
Reported: 2014-08-10 00:08 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-09-14 22:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-08-10 00:08:54 UTC
I was going through the pptx files found at < http://cgit.freedesktop.org/libreoffice/core/tree/chart2/qa/extras/data/ > and noticed that when i open them that they have multiple undos already listed which results in libreoffice asking me to save changes to the document when i havent made any.
Comment 1 Yousuf Philips (jay) (retired) 2014-08-10 00:34:02 UTC
This was tested in 3.3.0 and 4.3.2 and 4.4.
Comment 2 Robinson Tryon (qubit) 2014-08-16 08:12:28 UTC
(In reply to comment #0)
> I was going through the pptx files found at <
> http://cgit.freedesktop.org/libreoffice/core/tree/chart2/qa/extras/data/ >
> and noticed that when i open them that they have multiple undos already
> listed which results in libreoffice asking me to save changes to the
> document when i havent made any.

CONFIRMED on LO 4.3.1.1 + Ubuntu 12.04

Repro steps:

1) Download and open file:
http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/chart.pptx
2) Immediately try to close document

RESULT: Prompted to save document

EXPECTED: Would not be prompted to save document, as I'd made no changes
Comment 3 Robinson Tryon (qubit) 2014-08-16 08:15:56 UTC
(Possibly) related problem:

1) Create new ODP document and set the title of the first slide to "Hello, world"
2) File -> Save "foobar.odp"
3) File -> Save as "foobar.pptx"
3b) Click "OK" to prompt to save in OOXML file format
4) Attempt to close the document

RESULT: Prompted to save document

EXPECTED: No prompt to save document


Now here's where it gets interesting: Try the same repro steps, but after saving "foobar.odp", close and reopen the document *first* before using "Save As" -> "foobar.pptx".

RESULT: No prompt to save document
Comment 4 Pieter van Oostrum 2015-03-29 15:14:59 UTC
Still the same on 4.4.1.2 on Mac OS X 10.10.2.

The UNDO's that the document starts with are renames of various objects. It seems that the renaming is done while loading the document in such a way that they are entered in the UNDO history. The history should be cleared after the loading has finished.
Comment 5 Robinson Tryon (qubit) 2015-12-07 16:36:49 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2017-01-03 19:41:02 UTC Comment hidden (obsolete)
Comment 7 Aron Budea 2018-05-27 05:59:37 UTC
Files don't open as modified anymore in LO 6.2 master daily build (f7f2d03bd6f5aa5dcd0f7976b4a7f2db278c2f03, 2018-05-25_05:00:28) / Windows 7. Closing as WFM.
Comment 8 Aron Budea 2021-09-14 22:58:33 UTC
Ultimately these were two different issues, and two different fixes.

chart.pptx stopped opening modified in the following commit in 5.2, but still had the undo steps:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d81d104833f0ee9349ebcd0d79d2de84ba9a7262
author		Michael Stahl <mstahl@redhat.com>	2016-02-12 18:22:51 +0100
committer	Michael Stahl <mstahl@redhat.com>	2016-02-12 18:54:33 +0100

"sfx2: related tdf#56270: loss of embedded objects imported from DOCX"

Then the unexpected undo steps are gone after the following commit in 6.1:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=02ea9bc36ab47d68940da55f5012677dfaf0a8b8
author		Tamás Zolnai <tamas.zolnai@collabora.com>	2017-12-21 05:44:04 +0100
committer	Tamás Zolnai <tamas.zolnai@collabora.com>	2017-12-21 11:23:45 +0100

"tdf#114613: Repair function does not work after opening PPTX file"