Using a more or less daily build from master, on OSX, the new dialog UI changes have caused message boxes to be incorrectly displayed, with a larger than life baox containing text that is generally right at the bottom of the rectangle and pushed to the right hand side. Apparent in at least : - Java classpath add archive dialog - About window - DB creation wizard main pane - Extension manager when clicking on a registered extension
Regression over 4.3 and 4.2.x
*** Bug 82450 has been marked as a duplicate of this bug. ***
"Who broke the fountain?" :)
(In reply to comment #3) > "Who broke the fountain?" > > :) This is a local joke, anyway, sorry for the noise. :)) Reproducible on the latest master BTW.
screenshot of much toooooooo long about window: https://bugs.freedesktop.org/attachment.cgi?id=104413
*** Bug 82526 has been marked as a duplicate of this bug. ***
This is due to http://cgit.freedesktop.org/libreoffice/core/commit/?id=6ca2d0d6645a697d323593a401ea8b1da02445bf
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c1e2c446865b355f50720b8b96ec704822006dc Resolves: fdo#82550 MacOSX GetTextBreak always return -1 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
That seems to fix it anyway, hopefully Norbert will have a look to see if its a desirable fix.
caolan said: "That seems to fix it anyway, hopefully Norbert will have a look to see if its a desirable fix." well I was about to commit something... but your fix seems 'better' What puzzle me is that nTextWidth in OuputDevice::GetTextBreak() does not look like a 'logical unit'. in the test of the about box.. it comes with a value of 485 and ImplLogicWidthToDevicePixel( nTextWidth ) return an insane value 4.10^6 or something like that can you confirm that nTextWidth there is indeed a logical unit ?
correction it is LogicWidthToDeviceCoordinate( nTextWidth ); that return the insane value
thanks for addressing this one.
Ok, I found the real bug.. it is in map.cxx I'll push something soon (will revert caolan's version)
Norbert Thiebaud committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d8584f62e28369594c5d1b733e5804837a98dd85 fdo#82550 LogicWidthToDeviceCoordinate missed handling of mbMap == false The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Norbert Thiebaud committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=47f3485579929724afc0c4c5ebdfd2143cf952be Revert "Resolves: fdo#82550 MacOSX GetTextBreak always return -1" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fix verified in Version: 4.4.0.0.alpha0+ Build ID: b5688eb1523754f94aaa5af6d372174cab1a4bd7 TinderBox: MacOSX-x86@49-TDF, Branch:master, Time: 2014-08-15_09:09:58 Thanks norbert.