Bug 82923 - slow import of filtered spreadsheets embedded in .docs
Summary: slow import of filtered spreadsheets embedded in .docs
Status: RESOLVED DUPLICATE of bug 90659
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
Depends on:
Blocks:
 
Reported: 2014-08-21 21:06 UTC by Michael Meeks
Modified: 2019-03-01 10:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
kcachegrind picture. (416.07 KB, image/png)
2014-08-21 21:06 UTC, Michael Meeks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2014-08-21 21:06:21 UTC
Created attachment 105063 [details]
kcachegrind picture.

I dumped a profile in amd/profiles/*bf2c2e*.txt.gz internally - available if anyone wants it.

I attach a KCachegrind screenshot - I guess that we're mis-using MDDS in:

ScXMLExport::OpenRow

which is chewing 17bn pcycles here.

Of course, it's a shame for the export of OLE objects to be dominating import cost quite so badly but ... hopefully its not such a horrible one to address.
Comment 1 QA Administrators 2015-09-04 02:48:48 UTC Comment hidden (obsolete)
Comment 2 Robinson Tryon (qubit) 2015-12-09 18:08:30 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2017-01-03 19:43:27 UTC Comment hidden (obsolete)
Comment 4 Roman Kuznetsov 2019-03-01 07:25:54 UTC
Michael, can you retest this bug? And may be attach an example file?
Comment 5 Michael Meeks 2019-03-01 10:44:33 UTC
I suspect Markus fixed this by using the span tree more intelligently:

commit 44c1cfc7d8ab7afb1e01ac57d3feeb410ba43748
Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date:   Wed Apr 13 12:37:10 2016 +0200

    no need to call rowHidden and rowFiltered repeatedly, tdf#90659

Thanks !

*** This bug has been marked as a duplicate of bug 90659 ***