Created attachment 105201 [details] mockup - before and after With the Sifr icon set, the chart icon has 2 pixels spacing between the two sections of the pie chart and with this amount of space, the center point of the pie chart isnt correctly represented with the larger/darker section. So i'd like to suggest that the spacing be reduce to 1 pixel, so that it does more closely represent a pie chart. Even more ideal would be that it had a third slice, but Sifr is a monochrome icon set, so thats not really possible. :D
I don’t see how your change means “fixing” the icon, as you say. In this case, two-pixel outlines are part of the GNOME Symbolic style (the basis of Sifr). See https://wiki.documentfoundation.org/Design/Whiteboards/Flat_icon_set#Guidelines, point 7.
(In reply to comment #1) > I don’t see how your change means “fixing” the icon, as you say. Maybe changing is the more appropriate word > In this case, two-pixel outlines are part of the GNOME Symbolic style (the > basis of Sifr). See > https://wiki.documentfoundation.org/Design/Whiteboards/ > Flat_icon_set#Guidelines, point 7. Here are icons in the current sifr set which have one-pixel outlines - paste, format painter, gallery, drawing functions, find & replace, insert image, freeform line. If two-pixel outlines is still the way to go, then 1 pixel should be removed from the darker portion and 1 pixel from the lighter portion, rather than 2 pixels from the darker portion. It would be nice if you would atleast allow me one response before closing my suggestions. :D
> […] rather than 2 pixels from the darker portion. Yeah, that sounds nice.
(In reply to comment #2) > before closing my suggestions You are mistaken. It has had NOTHING to do with you.
(In reply to comment #4) > You are mistaken. It has had NOTHING to do with you. Didnt quite get what you meant.
Created attachment 105355 [details] sc_drawchart-7.png
A little misunderstanding. Point 7 describes a 2 pixel spacing to the boundaries of the icon. This has nothing to do with the drawing inside, it is simple a 2px frame around the icon. ;-) What are you thinking about a cake with the pie without this unnecessary white line between them? See the two icons, which I'm uploaded.
Created attachment 105356 [details] lc_drawchart-8.png
Thanks Matthias for looking into this, but most icons have white 2-pixel spacing going through them and i think its best to stay with that theme. Also as there are only two pieces in the pie chart, i think a 90 degree small piece might be easier to understand.
just curious to have an update of the status of this report. is the change of that icon still under consideration or not?
I set status to NEEDINFO please give an update of the bug status
Matthias has already fixed this in bug 75256.