Search direction Rows searches by column and not by row. Didn't see any difference in results. I am searching by value.
Hi.. It's written in LibreOffice offline help: Search direction Determines the order for searching the cells. If you have another questions please start from here: http://ask.libreoffice.org/en/help/
Btw if you talked about "Find All" indeed something strange with that. Please provide test case and steps to reproduce your problem. Then change status back to UNCONFIRMED
Created attachment 105329 [details] Test case for FindAll by Row bug Do find All, searching for Wilson. Search results (whether by Rows or Columns) will show $A$2 $A$6 $D$2 $D$6 When searching for rows the search results should have been presented in this order: $A$2 $D$2 $A$6 $D$6
Hi again.. Thanks for the test case & explanation. Confim that Search direction with "Rows" or "Columns" doesn't make any difference in result ordering. Reproducible under Ubuntu 12.04 x86 with: LO 4.3.1.1, 4.2.6.2, 4.2.0.0.beta1
Just for my information, where's the option search by "Row" or "Column"? (didn't find it on UI and on Google, certainly missed something)
Hi Julien, sorry for not making this report clear enough after confirming. Steps to confirm the issue: 1. Open attach file 2. Find and replace (ctrl+H) 3. Search for: Wilson 4. Click 'Other Options' in the bottom of dialog box 5. We can choose in 'Search direction' either Rows or Columns Issue: ordering of search result (search direction either rows or columns) doesn't give any difference as explained in comment 3 Yes it's a minor bug or perhaps an enhancement (since feature of displaying find all result just introduced in 4.2), no dataloss.. :)
Thank you Ign_christian for your feedback! :-) I tested it with LO Debian package 4.2.6 + master sources updated yesterday, I don't reproduce this. The option row or column has indeed an impact on the way LO search. I'm a bit stuck right now :-(
> I tested it with LO Debian package 4.2.6 + master sources updated yesterday, > I don't reproduce this. Could you explain what you can't reproduce Julien? Perhaps I could help testing
the option Row/Column is indeed taken into account. I used Ctrl-H to make the whole dialog appear, selected Value (but also tried with formula), tested Row then Column and had the expected resulted described by moshepack's comment 3
(In reply to comment #9) Find works ok, but Find All does not. > the option Row/Column is indeed taken into account. > I used Ctrl-H to make the whole dialog appear, selected Value (but also > tried with formula), tested Row then Column and had the expected resulted > described by moshepack's comment 3
Moshepack was right. Hit "Find" button will correctly searching based on direction selected (rows/columns). This issue is only appear by hitting "Find All" button, the result list won't respect to rows/columns direction.
So sorry..step 6 should be exist in comment 6: 6. Hit "Find All" button
Sorry, forgot to check "Find all" option, will give a try tonight.
On pc Debian x86-64 with master sources updated today, I could reproduce this. Thank you for your patience! :-)
The problem is in Search function here: http://opengrok.libreoffice.org/xref/core/sc/source/core/data/table6.cxx#273 more precisely from big else block line 358 GetRowDirection matters only when Find All (bAll) isn't selected. So the little else block manages Find/Column and any direction of Find All by using column direction.
Kohei/Markus/Eike: Just thinking, what's the point to consider direction when selecting Find All? Also, searching backward won't display in reverse order the found cells but would it be relevant? In brief, what about indicating in searchresults box of FindAll, Row/Column and backward checkboxes are not taken into account?
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.0.5 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-09-03
Still confirmed. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI)
I submitted https://gerrit.libreoffice.org/#/c/20067/ for review (master branch)
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=71f0e4e5e2efee05bccf13698752e84f5059db5f tdf#83126: Find All: Don't ignore Search Direction Rows/Col option It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
In review for 5.0 branch, see https://gerrit.libreoffice.org/#/c/20105/
(In reply to Julien Nabet from comment #16) > Kohei/Markus/Eike: Just thinking, what's the point to consider direction > when selecting Find All? Also, searching backward won't display in reverse > order the found cells but would it be relevant? The original reason probably was that searching by columns instead of by rows and searching forward is faster, and when searching for All it actually doesn't matter in which order you search unless the results are to be displayed in found order. Displaying a result list was implemented only recently.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eea70492fb19b2dbd6edc0c37a2b0ed81b3ead5c&h=libreoffice-5-0 tdf#83126: Find All: Don't ignore Search Direction Rows/Col option It will be available in 5.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tested on LibreOffice 5.1.0.3 Fixed.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/040b3198fde3385e19e7380fdcabae84a0abac9d tdf#83126: sc: Add UItest It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.