Bug 83315 - Missing svx/res/notcertificate_16.png in tango theme prevents certificate warning icon in statusbar from displaying
Summary: Missing svx/res/notcertificate_16.png in tango theme prevents certificate war...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: Other Linux (All)
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: BSA target:4.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 21:10 UTC by Julien Nabet
Modified: 2014-09-13 00:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2014-08-31 21:10:07 UTC
Problem description: 
On console, during starting LO (master sources updated today) with a brand new profile, I got this:
warn:legacy.osl:16504:1:vcl/source/gdi/bitmapex.cxx:108: BitmapEx::BitmapEx( const ResId& rResId ): could not load image <svx/res/notcertificate_16.png>

Steps to reproduce:
1. just start LO and observe console


Operating System: Debian
Version: 4.4.0.0.alpha0+ Master
Comment 1 Julien Nabet 2014-08-31 21:13:49 UTC
I noticed this:
$ find . -name certificate_16.png
./icon-themes/human/xmlsecurity/res/certificate_16.png
./icon-themes/hicontrast/xmlsecurity/res/certificate_16.png
./icon-themes/galaxy/xmlsecurity/res/certificate_16.png
./icon-themes/oxygen/xmlsecurity/res/certificate_16.png
$ find . -name notcertificate_16.png
./icon-themes/hicontrast/svx/res/notcertificate_16.png
./icon-themes/hicontrast/xmlsecurity/res/notcertificate_16.png
./icon-themes/galaxy/svx/res/notcertificate_16.png
./icon-themes/galaxy/xmlsecurity/res/notcertificate_16.png

However even when using galaxy, I got this error message.
Comment 2 Joel Madero 2014-09-03 20:35:51 UTC
No error on my side:
master built two days ago on Bodhi (Ubuntu 12.04 fork)
Comment 3 Maxim Monastirsky 2014-09-11 19:55:47 UTC
A regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc0762af8c0e8d8399c00d36e50c4b439b1c7611

Actually this created a real bug, not just a warning. To test this open attachment 63269 [details]. There should be a colorful icon in the statusbar with a tooltip starting with "Digital Signature".
Comment 4 Commit Notification 2014-09-11 20:00:28 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1387027aa9acf9e62f2d7bf50f71a5889626d194

fdo#83315 Tango doesn't have notcertificate_16.png



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Julien Nabet 2014-09-11 20:57:53 UTC
Thank you Maxim! I'll update tomorrow and give it a new try.
Comment 6 Chris Sherlock 2014-09-12 09:23:54 UTC
FWIW, I committed a patch when investigating this to find out which theme was causing the problem. 

This problem happened on systems running gtk+ toolkits (Gnome systems mainly). 

The warning now states the icon theme being used. 

http://cgit.freedesktop.org/libreoffice/core/commit/vcl?id=8e174eab91acec0f1578af4dac23be76dce700af
Comment 7 Chris Sherlock 2014-09-12 11:07:20 UTC
This is still a problem, unfortunately removing the image from the list doesn't really resolve the actual problem, which is that as svx/res/notcertificate_16.png doesn't exist in the tango theme it prevents the certificate security icon in the statusbar from displaying.

Possibly something to update in the tango theme? There is a security-low icon in the latest tango icon theme.
Comment 8 Maxim Monastirsky 2014-09-12 11:10:27 UTC
(In reply to comment #7)
> it prevents
> the certificate security icon in the statusbar from displaying.
As already commented in the mailing list, it should now take the icon from Galaxy.
Comment 9 Chris Sherlock 2014-09-13 00:08:53 UTC
Oh... I'm really sorry, I had opened the wrong document. This is working fine, thanks for the patch. Sorry for reopening!