Observed on OSX 10.9.4/LO 4.4 master Not observed on LO 4.3.1.2 The attached document loads as a valid document, but is corrupted on save. The source content.xml (minimised from a larger file) contains three draw:custom-shape, but when saved again two of them appear to collide, leaving an XML element with repeated properties. As this is invalid XML, the file cannot be reopened. Running a bisect to find where the regression crept in...
Created attachment 105582 [details] Document which exhibits the bug
Bisect points to this commit, although the commit itself seems merely to enable other existing code. Cc added to Miklos Vajna - could you possibly shed any light on this? Thanks commit 9d310ecfce3c2fc481b125e1493a534e2107a68e Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Mon Jun 2 10:18:26 2014 +0200 sw textboxes: implement ODF import/export Map Writer shapes' new TextBox property to an loext:text-box boolean attribute. Change-Id: Ie47e15130adc1c480666c689c55a6c9e8460e385
Created attachment 105619 [details] A second minimised document which may or may not be related to the same bug (see comment) Attaching a second document minimised in a different way from the same source. This one chokes on an exception after "Select All" followed by "Cut" or "Delete" This may or may not be a result of the same underlying bug - they both contain draw:custom-shape objects but the symptom is obviously different. If it is not, a separate bug should be raised.
("Select All" in the previous comment means the whole document - you may have to do it twice to really select all)
Created attachment 105620 [details] A second minimised document which may or may not be related to the same bug (see comment) Accidentally (un)broke the second test case - replacing
Created attachment 105621 [details] Assertion from second document
Confirmed: Bodhi 2.x LibreOffice 4.4 built two days ago -- broken LibreOffice 4.3.1.2 release -- works fine New -- confirmed Major -- data corruption Highest -- regression + corruption
(This is an automated message.) LibreOffice development currently prioritizes bugs with the so called MAB (most annoying bugs) -- as this bug has not run through that process (including writing a short rationale for this bug being a candidate and other who are watching the tracker bug silently approving that rationale etc.) its priority is set to high. Note this is effectively no change in the urgency assigned to this bug, as we are currently not making a difference between high and highest and severity is untouched. You can find out more about MABs and how the process works by contacting libreoffice qa on irc: http://webchat.freenode.net/?channels=libreoffice-qa The QA wiki page also gives you hints on how to get in contact with the team (if IRC fails you, your next best choice is the mailing list): https://wiki.documentfoundation.org/QA
My 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF import/export, 2014-10-04) fixes this. It was before the libreoffice-4-4 branchoff and earlier branches are not affected, so closing as fixed. I'm sorry for not mentioning the bug number in the commit message. ;-)
Migrating Whiteboard tags to Keywords: (dataloss, bibisected) [NinjaEdit]