Bug 84073 - BASE Query Incorrect Syntax: Uppercase { OJ ... } Produced by Query Builder Joins Deviation, Produces Incompatibility
Summary: BASE Query Incorrect Syntax: Uppercase { OJ ... } Produced by Query Builder J...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: high major
Assignee: Not Assigned
URL: https://mariadb.atlassian.net/browse/...
Whiteboard: target:4.4.0 target:4.3.4
Keywords:
: 84092 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-19 02:36 UTC by Doug
Modified: 2014-10-11 18:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doug 2014-09-19 02:36:43 UTC
When LibreOffice Base creates query that includes outer join, it builds the query using the syntax " FROM { OJ ... } "

This syntax is rejected by connector, Maria DB client java library 1.1.7, although accepted by LO Native and MySQL connectors.  MariaDB folks say uppercase "OJ" is deviation from standard, web search suggests that lowercase is more common.  See link to bug report there.  Suggest syntax " FROM {oj ...} ".

Cross listing bug here.
Comment 1 Julien Nabet 2014-10-05 15:15:01 UTC
*** Bug 84092 has been marked as a duplicate of this bug. ***
Comment 2 Julien Nabet 2014-10-05 15:16:53 UTC
Confirmed thanks to the duplicate, increment the importance too
Comment 3 Julien Nabet 2014-10-05 15:19:20 UTC
Lionel: searching about OJ with Opengrok, I found this (perhaps not the right location):
http://opengrok.libreoffice.org/xref/core/connectivity/source/parse/sqlflex.l#292 

Should we put all this on lowercase or should we lowercase only in Mariadb and jdbc cases?
Comment 4 Lionel Elie Mamane 2014-10-05 15:36:57 UTC
ODBC also uses lower-case (see http://msdn.microsoft.com/en-us/library/ms714641%28v=vs.85%29.aspx )

So just change it to lower-case unconditionally.
Comment 5 Julien Nabet 2014-10-09 16:54:36 UTC
So thanks to the great Lionel's help, fixed with this:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee12e843c609e747be2f7d5a89ffd889c78378de

For 4.3, here's the pending gerrit review:
https://gerrit.libreoffice.org/#/c/11885/1