Bug 84792 - Icon "Square" is missing in Rectangles Toolbar
Summary: Icon "Square" is missing in Rectangles Toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: All All
: medium trivial
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:4.4.0
Keywords: needsDevEval, regression
Depends on:
Blocks:
 
Reported: 2014-10-08 07:48 UTC by Regina Henschel
Modified: 2015-12-18 10:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
how it looks in 4.3.3 (25.75 KB, image/png)
2014-10-09 13:18 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2014-10-08 07:48:12 UTC
Start Draw. Open the Rectangles toolbar via View > Toolbars. Notice the icon for "Square" is missing.
I see the defect in the Galaxy theme and the Tango theme as well.
Comment 1 Joel Madero 2014-10-08 17:01:26 UTC
Ubuntu 14.04 x64
LibreOffice 4.4 built a couple days ago

Confirmed

New
Trivial - just an icon, doesn't impact professional work at all
Medium - upped from lowest because of regression + easy fix.
Comment 2 Julien Nabet 2014-10-08 19:32:29 UTC
On pc Debian x86-64 with master sources updated 3 days ago, I could reproduce this.
I noticed this on console:
warn:legacy.osl:3470:1:vcl/source/gdi/image.cxx:395: ImageAryData::Load: failed to load image 'cmd/lc_square.png'
Comment 3 Joel Madero 2014-10-08 19:33:29 UTC
May Jay is interested in fixing this - he's been doing some nice icon stuff lately :)
Comment 4 Yousuf Philips (jay) (retired) 2014-10-09 13:18:12 UTC
Created attachment 107613 [details]
how it looks in 4.3.3

(In reply to Joel Madero from comment #3)
> May Jay is interested in fixing this - he's been doing some nice icon stuff
> lately :)

Icon is already present but for some reason its not being loaded, so there is little i can do in this department. :)

But what i can say is that if you compare 4.2 and 4.3, you can see that someone was switching the icons in the rectangle toolbar to be the same as the icons in the drawing toolbar's basic shapes' drop down, and forgot to switch it over for the rectangle icon and its likely that those old icons were removed in 4.4, which is why rectangle is shown as blank now.
Comment 5 Commit Notification 2014-10-30 23:02:57 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2633e57dafd5e566ba0ad9a11b9b37f8369fdc9a

fdo#84792 Correct the link for cmd/lc_square.png

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Maxim Monastirsky 2014-10-30 23:15:04 UTC
Seems there is a similar issue with the small icon...
Comment 7 Commit Notification 2014-10-30 23:16:40 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c91e045c12ac5dffc20c04c6f97db4892c1e558d

fdo#84792 Correct the link for cmd/sc_square.png

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Yousuf Philips (jay) (retired) 2014-10-31 14:10:53 UTC
Hope you'll backport this to 4.3. :D
Comment 9 Maxim Monastirsky 2014-11-01 18:11:45 UTC
(In reply to Jay Philips from comment #8)
> Hope you'll backport this to 4.3. :D
Backporting is not possible, because 4.3 doesn't have these wrong links in links.txt. Probably what you mean is to fix the Tango theme, so it will use the same icon as the Basic Shapes drop down. Is that right?
Comment 10 Yousuf Philips (jay) (retired) 2014-11-01 22:01:46 UTC
(In reply to Maxim Monastirsky from comment #9)
> Backporting is not possible, because 4.3 doesn't have these wrong links in
> links.txt. Probably what you mean is to fix the Tango theme, so it will use
> the same icon as the Basic Shapes drop down. Is that right?

Yes fixing that it uses the same icon as the drop down. :D
Comment 11 Robinson Tryon (qubit) 2015-12-18 10:37:40 UTC
Migrating Whiteboard tags to Keywords: (needsDevEval)
[NinjaEdit]