Created attachment 107814 [details]
you can see a red line under each color icon
While using the galaxy icon set, when a font, highlight or background color is set, the square that is draw on the icon is 1 pixel higher than it should be, which results in a red 1 pixel line appearing below the selected color. Tested on Linux and Windows on master.
AFAIC see, only with the large icons.
I thought is was a feature ;)
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.1 or preferably 188.8.131.52 or later)
If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword
Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa
Thank you for your help!
-- The LibreOffice QA Team This NEW Message was generated on: 2015-10-14
Win 7 Pro 64-bit Version: 184.108.40.206.alpha0+
Build ID: 9784ff3d878eaa21491fbd779e57d7d4710f5449
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default;
TinderBox: Win-x86@39, Branch:master, Time: 2016-01-30_01:31:57
Locale: fi-FI (fi_FI)
The reason is clear, but not the solution.
The calculation in line#161 in method ToolboxButtonColorUpdater::Update in file svx\source\tbxctrls\tbxcolorupdate.cxx uses implicit integer arithmetic, and the implementation of point, size and rectangle in tools/gen.cxx seems to assume integer row and column numbers instead of a coordinate system.
If the icon size is a multiple of 4, there are no rounding problems. Problems are for icon size 22×22 and for icon size 26×26
Breeze, Elementary, Human, Industrial, Sifr, Tango: 24×24, no problem
Crystal: 22×22, are not delivered, has no such icon, no problem
Vertical update range row 16..20.
Calculation height of update range = 22 / 4 = 5, OK
Calculation of top = 22 * 3 / 4 = 66 /4 = 16. OK
The icons in Oxygen are transparent in pixel row 21.
Galaxy, High contrast: 26×26
Vertical update range row 20..25
Calculation height of update range = 26 / 4 = 6, OK
Calculation of top = 26 * 3 / 4 = 78 / 4 = 19. Wrong.
Problem: It is not possible to generally round up, or to generally count from the bottom row, because it then does not fit for Oxygen.
(A) Make the calculation depend on number of pixel rows (22/26/others).
(B) Move the update range in Galaxy and High Contrast one pixel up.
(C) Reduce the icon size in Galaxy and High Contrast for these icons to 24×24. The theme Galaxy has already some icons of size 24×24.
I would go with solution A or B. Which ever is easiest.
I will align the color bar with the bottom edge of the icon. That is already the appearance in those icon themes, which use a pixel width, which is divisible by 4. So for them the new calculation makes no difference.
We need no longer consider icon-theme oxygen. It will be removed, read minutes of ESC call from 2016-02-11.
If someone nevertheless will adapt oxygen:
* Shift the area in the lower part by 1 pixel down in lc_color.png.
* Remove icons lc_fontcolor.png, lc_backcolor.png and add a mapping in file links.txt; those icons are identical to lc_color.png
* Make a new icon for lc_extrusion3dcolor.png. The current one is only a copy from the galaxy theme and therefore has a wrong icon size.
In theme Galaxy only the icon lc_extrusion3dcolor.png needs to be adapted, and the icon lc_backcolor.png from the language version "bg".
Using an unambiguous alignment makes it easier for authors of custom icon-themes to create proper icons.
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":
tdf#84985 always align color bar to icon bottom edge
It will be available in 5.2.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.