Bug 85776 - SIDEBAR: Swap increase and decrease indent buttons
Summary: SIDEBAR: Swap increase and decrease indent buttons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.3 Daily
Hardware: Other All
: medium normal
Assignee: Yousuf Philips (jay) (retired)
URL:
Whiteboard: target:4.4.0
Keywords:
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2014-11-02 21:36 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-10-24 15:13 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-11-02 21:36:18 UTC
In the sidebar, the norm is to have increase buttons on the left and decrease on the left, as can be seen in font and spacing increasing, but this doesnt occur with the increase indent button.
Comment 1 A (Andy) 2014-11-02 23:19:24 UTC
Reproducible with LO 4.3.3.2, Win 8.1.  
I don't know, if there was a specific reason for the other arrangement of the indent icons.  Maybe, because the arrangement of the arrows looks maybe nicer and because (what I would suppose) the increase of indent goes in the document (if you look at the indent in a document) to the right and the decrease goes to the left if you decrease the indent (like driving a car to the left and to the right).  
Therefore, I am not sure whether this should be rearranged, because for me this ok and seems to be consistent and intuitive.  That's why, I personally think we could let it that way even if it is different to the font and spacing increase/decrease.  I personally would prefer it that way.  

@Jay: Do I understand that rightly, that you would like to have it the other way?
Comment 2 Yousuf Philips (jay) (retired) 2014-11-03 02:10:08 UTC
Hi Andy,

(In reply to A (Andy) from comment #1)
> @Jay: Do I understand that rightly, that you would like to have it the other
> way?

Yes it is better to have it the other way.

Firstly the black icons that are currently used in the toolbar and sidebar are the wrong icons, as someone put in the right-to-left versions rather than the left-to-right version ( https://redmine.documentfoundation.org/attachments/download/312/gnome%20tango%20idents.png ).

But even if the correct ones were used, when increase and decrease are placed next to each other, increase is always on the left and decrease on the right. You can find this in the print preview view with the zoom icons. You can find the same in the table toolbar, with inserting a row on the left and deleting a row on the right. You can find this in calc with the sort ascending and descending buttons in the toolbar. You can also find it in calc with the number format decimal places buttons.

We also have the OOo stats which state that increase is used more than decrease, which is why it will be in this order as well in the toolbar.
Comment 3 tommy27 2014-11-03 04:45:01 UTC
I agree with the swap. it's a matter of consistency to have the increase on the left and the decrease on the right.
Comment 4 Yousuf Philips (jay) (retired) 2014-11-12 22:41:22 UTC
Patch is in (i hope) - https://gerrit.libreoffice.org/#/c/12396/
Comment 5 Commit Notification 2014-11-13 07:11:57 UTC
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6c7c618d1c4f78d4e11fcc9ee40f70aff583c90

fdo#85776 swap increase and decrease indent in sidebar

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.