Bug 86466 - Wrong background color shown in format table in impress
Summary: Wrong background color shown in format table in impress
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
4.3 Daily
Hardware: All All
: medium normal
Assignee: Caolán McNamara
Whiteboard: target:4.4.0
Keywords: regression
Depends on:
Reported: 2014-11-19 15:10 UTC by Caolán McNamara
Modified: 2014-11-21 13:49 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

bugdoc (435.17 KB, application/vnd.oasis.opendocument.presentation)
2014-11-19 15:53 UTC, Andras Timar
this is the way I'm thinking at the moment, seems like it should be plausible (2.26 KB, patch)
2014-11-20 15:54 UTC, Caolán McNamara
this seems to do what we all want I think (7.29 KB, patch)
2014-11-20 17:33 UTC, Caolán McNamara

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2014-11-19 15:10:33 UTC
Impress, insert->table, ok, click in cell A1B1, background is grey, right click->table, the selected colour is "Tango: Sky Blue 1"

If I revert 

commit 440e2031ce8cffc8dc573e359a330236f9c11dfb
Author: Matúš Kukan <matus.kukan@collabora.com>
Date:   Tue Jun 3 14:11:39 2014 +0200
    bnc#882627: Allow to edit spacing to contents even with no borders visible.

then it is grey as expected
Comment 1 Andras Timar 2014-11-19 15:53:00 UTC
Created attachment 109737 [details]

The commit solved a bug with the attached document. The bug was:

"The table cannot be resized and values in the fields cannot be centered (vertically), because cell padding does not allow that. Impress does not let the user to change this "spacing to content" value."
Comment 2 Caolán McNamara 2014-11-19 17:52:40 UTC
aha, bulleting and paragraph alignment get all busted up on changing border distances otherwise.
Comment 3 Caolán McNamara 2014-11-19 17:54:03 UTC
I think that in itself is possibly another older regression
Comment 4 Caolán McNamara 2014-11-20 14:32:25 UTC
and the older regression is

commit 9e5342509b302ba1f816f21cc3ad1cb7093982e0
Author: David Tardon <dtardon@redhat.com>
Date:   Mon Jun 3 14:22:07 2013 +0200

    copy values from the original item set
    ... because SfxAbstractDialog::GetOutputItemSet() only contains the
    items that have been _changed_ in the dialog.

which is where the non-border/background etc properties get stripped off when you use the dialog which the later commit seems to want to fix
Comment 5 Caolán McNamara 2014-11-20 15:54:27 UTC
Created attachment 109759 [details]
this is the way I'm thinking at the moment, seems like it should be plausible

but still seeing various pieces of oddness and some intermittent crash on some combinations
Comment 6 Caolán McNamara 2014-11-20 16:24:44 UTC
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3a9a9542b018f781ee12e6c8c943d4f19641afe for the intermittent crash, master only.
Comment 7 Caolán McNamara 2014-11-20 17:33:13 UTC
Created attachment 109763 [details]
this seems to do what we all want I think
Comment 8 Commit Notification 2014-11-21 13:41:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":


Resolves: fdo#86466 Wrong background color shown in format table in impress

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2014-11-21 13:49:07 UTC
Seems to make both cases work well at the same time