Bug 86511 - 'Blue 1' is set to the same color as 'Sky Blue 1'
Summary: 'Blue 1' is set to the same color as 'Sky Blue 1'
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: Other All
: low normal
Assignee: V Stuart Foote
URL:
Whiteboard: target:4.5.0 target:4.4.0.0.beta2
Keywords:
: 79201 (view as bug list)
Depends on:
Blocks: Color-Palettes
  Show dependency treegraph
 
Reported: 2014-11-21 05:54 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-11-22 16:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
color drop down box (21.44 KB, image/png)
2014-11-21 05:54 UTC, Yousuf Philips (jay) (retired)
Details
correct color assigned to "Sky blue 1" (144 bytes, text/plain)
2014-12-04 01:18 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-11-21 05:54:26 UTC
Created attachment 109793 [details]
color drop down box

Blue 1 and Sky Blue 1 are both set to 9999ff. In LO 4.0, Blue 1 was set to 4700b8.

Version: 4.4.0.0.alpha2+
Build ID: 741bc7c44feb285f2cb210b04500b27b510f8f4c
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-11-18_19:44:40
Comment 1 Maxim Monastirsky 2014-11-21 09:41:32 UTC
Confirmed.

(In reply to Jay Philips from comment #0)
> In LO 4.0, Blue 1 was set to 4700b8.
4700b8 doesn't fit well with the current palette gradients. Feel free to propose a new color for this. The standard palette is at extras/source/palettes/standard.soc
Comment 2 Yousuf Philips (jay) (retired) 2014-11-21 12:11:04 UTC
(In reply to Maxim Monastirsky from comment #1)
> 4700b8 doesn't fit well with the current palette gradients. Feel free to
> propose a new color for this. The standard palette is at
> extras/source/palettes/standard.soc

Looked over the palette and find it quite confusing as its not following a proper gradient pattern that you normally see in color pickers, as you have colors in row 2 that should be in on row 4, etc. It would be good to pass this onto the people who came up with the new palette to see what went wrong here.

I also find it weird gradient-wise to have black next to white on the first row.
Comment 3 Maxim Monastirsky 2014-11-21 13:13:01 UTC
(In reply to Jay Philips from comment #2)
> It would be good to pass
> this onto the people who came up with the new palette to see what went wrong
> here.
You can watch the history of the palette:
http://cgit.freedesktop.org/libreoffice/core/log/extras/source/palettes/standard.soc

The new palette was ported from Apache. See the proposal in https://issues.apache.org/ooo/show_bug.cgi?id=121520.

> I also find it weird gradient-wise to have black next to white on the first
> row.
As you can see from the history, it was enforced twice by M. Meeks and Caolán. You should ask them on this topic.
Comment 4 Julien Nabet 2014-11-23 22:04:24 UTC
*** Bug 79201 has been marked as a duplicate of this bug. ***
Comment 5 Yousuf Philips (jay) (retired) 2014-11-24 04:36:21 UTC
(In reply to Maxim Monastirsky from comment #3)
> The new palette was ported from Apache. See the proposal in
> https://issues.apache.org/ooo/show_bug.cgi?id=121520.

Thanks for the link. Well i submitted the issue to them and lets see what they say. :D
https://issues.apache.org/ooo/show_bug.cgi?id=125897

> As you can see from the history, it was enforced twice by M. Meeks and
> Caolán. You should ask them on this topic.

I guess i will if others in the design team feel the same way about it. :D
Comment 6 Yousuf Philips (jay) (retired) 2014-11-25 16:30:12 UTC
Was mistaken about Blue 1 value in 4.0, i had given the value of Blue 2. The correct Blue 1 was 280099.
Comment 7 V Stuart Foote 2014-12-04 00:20:47 UTC
Looking at this in ColorZilla and adjusting the standard.soc pallet, the correct value for "Sky blue 1" should probably be #66ccff, while "Blue 1" is set correctly relative to the Red 1, and Green 1.
Comment 8 V Stuart Foote 2014-12-04 01:18:48 UTC
Created attachment 110437 [details]
correct color assigned to "Sky blue 1"

Suggested patch attached if someone cares to clean up and submit...

@@ -40,1 +40,1 @@
-  <draw:color draw:name="Sky blue 1" draw:color="#9999ff"/>
+  <draw:color draw:name="Sky blue 1" draw:color="#66ccff"/>
Comment 9 V Stuart Foote 2014-12-04 01:20:16 UTC
Comment on attachment 110437 [details]
correct color assigned to "Sky blue 1"

Patch of root/extras/source/palettes/standard.soc
Comment 10 Commit Notification 2014-12-04 16:12:13 UTC
V Stuart Foote committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e95ae3278b71fc56fa6cdab9ecff4c5bdbdda583

fdo#86511: Fix the RGB value of 'Sky blue 1' color.

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2014-12-04 19:43:59 UTC
V Stuart Foote committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa2ac4cf5fc268b07dab42c2f610fb62f214a69c&h=libreoffice-4-4

fdo#86511: Fix the RGB value of 'Sky blue 1' color.

It will be available in 4.4.0.0.beta2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Yousuf Philips (jay) (retired) 2014-12-06 06:12:47 UTC
At the end of the design meeting, Mahfiaz suggested #69c1ff and #66bdfa, which i think do blend better with the palette than #66ccff, as #66ccff seems to light/bright.
Comment 13 mahfiaz 2014-12-06 09:36:45 UTC
I actually prefer the second one of which were proposed, the slightly darker one (so does jphilipz): #66bdfa

Then again, I am aware that the palette is so-called "web-safe" and this would be the single breaking of that. So not having it is just as fine.
Comment 14 V Stuart Foote 2014-12-06 19:08:24 UTC
(In reply to Jay Philips from comment #12)
> At the end of the design meeting, Mahfiaz suggested #69c1ff and #66bdfa,
> which i think do blend better with the palette than #66ccff, as #66ccff
> seems to light/bright.

Probably true, but I handled it less as an issue of designing the appropriate color for the pallet, and more identifying the color omitted when AOO integrated the Symphony contribution. 

The #66ccff color follows the color sequence IBM had used to generate the "Base colors step 1" included in standard.soc pallet. Simply used it.