Bug 86687 - FILESAVE: Saving as XLS file will cause calc to freeze
Summary: FILESAVE: Saving as XLS file will cause calc to freeze
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Matthew Francis
URL:
Whiteboard: target:4.5.0 target:4.4.0.0.beta2
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2014-11-25 07:20 UTC by Luke
Modified: 2015-12-17 08:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Backtrace from deadlock (3.79 KB, text/plain)
2014-11-27 02:36 UTC, Matthew Francis 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2014-11-25 07:20:56 UTC 
Steps to Reproduce:
1. In a recent build of Calc 4.5, Open attachment 105590 [details]
2. File -> Save as -> *.xls

Results:
4.2.6.3 - GOOD, saved correctly
4.5.0.0.alpha0+ - Freezes Calc
Comment 1 raal 2014-11-26 19:43:28 UTC 
I can confirm with Version: 4.4.0.0.alpha2+
Build ID: d273a60bfdbf9bb7623bed38667ec0647753157c
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-11-20_03:05:21
Comment 2 raal 2014-11-26 19:47:39 UTC 
No freeze with LO 4.3.3.2, regression
Comment 3 Matthew Francis 2014-11-27 02:19:20 UTC 
The hang started from this commit:


Author: Michael Meeks <michael.meeks@collabora.com>
Date:   Thu Oct 30 22:51:59 2014 +0000

    Thread excel table row/column format finalization.
    
    Change-Id: I6ddc0270831989291893b170d57fea14329a26ba
Comment 4 Matthew Francis 2014-11-27 02:36:02 UTC 
Created attachment 110100 [details]
Backtrace from deadlock

Looks like the fact that the progress bar updates have been shifted to a helper thread is causing a deadlock
Comment 5 Matthew Francis 2014-11-27 04:28:33 UTC 
-> https://gerrit.libreoffice.org/13147
Comment 6 Commit Notification 2014-11-27 13:32:24 UTC 
Matthew J. Francis committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d83b031346799bff0a3298387f76b16baad2e5cf

fdo#86687 Avoid deadlock updating progress bar

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2014-11-27 13:34:39 UTC 
Matthew J. Francis committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e678a333c1f4a7a1bf8594d888938e598ed2f6a1&h=libreoffice-4-4

fdo#86687 Avoid deadlock updating progress bar

It will be available in 4.4.0.0.beta2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Robinson Tryon (qubit) 2015-12-17 08:40:03 UTC 
Migrating Whiteboard tags to Keywords: (bibisectRequest)
[NinjaEdit]