Download it now!
Bug 86689 - Strikethrough: "With /" and "With X" does not work anymore in Version 4.4.0
Summary: Strikethrough: "With /" and "With X" does not work anymore in Version 4.4.0
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.3.2 release
Hardware: x86-64 (AMD64) All
: medium major
Assignee: Julien Nabet
URL:
Whiteboard: target:4.5.0 target:4.4.0.0.beta2 ta...
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-11-25 07:57 UTC by Kevin Suo
Modified: 2014-11-26 10:12 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2014-11-25 07:57:26 UTC
Steps to reproduce:

1. New Writer;

2. Type some text, select the text;

3. Right-click -> Character -> Font Effects -> Strikethrough: "With /", then OK. (Now the text has "////" as strikethrough, this is exptected)

4. Repeat step 3, but this time apply Strikethrough: "With X", then OK.
--> Current Result: At step 4, text is still showing "///" as strikethrough, while "XXX" is expected.

Further Steps:

5. Apply Strikethrough: With "X" first, then apply With "/"
--> text is showing "XXX" as strikethrough, while "///" is expected.

Version: 4.4.0.0.beta1
Build ID: 9af3d21234aa89dac653c0bd76648188cdeb683e
Locale: zh_CN
Win 7 X64.

Do not reproduce in version 4.3.4.1, so it's a regression.
Comment 1 Julien Nabet 2014-11-25 20:48:01 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 Julien Nabet 2014-11-25 22:03:32 UTC
Pb in OutputDevice::ImplDrawStrikeoutChar, file vcl/source/outdev/textline.cxx
Comment 3 Commit Notification 2014-11-25 22:07:00 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f46a5d6dfddf86be0d77e00cf44f26af54a97c75

Resolves fdo#86689: Strikethrough: "With /" and "With X"

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2014-11-26 10:08:50 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e22ad3682a07ae45fcd53a0f9e29a8166eb2d48a&h=libreoffice-4-4

Resolves fdo#86689: Strikethrough: "With /" and "With X"

It will be available in 4.4.0.0.beta2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Julien Nabet 2014-11-26 10:12:42 UTC
For 4.3: this one has been merged https://gerrit.libreoffice.org/#/c/13126/, would be ok for 4.3.6 (just a little too late for 4.3.5)

BTW, it was KO too for LO Debian package 4.3.3