When running spellcheck in Writer without the dictionary for the default language installed, spellcheck appears to check spelling and comes back with "The spellcheck is complete", rather than flagging an error. To reproduce, change default language to any language you do not have the dictionary installed for, and run spellcheck. It would be much more sensible if spellcheck flagged the fact that the relevant dictionary is not installed and it cannot check the spelling, rather than acting as if it has checked the spelling and found no errors.
Szymon Kłos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/33f6848dc5abe71471b08dc6a8946feaa2d75ffc%5E%21 tdf#86731 Don't show 'spelling complete' when dictionary is missing It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping to Szymon Kłos: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks
Done: "The spellcheck is complete" dialog is not shown. Missing: It would be good to show "No dictionary is available" dialog. - this could be an easy hack, I think. Pointer: sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx:420 MessageDialog is used to show warning/info.
Hi Szymon Kłos, Thanks for the code pointer. Let turn it into an easyhack then...
A polite query regarding this bug. I have submitted a patch for this bug and it built successfully on review by sir Jenkins. A +1 is been shown against verified and its written that this change needs Code Review Label. It would be great if somebody could help me out as to what is to be done from my side.
@Szymon: I have reviewed the patch at https://gerrit.libreoffice.org/69366; I see the code looks reasonable - but since I cannot reproduce the problem myself, could you please review the patch?
Created attachment 150100 [details] example file for testing (works if you don't have Somali dictionary)
Vaibhav committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/35027d2e9fff6e674609fe0659c1ebb8b79c2c1a%5E%21 tdf#86731: Add the dictionary not available message It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixed, Thank you Vaibhav Rastogi :)
Szymon Kłos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a50a2bf8e8c6084aeacb8d2db42e21f528410742 tdf#86731 Don't show 'start from beginning' when dictionary is missing It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/f200dd5cb84681558700c49de0969907f78f8db1 tdf#86731 Don't show 'start from beginning' when dictionary is missing It will be available in 6.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
We went full circle here. The message already wouldn't be shown after Szymon's commit in comment 10 due to the condition always being false, and now even the code that would show it was completely removed in the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=816b51c7a9cdd72eaa01f3c074ba5a8446917d19 author Xisco Fauli <xiscofauli@libreoffice.org> 2024-11-22 12:48:41 +0100 committer Xisco Fauli <xiscofauli@libreoffice.org> 2024-11-22 14:24:44 +0100 "PVS: V547 Expression 'bNoDictionaryAvailable' is always false" Szymon, Xisco, it would be good to get back to a state that actually shows the message, what are your thoughts?
Hi Aron, it's not my call. My commit is just a clean-up I found with PVS analyzer. It can be reverted if someone wants to fix this issue again.
Hi, I'm working on it
Szymon Kłos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/16bce5bb1cb4e446f45633b128f6ab02a48b6840 tdf#86731 bNoDictionaryAvailable should trigger meesagebox It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/058f0d1cac5d9e5d109dc7fe360bf03f8e1facc1 tdf#86731 bNoDictionaryAvailable should trigger meesagebox It will be available in 24.8.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Seems OK now, thanks Vaibhav, Szymon!