Bug 87121 - CMIS Google Drive fails on accounts with password which includes special characters
Summary: CMIS Google Drive fails on accounts with password which includes special char...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
4.3.4.1 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-08 21:33 UTC by kurt forrester
Modified: 2021-07-28 13:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kurt forrester 2014-12-08 21:33:11 UTC
Version: 4.3.4.1
Build ID: bc356b2f991740509f321d70e4512a6a54c5f243

Also on 4.4.0.0 beta1 

Windows 8.1

I am trying to connect to a google account where the password includes several special characters in the password. The CMIS fails to return 'Google Drive' in the repository dropdown box which causes the failure of the connection to complete.

Subsequently I created a 'fresh' gmail account where I set the password to a simple ascii only password and the connection works.

There appears to be an issue with the escaping of the password when handling the authorisation.

Kurt
Comment 1 Joel Madero 2014-12-09 01:26:21 UTC
Hey Kurt,

Can you provide step by step instructions on how to do this? It's always best for the reporter of a bug to provide step by step instructions because it's impossible for us to know everything that LibreOffice is capable of and is almost always faster for a user to explain the use case, give explicit instructions, and then we'll try to reproduce.

Please include an example password that we can try for our google drive account 

Setting to NEEDINFO - once you provide clear steps please set the bug to UNCONFIRMED. Thanks!
Comment 2 kurt forrester 2014-12-09 08:46:06 UTC
With Libreoffice set to "Use LibreOffice dialogue boxes" checked (Tools->Options->LibreOffice->General)

1. Open new Writer document
2. Save As
3. Clicker "Server..." button
4. Give server name `server name`
5. Select "CMIS" file service type
6. Server details "Google Drive"
7. Press refresh button next to Repository dropdown box
8. Fill in username and password (need to employ a password such as `&password` specifically with ampersand)
9. Nothing happens

What should happen
If the gmail account has a password without ampersand then the connection is made and the repository "Google Drive" appears in the dropdown list enabling the OK button to be clicked.

Hope that is enough to replicate the problem.

Thanks,

Kurt
Comment 3 kurt forrester 2014-12-10 04:16:18 UTC
just setting to unconfirmed after updated steps.
Comment 4 Joel Madero 2014-12-10 17:33:40 UTC
(In reply to kurt forrester from comment #2)
> With Libreoffice set to "Use LibreOffice dialogue boxes" checked
> (Tools->Options->LibreOffice->General)
> 
> 1. Open new Writer document
> 2. Save As
> 3. Clicker "Server..." button
> 4. Give server name `server name`
> 5. Select "CMIS" file service type
> 6. Server details "Google Drive"

I'm not seeing this step. When I select CMIS and then do the dropdown next to "Server Type" I see the following:

Alfresco 4
IBM FileNet P8
Lotus Live Files
Nuxeo 5.4
OpenDataSpace
OpenText ELS 10.2.0
SharePoint 2010

Are you using an extension?
Comment 5 kurt forrester 2014-12-11 05:58:15 UTC
I am using the vanilla version 4.3.4.1 from the Document Foundation website (http://donate.libreoffice.org/home/dl/win-x86/4.3.4/en-GB/LibreOffice_4.3.4_Win_x86.msi). This is a new feature within the CMIS system so unless you are running the same version then I think you will not see the functionality that I and reporting against.

Can you confirm you are using Windows and the version noted in the bug report?

Kurt
Comment 6 Joel Madero 2014-12-16 16:54:25 UTC
Windows 7
LibreOffice 4.3.4.1 release

Confirmed:

Setting to:
New
Comment 7 Joel Madero 2014-12-16 17:07:17 UTC
Adding Cedric as he was involved with implementation of Google Drive stuff.
Comment 8 kurt forrester 2015-01-19 11:21:52 UTC
Bump
Comment 9 Joel Madero 2015-01-21 23:01:01 UTC
Please don't "bump" bugs - it literally does nothing other than annoy developers and clog the bug tracker. Thanks
Comment 10 Cédric Bosdonnat 2015-01-22 07:58:45 UTC
Just to mention that I really have no time to work on it these days... will thus suffer from delay in fixing it.
Comment 11 QA Administrators 2017-03-06 15:50:59 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2019-12-03 14:27:16 UTC Comment hidden (obsolete)
Comment 13 Buovjaga 2021-07-28 06:27:34 UTC
There have been several fixes to G. Drive support over the years. Bug 101630 just got a fixing commit, could you please re-test with Win-x86_64@tb77-TDF https://dev-builds.libreoffice.org/daily/master/current.html after it has a build from 2021-07-28 or later?
Comment 14 Buovjaga 2021-07-28 13:33:28 UTC
Cloph tells me the authentication now happens in the browser with the server directly, LibreOffice only gets the return code, so this is obsolete.