Created attachment 111087 [details] Test document The Styles-dropdown preview always uses the “Western” font even if the previwed text is CTL text. For example, the attached document have a single word set in a style that uses “DejaVu Serif” for Western text and “DejaVu Sans” for CTL text, the preview contains Arabic text (when using Arabic interface) but it will use “DejaVu Serif” not “DejaVu Sans” and thus does not reflect the actual effect of applying this style to Arabic text.
Thanks, marking as NEW.
This is apparently because in https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=svx/source/tbxctrls/tbcontrl.cxx;hb=HEAD#l589 only SID_ATTR_CHAR_FONT is used, bit not SID_ATTR_CHAR_CTL_FONT nor SID_ATTR_CHAR_CJK_FONT. Apparently OutputDevice takes only one font, so it probably does not do script itemization, but I’m not sure what is the proper way to handle the itemization.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.4 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT: - Update the version field - Reply via email (please reply directly on the bug tracker) - Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2016-01-17
Khaled: IIRC there is now some style preview in the sidebar too. Please does the style preview in the sidebar render this correctly? If yes, I suppose we should just share the code here with what is in the sidebar :-)
(In reply to Jan Holesovsky from comment #4) > Khaled: IIRC there is now some style preview in the sidebar too. Please > does the style preview in the sidebar render this correctly? If yes, I > suppose we should just share the code here with what is in the sidebar :-) The sidebar in 5.0 shows the same behaviour reported here, I can’t test on master right now. I suspect the same problem in comment 2 is the cause here.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.2.5 or 5.3.0 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170306
Dear Khaled Hosny, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Dear Khaled Hosny, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/044fc5c8b225732d57970d3bf0720c13a5a9e0a4 tdf#87535: Preview styles using CTL/CJK fonts in the styles menu It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0483fbd1d05d74c394d9274bdee77b3b2aebb495 tdf#87535: Preview styles using CTL/CJK fonts in the sidebar It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Khaled, a follow-up, maybe a regression: In 7.4, the 1 was on the left of the heading preview (which is correct according to the style properties). In 7.5, it is now displayed to the right. Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
(In reply to Stéphane Guillou (stragu) from comment #11) > Khaled, a follow-up, maybe a regression: > > In 7.4, the 1 was on the left of the heading preview (which is correct > according to the style properties). In 7.5, it is now displayed to the right. Yes, thanks for the reminder. This is a common issue in all these preview widgets, they are splitting text in a simplistic way (I think you can get the same issue with, say, font preview in the Characters dialog). We probably should track thi sin a different bug as it needs addressing in general, may be by finding away to use the real layout engine from EditEngine and not try to replicate it and do bad job at it.
(In reply to خالد حسني from comment #12) > We probably should track thi sin a different bug as it needs addressing in > general, may be by finding away to use the real layout engine from > EditEngine and not try to replicate it and do bad job at it. To make sure the regression itself is tracked, we have now: Bug 152460 Note that regarding this bug here, the style previews in the Tabbed UI still use the Western front. Not sure if it is straight forward to apply your fix to that part of the UI too? In any case, use of proper font is verified in both the sidebar and the dropdown. Thanks!
(In reply to Stéphane Guillou (stragu) from comment #13) > (In reply to خالد حسني from comment #12) > > > We probably should track thi sin a different bug as it needs addressing in > > general, may be by finding away to use the real layout engine from > > EditEngine and not try to replicate it and do bad job at it. > > To make sure the regression itself is tracked, we have now: Bug 152460 > > Note that regarding this bug here, the style previews in the Tabbed UI still > use the Western front. Not sure if it is straight forward to apply your fix > to that part of the UI too? > > In any case, use of proper font is verified in both the sidebar and the > dropdown. Thanks! LibreOffice grew more preview widgets since I opened this issue, and I think I overlooked this one. I’ll give it a try.