Bug 87638 - Slide Pane should be titled 'Master Slides' when in master view
Summary: Slide Pane should be titled 'Master Slides' when in master view
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Slide-Page-Pane Master-Slide-View
  Show dependency treegraph
 
Reported: 2014-12-23 15:35 UTC by Yousuf Philips (jay) (retired)
Modified: 2023-10-02 08:25 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-12-23 15:35:48 UTC
In Impress, when you enable slide master view (View > Master > Slide Master) the left slide pane is still titled 'Slides' and would be better titled 'Master Slides' when in this view.
Comment 1 A (Andy) 2014-12-31 15:00:14 UTC
This sounds reasonable and good for me.
Comment 2 Robinson Tryon (qubit) 2016-08-25 05:39:24 UTC Comment hidden (obsolete)
Comment 3 Heiko Tietze 2017-08-28 12:08:27 UTC
Dup of and fixed with bug 87592

*** This bug has been marked as a duplicate of bug 87592 ***
Comment 4 Yousuf Philips (jay) (retired) 2017-08-31 12:40:32 UTC
(In reply to Heiko Tietze from comment #3)
> Dup of and fixed with bug 87592

This isnt a duplicate and its about the slide pane.
Comment 5 Heiko Tietze 2017-10-09 13:07:37 UTC
(In reply to Yousuf Philips (jay) from comment #4)
> This isnt a duplicate and its about the slide pane.

Agreed, the "slides" pane's title should depend on whether in master or normal mode. Sounds like an easyhack to me.
Comment 6 Xisco Faulí 2018-03-04 03:44:14 UTC Comment hidden (obsolete)
Comment 7 Xisco Faulí 2018-04-04 02:30:08 UTC Comment hidden (obsolete)
Comment 8 Xisco Faulí 2018-05-05 02:39:23 UTC Comment hidden (obsolete)
Comment 9 Xisco Faulí 2018-06-05 02:36:38 UTC Comment hidden (obsolete)
Comment 10 Xisco Faulí 2018-07-06 02:44:27 UTC Comment hidden (obsolete)
Comment 11 Xisco Faulí 2018-08-06 02:27:43 UTC Comment hidden (obsolete)
Comment 12 Xisco Faulí 2018-09-06 02:57:24 UTC Comment hidden (obsolete)
Comment 13 Xisco Faulí 2018-10-07 03:03:37 UTC Comment hidden (obsolete)
Comment 14 Xisco Faulí 2018-11-07 03:59:26 UTC Comment hidden (obsolete)
Comment 15 Xisco Faulí 2018-12-08 03:45:35 UTC Comment hidden (obsolete)
Comment 16 Xisco Faulí 2019-01-08 03:41:08 UTC Comment hidden (obsolete)
Comment 17 Heiko Tietze 2019-01-08 08:34:46 UTC Comment hidden (obsolete)
Comment 18 Heiko Tietze 2023-05-10 10:31:23 UTC
Too difficult for me.

"Slides" is defined via STR_LEFT_PANE_IMPRESS_TITLE, the LeftPaneImpressChildWindow receives this title in the c'tor at sd/source/ui/dlg/PaneChildWindows.cxx. Could imagine to do something like ::sd::LeftPaneImpressChildWindow->GetWindow()->set_title(<foo>), which doesn't exist, for SID_SLIDE_MASTER_MODE / SID_CLOSE_MASTER_VIEW. The current mode should be easy accessible via "enum class EditMode".
Comment 19 Commit Notification 2023-10-02 08:22:17 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/25d09bdb9f48313c000cc8ec8df60b1bb8efe2e6

tdf#87638 - Modify slide pane title in Impress/Draw based on edit mode

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.