Bug 88138 - ICU libs should be checked using pkg-config/.pc instead of icu-config
Summary: ICU libs should be checked using pkg-config/.pc instead of icu-config
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Rene Engelhard
URL:
Whiteboard: target:6.0.0
Keywords:
Depends on:
Blocks: ICU
  Show dependency tree / graph
 
Reported: 2015-01-07 07:49 UTC by Rémi Cardona
Modified: 2022-05-15 00:27 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rémi Cardona 2015-01-07 07:49:49 UTC 
Before hitting bug #85214, I found that icu-config was not POSIX-compliant either. While fixing the issue and reporting it upstream[1], one of the ICU devs pointed out that the icu-config script is deprecated and that pkg-config should be used instead[2].

Cheers

[1] http://bugs.icu-project.org/trac/ticket/11460
[2] http://userguide.icu-project.org/howtouseicu#TOC-C-Makefiles
Comment 1 Adolfo Jayme Barrientos 2015-01-07 12:55:09 UTC 
Thanks for the report. Marking it NEW.
Comment 2 David Tardon 2015-01-07 13:30:47 UTC 
We need to get the ICU version, which cannot be done using pkg-config with the existing .pc files (IOW, there is no variable containing version that we could query).
Comment 3 Rémi Cardona 2015-01-07 21:57:59 UTC 
From LO's configure.ac around line 8795:

$ icu-config --noverify --version
53.1

$ icu-config --version
53.1

Using pkg-config, one can call the following:

$ pkg-config --modversion icu-uc
53.1
$ pkg-config --variable=UNICODE_VERSION icu-uc
6.3

Is more needed? That's all I could find in configure.ac.
Comment 4 David Tardon 2015-01-08 11:20:41 UTC 
Eh, right. pkg-config --modversion is sufficient.
Comment 5 Robinson Tryon (qubit) 2015-12-14 06:54:41 UTC Comment hidden (obsolete)
Comment 6 Robinson Tryon (qubit) 2016-02-18 14:51:50 UTC Comment hidden (obsolete)