Bug 88838 - Fullscreen toggle - returns to incorrect window state
Summary: Fullscreen toggle - returns to incorrect window state
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: preBibisect, regression
Depends on:
Blocks: Full-Screen-Mode
  Show dependency tree / graph
 
Reported: 2015-01-28 02:02 UTC by Paul Reilly
Modified: 2024-02-13 11:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Reilly 2015-01-28 02:02:26 UTC 
When a window is in a non-maximized state, going fullscreen and then toggling back 'returns' the window to a maximized state.

Correct behaviour is returning to previous window size and position when not maximized at the time of going into fullscreen.
Comment 1 Buovjaga 2015-01-29 20:30:09 UTC 
Works in 3.3.0, but bugging out already in 3.5.0.

Lowered severity per https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg

Ubuntu 14.10 64-bit Version: 4.5.0.0.alpha0+
Build ID: 784d069cc1d9f1d6e6a4e543a278376ab483d1eb
TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-01-25_23:58:40

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 2 Matthew Francis 2015-01-30 08:05:53 UTC 
I previously tagged this as preBibisect based on the reported versions, but in fact I can't reproduce it at all with Ubuntu 14.04 under lxde. Perhaps this is an interaction with a specific window manager.

Would the original reporter and/or @Beluga please comment which desktop environment / window manager they are using, and whether it is a specific part of Libreoffice (Writer, Calc, Impress ...) they see the issue with, or all of them?


Setting status to NEEDINFO - please set back to NEW when the requested information has been provided

Thanks
Comment 3 Buovjaga 2015-01-30 08:17:57 UTC 
Just vanilla Ubuntu, so Unity. Tested with writer.
Comment 4 Robinson Tryon (qubit) 2015-12-14 05:40:06 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2017-01-03 19:46:35 UTC Comment hidden (obsolete)
Comment 6 Buovjaga 2018-12-26 16:37:20 UTC 
Still repro (under KDE).

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 3bc65fe56d726de2b6efe229daedb634df940ce8
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 26 December 2018
Comment 7 QA Administrators 2020-12-26 03:48:58 UTC Comment hidden (obsolete, spam)
Comment 8 QA Administrators 2023-12-15 03:14:07 UTC Comment hidden (obsolete)
Comment 9 Dominique Michel 2024-02-13 11:46:51 UTC 
(In reply to Matthew Francis from comment #2)
> I previously tagged this as preBibisect based on the reported versions, but
> in fact I can't reproduce it at all with Ubuntu 14.04 under lxde. Perhaps
> this is an interaction with a specific window manager.
> 
> Would the original reporter and/or @Beluga please comment which desktop
> environment / window manager they are using, and whether it is a specific
> part of Libreoffice (Writer, Calc, Impress ...) they see the issue with, or
> all of them?
> 
> 
> Setting status to NEEDINFO - please set back to NEW when the requested
> information has been provided
> 
> Thanks

For me, using fvwm-crystal with fvwm3 and Xorg on gentoo, that have nothing to do with a specified windows manager, but all to do with ICCCM https://tronche.com/gui/x/icccm/ or, more presumably, the extended window manager hints EWMH https://www.freedesktop.org/wiki/Specifications/wm-spec/

With fvwm-crystal, I can maximize any windows in fullscreen with a simple key binding. To do that, fvwm tell X to remove the borders of the windows and to use the whole screen for that window. That work just fine, back and forth, with libreoffice - I use mostly writer.

When a writer windows is into that maximized fullscreen mode, and I tell writer to go in fullscreen, it remove all its borders and menu. That also works just fine. The issue is than when going back from writer's fullscreen mode, libreoffice doesn't care about the precedent windows state, which was Maximized Fullscreen, and return into an annoying state whith a window bigger than the screen (of the size of the screen + the borders and title bar).

At https://en.wikipedia.org/wiki/Extended_Window_Manager_Hints
we can read than "The EWMH defines thirteen window state flags: 
...
Fullscreen: show the window fullscreen,
..."

So for me, to say that, because some desktop handle it correctly, that's an issue with the other wm/desktop is a wrong clue, that because for all wm/desktops, the underlying process is the EWMH compliance of both the wm and the application. And yes, an user can use its wm to change the state of a given window and the application must understand that.

In that case, the fullscreen mode of libreoffice make 2 things: it put the window into maximized fullscreen, which have to do with the EWMH compliance, and it remove the menu and other writer's bars, which have  nothing to do with EWMH. The issue must be "just" the EWMH compliant part of that function.

I also think it is great than the fullscreen function of the wm doesn't interfere with the libreoffice part of its fullscreen function, because that way One can have writer in maximize fullscreen all the time.