Bug 88854 - LO crashes wheh opening drop caps
Summary: LO crashes wheh opening drop caps
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
PreBibisect
Hardware: All All
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.5.0 target:4.3.7 target:4.4.1
Keywords: preBibisect, regression
Depends on:
Blocks: Paragraph-Drop-Caps
  Show dependency treegraph
 
Reported: 2015-01-28 13:14 UTC by Olivier MORIN
Modified: 2017-07-24 17:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Video of crash (6.74 MB, application/zip)
2015-01-28 13:14 UTC, Olivier MORIN
Details
Bug demo in english (760.06 KB, application/zip)
2015-01-29 09:52 UTC, Olivier MORIN
Details
Linux 4.5 master backtrace (11.71 KB, text/plain)
2015-01-30 02:29 UTC, Matthew Francis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier MORIN 2015-01-28 13:14:04 UTC
Created attachment 112858 [details]
Video of crash

LO crashes when opening paragraph properties on Drop craps tab after whole word activation.

See video
Comment 1 Olivier MORIN 2015-01-28 13:16:05 UTC
Same bug in 4.3.5.2...
Comment 2 Joel Madero 2015-01-28 15:26:25 UTC
Please provide clear reproducible steps as well as a simple attachment. While the video shows the crash it doesn't clearly show us what to do (specifically it's not in English). 

Marking as NEEDINFO - once you provide clear enumerated steps and a simple attachment please mark as UNCONFIRMED. Thanks
Comment 3 Olivier MORIN 2015-01-29 09:52:03 UTC
Created attachment 112909 [details]
Bug demo in english
Comment 4 Olivier MORIN 2015-01-29 09:53:35 UTC
Comment on attachment 112909 [details]
Bug demo in english

Ok
Open a new text document
Rigth click, Paragraph, Drop Cpas tab, click on "display drop caps".
!!br0ken!! appears !
Select !!br0ken!!, and add text.
Press Enter to add new paragraph.
Rigth click, Paragraph, Drop Cpas tab, click on "whole word".
Add text.
Press Enter to add new paragraph.
Rigth click, Paragraph, crash !
Comment 5 Olivier MORIN 2015-01-29 12:29:32 UTC
Bug reproduced in XUbuntu 14.04
Comment 6 Joel Madero 2015-01-30 00:19:52 UTC
(In reply to Olivier MORIN from comment #4)
> Comment on attachment 112909 [details]
> Bug demo in english
> 
> Ok
> Open a new text document
> Rigth click, Paragraph, Drop Cpas tab, click on "display drop caps".
> !!br0ken!! appears !

!!br0ken!! does not appear for me.

ubuntu 14.04 x64
LibreOffice 4.4.0.2 rc
Comment 7 Joel Madero 2015-01-30 00:21:59 UTC
I can reproduce the crash though despite not seeing !!br0ken!!

Marking as :

New
Major - crash
High - default

Will see if this is a regression shortly. Thanks for the clear instructions and video.
Comment 8 Joel Madero 2015-01-30 00:48:07 UTC
Regression - works in 3.3
Comment 9 Joel Madero 2015-01-30 01:27:24 UTC
So this has been a problem for years - updating version to reflect that the bug has been around since at least 3.5beta0 ('preBibisect"). Version is oldest known version that shows the problem, not latest tested on. Thanks
Comment 10 Matthew Francis 2015-01-30 02:29:45 UTC
Created attachment 112934 [details]
Linux 4.5 master backtrace

I also don't see the Broken message (which I believe indicates the use-after-free of a string?), but I can reproduce the attached crash.

Exact method of reproduction:
1. Create a blank new Writer document
2. Open the Drop Caps tab in the Paragraph dialog and tick both "Display drop caps" and "Whole word"
3. Close the dialog with "OK"
4. Reopen the dialog
Comment 11 Olivier MORIN 2015-01-30 07:20:48 UTC
Bonjour !

!!!Broken!!! appears in 4.2.8 but not in 4.3.5.

But it crashes in both versions.
Comment 12 Olivier MORIN 2015-02-04 10:58:15 UTC
Same crash with te latest 4.4 version...
Comment 13 Commit Notification 2015-02-04 11:35:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=727c3e088698dfd21cf4beaa5455d4c4d5b495fb

tdf#88854 crash on opening drop caps

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2015-02-06 14:30:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ccf8e201bd825df0227af8ab9161c11e9db05bc7&h=libreoffice-4-3

tdf#88854 crash on opening drop caps

It will be available in 4.3.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2015-02-06 14:30:24 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=76682f53a4dbcd12b9d0c02a3bc6e264c32651af&h=libreoffice-4-4

tdf#88854 crash on opening drop caps

It will be available in 4.4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 16 Robinson Tryon (qubit) 2015-12-17 11:00:46 UTC Comment hidden (obsolete)