To reproduce: 1. Open a new Draw document. 2. Draw a filled rectangle using the rectangle tool. 3. Select the rectangle. 4. Insert→Hyperlink and add a link (I used a web link) 5. Select the rectangle. 6. Open the Edit menu, observe that "Hyperlink…" is greyed out. 7. Click the top toolbar's Hyperlink tool, observe that it lets you edit the hyperlink.
Reproducible with LO 4.4.0.3, Win 8.1.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.5 or 5.1.0) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2016-02-21
I can reproduce in 5.0.5 on Ubuntu 14.04. The "Hyperlink" toolbar button does not appear in the toolbar (any more?) so I right-clicked on the toolbar to get it.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.2.5 or 5.3.0 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170306
I was able to reproduce this bug in LibreOffice 5.3.0.3 on GNU/Linux. Some details appear to have changed, so I note the revised procedure to reproduce below: 1. Open a new Draw document. 2. Draw a filled rectangle using the rectangle tool. 3. Select the rectangle. 4. Insert→Link and add a link (I used a web link) 5. Select the rectangle. 6. Open the Edit menu, observe that "Link…" is greyed out. 7. Right click the toolbar's handle, Link, observe that it lets you edit the hyperlink. (You can also edit the link with Insert→Link, which is rather unintuitive.) As last year, there is no "Link" or "Hyperlink" button on the toolbar any more, but I can find one by right-clicking on the toolbar handle. The online documentation appears to be out of date: https://help.libreoffice.org/5.3/Draw/Insert still mentions "Insert→Hyperlink", while the actual Insert menu item is "Link".
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
I was able to reproduce in 6.0.6 on Ubuntu 18.04. I followed the instructions in Comment 5, except that "Link" is now once again called "Hyperlink".
Dear Reuben Thomas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Confirmed in 6.3.0.4 running in Ubuntu 18.04 (installed from snap), following the instructions as in Comment 7.
Dear Reuben Thomas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Reproduced in 6.4.7.2 in Ubuntu 20.04, with following updated procedure (same as for 6.3): 1. Open a new Draw document. 2. Draw a filled rectangle using the rectangle tool. 3. Select the rectangle. 4. Insert→Hyperlink and add a link (I used a web link) 5. Select the rectangle. 6. Open the Edit menu, observe that "Hyperlink" is greyed out. 7. Right click the toolbar's handle, Hyperlink, observe that it lets you edit the hyperlink. (You can also edit the link with Insert→Hyperlink, which is rather unintuitive.)
Same in OOo 3.3, so inherited. Still present in a recent 24.2 master build. Hossein, maybe an easyHack ?
(In reply to Stéphane Guillou (stragu) from comment #12) > Hossein, maybe an easyHack ? Yes. The code pointers for this EasyHack is as follows: Start from the menu, which is "Edit > Hyperlink". In fact, it is "~Hyperlink", as it has underline below H: $ git grep -w ~Hyperlink The search leads to this file: officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu Opening this xml file, one may find the command uno:EditHyperlink which is invoked by selection that menu option. Then, you can search for this command inside the code. The opened dialog for editing the hyperlink as the text "Hyperlink Type" inside it. Searching for this text leads to the exact ui: $ git grep "Hyperlink Type" cui/uiconfig/ui/hyperlinkinternetpage.ui Searching for EditHyperlink (instead of uno:EditHyperlink) in C++ files, leads to a few files: $ git grep -l EditHyperlink *.cxx sc/source/ui/view/editsh.cxx sc/source/ui/view/gridwin.cxx sc/source/ui/view/tabvwshe.cxx sd/source/ui/view/drviews4.cxx sd/source/ui/view/drviews7.cxx Only the last 2 are related to Draw (sd). In the last file, the below method determines when the EditHyperlink menu item should be disabled: sd/source/ui/view/drviews7.cxx:284 bool DrawViewShell::ShouldDisableEditHyperlink() const { ... } The EasyHacker should change this method, so that it can also handle a shape with a hyperlink attached to it. The patch should modify the only "else" block and handle such a situation.
nicholaskhoi2, are you still hoping to work on this? If not, please un-assign yourself.
Since there has been no activity on this since 5 months, I'm assigning it under my name
Created attachment 197424 [details] Several object types that have a hyperlink The document has several types of shapes, each one with hyperlink. To select an object do not click on the object but drag a selection rectangle that surrounds the object. After the object is selected, you can call the hyperlink dialog with Ctrl+K.
The task is not clear. Is it intended, that 'Edit->Hyperlink' is always enabled, when the toolbar command 'Hyperlink' is enabled? Or is it intended, that 'Edit->Hyperlink' is only enabled if the object has already a hyperlink? Or is it intended, that 'Edit->Hyperlink' is enabled if the object is actually able to have a hyperlink? The toolbar command 'Hyperlink' is enabled, even if the selected object is not able to have a hyperlink, e.g. a 3D-scene or a group are not able to have a hyperlink.
I feel like it's the third one. > Or is it intended, that 'Edit->Hyperlink' is enabled if the object is actually able to have a hyperlink? Reason: User can press Ctrl+K after selecting objects that is actually able to have a hyperlink. Therefore, in the menu bar they should be allowed to click on it to open the hyperlink dialog upon selecting object that can have a hyperlink. I am, of course, a beginner here so I will wait for your opinions on this before putting in the coding effort.
I'm not sure about it. The place where ShouldDisableEditHyperlink() is called has the comment 1487 // Menuoption: Edit->Hyperlink 1488 // Disable, if there is no hyperlink And the shortcut shown in the menu is not Ctrl+K but Alt+K and latter means uno:EditHyperlink. That would fit to option 2. If you go with option 2, then you get the needed info by the getHyperlink() method from the selected object. That is easy to do. The option 3 has the problem, that the ODF file format standard allows objects, for that a hyperlink is not implemented in LibreOffice or implemented so, that the hyperlink is written to file but does not work in LibreOffice. In file format it is the <draw:a> element: https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1415880_253892949 You would get the info which kind of object is selected by the GetObjIdentifier() method of the selected object. That method returns a value of the enumeration enum class SdrObjKind. You find an idea about its use in https://opengrok.libreoffice.org/xref/core/sw/source/uibase/shells/drwbassh.cxx Option 1 would mean to enable it always, at least I have not seen an example, where the 'Insert Hyperlink' command from the toolbar is not enabled. It is even enabled for 3D-scene and group, and for them a hyperlink does not work in LibreOffice. I will add UX. They might decide, whether option 2 would be fine.
(In reply to Regina Henschel from comment #17) > Is it intended, that 'Edit->Hyperlink' is always enabled, when the toolbar > command 'Hyperlink' is enabled? We have two commands, .uno:HyperlinkDialog for "Insert Hyperlink (Ctrl+K)" and .uno:EditHyperlink for "Edit Hyperlink". The question whether this needs two commands is frequently discussed; and a consequence could be to edit a non-existent hyperlink and have Edit > Hyperlink always enabled. But for now we split the two, and edit should be possible only if the object has a link assigned. In case of multi-selection we should either always block insert/edit or only if the hyperlinks are different.
(In reply to Heiko Tietze from comment #20) > In case of multi-selection we should either always block insert/edit or only > if the hyperlinks are different. Currently the method ShouldDisableEditHyperlink is designed to disable editHyperlink if more than one object is selected. https://git.libreoffice.org/core/+/refs/heads/master/sd/source/ui/view/drviews7.cxx#294
(In reply to Regina Henschel from comment #21) > (In reply to Heiko Tietze from comment #20) > > > In case of multi-selection we should either always block insert/edit or only > > if the hyperlinks are different. > > Currently the method ShouldDisableEditHyperlink is designed to disable > editHyperlink if more than one object is selected. Should I work on it on this ticket or would it be a separate task?
(In reply to Aditya Sahu from comment #22) > (In reply to Regina Henschel from comment #21) > > (In reply to Heiko Tietze from comment #20) > > > > > In case of multi-selection we should either always block insert/edit or only > > > if the hyperlinks are different. > > > > Currently the method ShouldDisableEditHyperlink is designed to disable > > editHyperlink if more than one object is selected. > > Should I work on it on this ticket or would it be a separate task? As you like, you could also keep the status quo.
I've given it a crack, here: https://gerrit.libreoffice.org/c/core/+/176095 Let me know if I'm headed in the right direction