Spreadsheets – especially with more columns – spend a lot of time to use the ScHorizontalAttrIterator.
Created attachment 113469 [details] kcachegrind screenshot - base profile
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 (I’m assuming the role of the Bugzilla notifier :P)
Created attachment 113472 [details] kcachegrind profile - optimized XLS(X) export Profile of exporting an XLSX test file with ~15 data columns. Changes in the estimated cycle numbers: 21.2b -> 19.8b (6.5% speed up by removing ~1.4b cycles of ScHorizontalAttrIterator::GetNext().)
(In reply to Adolfo Jayme from comment #2) > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 > Also the first part: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4de4f1fd1125bc8cf6059cf143bb76d1ab212434 > (I’m assuming the role of the Bugzilla notifier :P) (Hi Adolfo, thanks for that! :)
László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8e9540d3d4909c6dd45c9efa294f565d9735a0d9 tdf#89436 ScHorizontalAttrIterator - fix indices It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 tdf#89436 handle skipping empty rows It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4de4f1fd1125bc8cf6059cf143bb76d1ab212434 tdf#89436 fix ScHorizontalAttrIterator performance It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d619d23a1f641fc910723cc32c4d8c8d9a8f3681 tdf#89436 add unit test for ScHorizontalAttrIterator It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bc49565331c931f0efb3590db76267a5c911053&h=libreoffice-4-4 tdf#89436 fix ScHorizontalAttrIterator performance It will be available in 4.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f71a35ac72d604519a3c43a1c1cc44b3e04b420 use a slightly more complicated pattern distribution to check, tdf#89436 It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d586d61d6a2b314783203d92fb0c1b62ea0e95e tdf#89436 ScHorizontalAttrIterator cleanup It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.