Created attachment 113539 [details]
Presentation illustrating the issue with blank first slide in 4.5
Steps to Reproduce:
1. File->New-Presentation in a recent build of LO 4.5
2. Add some text in the title and/or body
Display text from step 2
Blank, White screen
Subsequent slides are displayed correctly in slide show mode.
Tested on Win 7
Build ID: 1d9bfd6e289a1cc8872038b54b060a282d02ea08
I have exactly the same problem except I am running LibreOffice 220.127.116.11, Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7 on Windows 7.
After some experiments, this is what I came up with. I uninstalled 18.104.22.168 and installed 22.214.171.124. The problem did not exist. I could view Impress presentations, including the first slide with no problems. Therefore, the bug seems to have been introduced in version 126.96.36.199.
I then re-installed version 188.8.131.52 and the bug reappeared. I messed around with some of the settings and discovered that if I went to Tools->Options->LibreOffice->View and unchecked the "Use hardware acceleration" box then the bug disappears. All slides can be viewed as normal, including the first slide.
Thus, it seems to be a problem, introduced in 184.108.40.206 with the hardware acceleration feature. I hope that helps solve the bug and gives people a viable workaround.
I was reproduced in the following environments.
LibO: 4.4.0 , 4.4.1 RC1(TDF build)
I do not reproduce in Debian.
Reproducible with LO 220.127.116.11, Win 8.1. After I deactivated the Hardware Acceleration it also worked for me again.
I notice that this bug will not reproduced by reverting the following commit.
"vcl: remove SalVirtualDevice::GetWidth"
Tested on Windows 8.1
Probably, we still need GetSize() method calling(please see the following).
---------- ---------- ----------
diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index d783cd9..063bef1 100644 (file)
@@ -164,12 +164,6 @@ void VirtualDevice::ImplInitVirDev( const OutputDevice* pOutDev,
mbScreenComp = true;
mnAlphaDepth = -1;
- // #i59315# init vdev size from system object, when passed a
- // SystemGraphicsData. Otherwise, output size will always
- // incorrectly stay at (1,1)
- if( pData && mpVirDev )
if( mnBitCount < 8 )
SetAntialiasing( ANTIALIASING_DISABLE_TEXT );
---------- ---------- ----------
Thank you for tracking down the cause of this regression! How were you able to narrow down the regression window without bibisect for Windows?
Adding Michael Meeks and Markus Mohrhard to make them aware of this issue.
Same problem here, since version 4.3. I am now at 18.104.22.168, the bug is still there. Windows 8.1
(In reply to Massimo from comment #8)
> Same problem here, since version 4.3. I am now at 22.214.171.124, the bug is still
> there. Windows 8.1
Edit: I confirm that unchecking "Use hardware acceleration" in Tools-> Options-> LibreOffice-> View fixes the problem.
(In reply to Joey Reid from comment #7)
> Thank you for tracking down the cause of this regression! How were you able
> to narrow down the regression window without bibisect for Windows?
I used "git bisect", and perseverance.
Because there is no other choice for me :-<
Really great work; thanks ! =) Unfortunately, that patch is rather useful ;-) it un-screws-up some particularly tortured life-cycle around VirtualDevices that is inexecusably bad =) will need to think this through.
Ultimately, similar sizing logic should happen in the factory / constructor I think:
mpVirDev = pSVData->mpDefInst->CreateVirtualDevice( pGraphics, nDX, nDY, nBitCount, pData );
To avoid this unpleasant habit of re-sizing virtual-devices later in this unusual way.
I have a fix vs. master in:
I can't even build-test OS/X which is a bit nerve-racking; hopefully Norbert's CI magic will do the job =) as/when/if that completes - I'll push to master and back-port to 4.4.
I get my first slide on windows, no problems with this - and yet we retain the (relatively saner) semantics - though (to be sure) we're shoving basically 2x use-cases through this API: that with a valid pData and that without - which is a bit lame & prolly error prone.
Pushed to master, and awaiting review for -4-4 as:
Second opinions appreciated; Markus ? =)
(In reply to Michael Meeks from comment #12)
> I have a fix vs. master in:
Thank you very much for your ultra fast fix!
I confirmed that my first slide was displayed correctly on windows 8.1,
LibreOffice 126.96.36.199.alpha0+(Build ID: 45306431759ec5e1bda8caa1ed428fc77035b0f2).
Removing comma from Whiteboard (please use a space to delimit values in this field)