Bug 89501 - Finalized configuration items set in Windows Registry can be overridden by user and can cause crashes
Summary: Finalized configuration items set in Windows Registry can be overridden by us...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 104005
Blocks: Desktop-Integration
  Show dependency tree / graph
 
Reported: 2015-02-20 14:44 UTC by hastegan
Modified: 2023-10-11 15:44 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hastegan 2015-02-20 14:44:16 UTC 
Since LibreOffice 4.2 configuration items can be set with the Windows Registry, it is possible to set the value and set if it's a finalized item.

== Example ==

Add a reg entry in the Windows Registry (.reg file) :

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\LibreOffice\org.openoffice.Office.Common\Undo\Steps]
"Value"="42"
"Final"=dword:00000001

This file set the value 42 for max undo steps and also finalize the property.
A reboot is needed to apply the registry modification.

== Problem ==
In the user interface the field is not locked, it's possible to edit it. When the modification is applied LibreOffice makes an obvious fatal error: "configmgr modification of finalized item".

There is the same lock visualization problem with some checkboxes like in the Tools -> Options -> LibreOffice -> General -> Help menu with "Tips" and "Extended tips" checkboxes. But unlike the precedent case, their modification does not affect LibreOffice stability.

Of course I made some research to see if this bug is already known, it was was fixed in previous versions, but the problem still subsist.

Previous identical bug (with registrymodifications.xcu file) : https://bugs.documentfoundation.org/show_bug.cgi?id=69027
Comment 1 Cor Nouws 2015-02-20 16:22:48 UTC 
looks much like bug 89417 ..
Comment 2 hastegan 2015-02-21 01:30:45 UTC 
(In reply to Cor Nouws from comment #1)
> looks much like bug 89417 ..

Yes this is exactly the same kind of bug, and I read it before posting here. Fixes on bug 89417 only concern one checkbox : http://cgit.freedesktop.org/libreoffice/core/commit/?id=a96acacb91197a04e8fd9114d8c4bcda24372f54
Comment 3 Andras Timar 2015-10-03 18:54:36 UTC 
I confirm this, and I found yet another example:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\LibreOffice\org.openoffice.Office.Common\Save\Document\AutoSave]
"Value"="true"
"Final"=dword:00000001

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\LibreOffice\org.openoffice.Office.Recovery\AutoSave\TimeIntervall]
"Value"="5"
"Final"=dword:00000001

Tools - Options - Load/Save - General, modify TimeIntervall value, press OK. -> Fatal error. 

However this is not related to Windows registry, presumably one will get the same error when a setting is finalized through an extension or by other means. 

I don't see other solution, than all of these settings have to be found, and fixed similarly to bug 89417.
Comment 4 Cor Nouws 2015-10-04 20:42:59 UTC 
(In reply to Andras Timar from comment #3)

> However this is not related to Windows registry, presumably one will get the
> same error when a setting is finalized through an extension or by other
> means. 

Indeed.

> I don't see other solution, than all of these settings have to be found, and
> fixed similarly to bug 89417.

Yep..
Comment 5 QA Administrators 2016-11-08 10:27:11 UTC Comment hidden (obsolete)
Comment 6 Andras Timar 2016-11-26 16:08:54 UTC 
https://gerrit.libreoffice.org/#/c/31236/ solves the issues mentioned in Comment 3.
Comment 7 QA Administrators 2018-07-28 02:43:20 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2020-09-22 03:59:16 UTC Comment hidden (obsolete)
Comment 9 Samuel Mehrbrodt (allotropia) 2023-05-15 13:20:22 UTC 
Issues mentioned in this bug report were fixed.

If there are remaining issues, please file a new bug and mention which settings exactly need fixing.