Bug 89548 - SIDEBAR: Vertical alignment buttons no longer appear
Summary: SIDEBAR: Vertical alignment buttons no longer appear
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) Master
Hardware: Other All
: highest normal
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Sidebar-Properties mab5.0
  Show dependency treegraph
Reported: 2015-02-22 01:44 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-10-24 15:45 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-02-22 01:44:32 UTC
1) Open Writer
2) Insert a table
3) The three vertical alignment buttons dont appear in the sidebar to the right of the four horizontal alignment.

Build ID: 4cf69df2f543b023f4ec3d4279c5ac11a2a819d9
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-02-21_03:46:34

This doesnt effect 4.4 daily.
Comment 1 V Stuart Foote 2015-02-22 02:20:30 UTC

They are contextual, and appear when the cursor is on a paragraph positioned inside a table. They follow activation of the Table toolbar.

Comment 2 Yousuf Philips (jay) (retired) 2015-02-22 07:09:59 UTC

Yes i'm aware they are contextual and they are not appearing in master after a table is inserted.

I mistakenly set this to ux-advise when it wasnt supposed to be as this is a bug. :D
Comment 3 V Stuart Foote 2015-02-22 16:38:12 UTC
OK, I see it.

Hmm, no recent changes in the Paragraph properties code...


lines 198-257

But, with a table selected, if you toggle away from the Properties content panel to Styles and Formatting and then back to Properties--the buttons do appear on the content panel.

So, something in detecting the state of table object selected not refreshing the Paragraph content panel on the Properties tab?
Comment 4 Robinson Tryon (qubit) 2015-03-05 16:52:55 UTC
Whiteboard -> bibisectRequest
Comment 5 Terrence Enger 2015-06-05 17:04:00 UTC
Working in the 44 bibisect repository, I see: from `git bisect good` ...

    4a3091e95fa263d3e2dd81e56e83996f0bb12287 is the first bad commit
    commit 4a3091e95fa263d3e2dd81e56e83996f0bb12287
    Author: Robinson Tryon <qubit@runcibility.com>
    Date:   Wed Dec 3 08:32:14 2014 +0100

        commit 2b5b04e1e62914bf0902dfd7943cdc44499c47a6
        Author:     Tor Lillqvist <tml@collabora.com>
        AuthorDate: Thu Nov 20 17:40:01 2014 +0200
        Commit:     Tor Lillqvist <tml@collabora.com>
        CommitDate: Thu Nov 20 17:40:01 2014 +0200
            Include <osl/diagnose.h>
            Change-Id: I67cb459b1e9ab5638a5b405430d3e0a42fc6bfc3

    :100644 100644 0c405e46bb1038323fd9014e64f2b557f3d0f269 618b19dc2268ef1667047484cfbd6d48cf7266c4 M	autogen.log
    :100644 100644 d05a63faa8f30ed76a6f48bd99aa6e58fbbd8e4b a6bdfedc5640d0b171f443e51cc3ca5fb3e1e43d M	ccache.log
    :100644 100644 5572253c813918878b72b23a5cb4a4d22b64defa 979b59c3d24245c7a52bab454e94c00aea8adfd2 M	commitmsg
    :100644 100644 262e0ed60d167753447b4663be104aa67807abb2 d6029c519e6817c64f2ac1a1a3f0781f25d55d00 M	make.log
    :040000 040000 c8d527c39d05194cc2a02dc191a53a190d2e791f 2fd168d3655ec95fb92035eb560b7380b7848058 M	opt

and from `git bisect log`:

    # bad: [4a3091e95fa263d3e2dd81e56e83996f0bb12287] source-hash-2b5b04e1e62914bf0902dfd7943cdc44499c47a6
    # good: [812c4a492375ac47b3557fbb32f5637fc89d60d9] source-hash-dea4a3b9d7182700abeb4dc756a24a9e8dea8474
    git bisect start 'latest' 'oldest'
    # good: [5d0dfb8e62ae61a240f8313c594d4560e7c8e048] source-hash-0c6cd530de13f80795881f61064f1bf1dcc4ea81
    git bisect good 5d0dfb8e62ae61a240f8313c594d4560e7c8e048
    # good: [7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5] source-hash-f93ce4f7eb90093d0ea3115d0a1c614612676dbd
    git bisect good 7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5
    # good: [a42da134cd542144fca7ba14cce86c2b409fc18a] source-hash-beadebc0f7eb5582fcb8dcb082d19afdf2751876
    git bisect good a42da134cd542144fca7ba14cce86c2b409fc18a
    # good: [038f586bf711ad77856916be954b6c02a5717eb1] source-hash-2ec4c8b07427af868e32e14aaefd20649c1135d6
    git bisect good 038f586bf711ad77856916be954b6c02a5717eb1
    # good: [1c1bb47aa932531a0486c1af5460f7f7f3de510a] source-hash-16068663e2aa984388be5f774b8f1917c12bf6f3
    git bisect good 1c1bb47aa932531a0486c1af5460f7f7f3de510a
    # good: [5e3b82d0ec3ad9bd56157084cd18d4d0427d388e] source-hash-30123b9559e2fb74c9db7d530c538a1c6dc7e32c
    git bisect good 5e3b82d0ec3ad9bd56157084cd18d4d0427d388e
    # good: [d555357ed375bf1d6805e3773dc9b3527278df0f] source-hash-9e1afe84ec73b1eb183ca42204a518d6deede292
    git bisect good d555357ed375bf1d6805e3773dc9b3527278df0f
    # good: [49e272aee271eddf26d5abb1dd9f4aa09af3571d] source-hash-1b9aaba0bfe8bc0872e7ea9f9aef5961e4b52f7c
    git bisect good 49e272aee271eddf26d5abb1dd9f4aa09af3571d
    # good: [7e74502be7353a4d9581e4e72de4d990bb92c952] source-hash-437cf27b6db107b2b74836ac2d897a10ebc67c0b
    git bisect good 7e74502be7353a4d9581e4e72de4d990bb92c952
    # first bad commit: [4a3091e95fa263d3e2dd81e56e83996f0bb12287] source-hash-2b5b04e1e62914bf0902dfd7943cdc44499c47a6c
Comment 6 Terrence Enger 2015-06-06 22:14:26 UTC
I think in comment 5 I misjudged the behavior of "44" bibisect version latest.  Rather, in the "50max" bibisect I see from `git bisect good ...

    commit bbda904deaab50a97e0ed423da747556123a43ea
    Author: Matthew Francis <mjay.francis@gmail.com>
    Date:   Wed May 27 17:33:11 2015 +0800

        commit a73475cecdac393b40c34770be65be40bf05e011
        Author:     Caolán McNamara <caolanm@redhat.com>
        AuthorDate: Tue Dec 30 15:54:34 2014 +0000
        Commit:     Caolán McNamara <caolanm@redhat.com>
        CommitDate: Tue Dec 30 15:56:28 2014 +0000
            DockingWindow will need a timer after all
            to update layout after initial show when
            contents change
            Change-Id: I8edbe84fa366cdb04dbfe5e479dc01cbf04dbf4c

    :040000 040000 6d05373fd00ecd17b4dc23f3e289ffe9b59bc751 171db3ef946f640c0d7fe311b74c136748b21139 M	opt

and from `git bisect log` ...

    # bad: [dda106fd616b7c0b8dc2370f6f1184501b01a49e] source-hash-0db96caf0fcce09b87621c11b584a6d81cc7df86
    # good: [5b9dd620df316345477f0b6e6c9ed8ada7b6c091] source-hash-2851ce5afd0f37764cbbc2c2a9a63c7adc844311
    git bisect start 'latest' 'oldest'
    # bad: [0c30a2c797b249d0cd804cb71554946e2276b557] source-hash-45aaec8206182c16025cbcb20651ddbdf558b95d
    git bisect bad 0c30a2c797b249d0cd804cb71554946e2276b557
    # bad: [770ff0d1a74d2450c2decb349b62c5087e12c46b] source-hash-549b7fad48bb9ddcba7dfa92daea6ce917853a03
    git bisect bad 770ff0d1a74d2450c2decb349b62c5087e12c46b
    # good: [227af65db5e34efcf8dcb0b53333efecd30f37f8] source-hash-193c7ba9be48f00b46f9e789f233db577e7b3303
    git bisect good 227af65db5e34efcf8dcb0b53333efecd30f37f8
    # good: [78b395d05689a5207f2ec4cc29ec296d64076a96] source-hash-a2e4be6ded508030a6c2a33919cbe8cb504382e0
    git bisect good 78b395d05689a5207f2ec4cc29ec296d64076a96
    # good: [8dd6442885c969ae43ae5ff9ddfc53c9f04a9c27] source-hash-d07f0997c54e9cef31d996ebeb2aabfb4b4e0265
    git bisect good 8dd6442885c969ae43ae5ff9ddfc53c9f04a9c27
    # bad: [56e2ff1d44b7bcd4fff6ce86c93fd9b666808d0b] source-hash-d7794d2584cd5d476b011b5344c77ad59c179c58
    git bisect bad 56e2ff1d44b7bcd4fff6ce86c93fd9b666808d0b
    # good: [00b5c570d73539704807312f0ad6a891c0dc0a71] source-hash-452623cf22c972f4f3865c2e7db961a73021d169
    git bisect good 00b5c570d73539704807312f0ad6a891c0dc0a71
    # bad: [ea6e46827e6c017378cb9509444f8fac91e6669c] source-hash-190196b98fc630d8aa3889e93797cb6268008447
    git bisect bad ea6e46827e6c017378cb9509444f8fac91e6669c
    # bad: [c71f41981a3da9a7ba1a8ec2fa7e8136122e0853] source-hash-c805a996c97097d2a47039355fffba678a84e1b0
    git bisect bad c71f41981a3da9a7ba1a8ec2fa7e8136122e0853
    # bad: [bbda904deaab50a97e0ed423da747556123a43ea] source-hash-a73475cecdac393b40c34770be65be40bf05e011
    git bisect bad bbda904deaab50a97e0ed423da747556123a43ea
    # good: [0365ccb725532981d55c42e0a027f3e629198fab] source-hash-1a3accb148bda7ebe889cbd6177502bd730b0bb8
    git bisect good 0365ccb725532981d55c42e0a027f3e629198fab
    # good: [3912fe61fc36a82f6445d5c2715d672e336b2373] source-hash-b5a375236bd5ccdb0f1397ef734b2d3fbe86ad37
    git bisect good 3912fe61fc36a82f6445d5c2715d672e336b2373
    # good: [6682acdac0cbb3342201c396564f5917a12a4108] source-hash-11d0c28601dc89c48e67a7b39ba82dd52e660334
    git bisect good 6682acdac0cbb3342201c396564f5917a12a4108
    # first bad commit: [bbda904deaab50a97e0ed423da747556123a43ea] source-hash-a73475cecdac393b40c34770be65be40bf05e011
Comment 7 Maxim Monastirsky 2015-07-07 15:57:18 UTC
@Jay: Is it still an issue? I'm no longer able to reproduce it with current master, nor with
Comment 8 Terrence Enger 2015-07-07 16:53:51 UTC
The problem seems to be gone in dbgutil bibisect repository version
2015-07-07, although it was still present in dbgutil bibisect
repository version 2015-05-20.  So, I am setting bug status
Comment 9 Yousuf Philips (jay) (retired) 2015-07-31 17:13:35 UTC
(In reply to Maxim Monastirsky from comment #7)
> @Jay: Is it still an issue? I'm no longer able to reproduce it with current
> master, nor with

Sorry for the delay. Yes it has been working for a while now. :D
Comment 10 Robinson Tryon (qubit) 2015-12-15 11:03:43 UTC Comment hidden (obsolete)