Bug 89550 - If OpenGL enabled for all rendering, drag image from gallery does not work
Summary: If OpenGL enabled for all rendering, drag image from gallery does not work
Status: RESOLVED DUPLICATE of bug 93867
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: VCL-OpenGL
  Show dependency tree / graph
 
Reported: 2015-02-22 07:57 UTC by Jean-Baptiste Faure
Modified: 2015-09-03 12:51 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2015-02-22 07:57:55 UTC 
Steps to reproduce:
1/ enable OpenGL for all rendering: menu Tools > LibreOffice > View
2/ open a new text document
3/ open the gallery in the sidebar and choose a theme
4/ select some picture in the gallery preview and drag it to the text area of the document.

Current behavior: nothing happens, the cursor keeps it cross arrow shape.
In the console, I see many warning messages like this:
warn:vcl.opengl:24226:1:vcl/opengl/gdiimpl.cxx:1558: check where this call is coming from! NOT IMPLEMENTED YET!
These messages do not appear if I do the same without OpenGL enabled for all rendering.

Tested with master built at home under Ubuntu 14.10 x86-64. Of course same problem with LO 4.4.2.0.0+

Version: 4.5.0.0.alpha0+
Build ID: 52fa2e97dfef1a5f27aaee6af7ed80800641b86c
Ubuntu_14.10_x86-64
Locale: fr_FR

Best regards. JBF
Comment 1 A (Andy) 2015-02-22 10:27:18 UTC 
For me not reproducible with LO 4.4.0.3, Win 8.1.
Comment 2 raal 2015-02-28 18:46:48 UTC 
I can not confirm with Version: 4.5.0.0.alpha0+
Build ID: a2fa9e2468aa5c4fd4b610c5d0ebc8959e87a072
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-02-23_02:34:05
Comment 3 Michael Meeks 2015-09-02 22:25:18 UTC 
I believe we've fixed this in the latest master & 5.0.2 work - can you re-test ? I do get some staircase image corruption occasionally - but this is bug#93666
Comment 4 Miklos Vajna 2015-09-03 12:51:49 UTC 
git bisect says the first good commit is:

commit 16b0e217c1f67948374ff050496e5d4ffb8ceb90
Author: Michael Meeks <michael.meeks@collabora.com>
Date:   Wed Sep 2 22:14:10 2015 +0100

    tdf#93867 - clear current GL context before thread switch.
    
    Fixes regression from otherwise a nice cleanup in:
        d20092259c7ea63885a539f911788715f8147ee9
    
    Also get polarity of debug logging only with a context right.
    
    Change-Id: Id322471f01e5656e758aefc57b0d4d5ad073ec54

:040000 040000 5670588c6f5f77982f264ef222d53a7efe2a6332 56d6a66e633db7d52c219edc6ddfdc6998c3c71b M      include
:040000 040000 586ddd162fff640243b8fb76c06bd3403c43f3c2 c0b621cf39ae0bba9a315d3f22664d587c20d14f M      vcl

So marking as a duplicate.

*** This bug has been marked as a duplicate of bug 93867 ***