Bug 89788 - FORMATTING Line spacing Proportional < 100% looks different in 4.3.4 than before
Summary: FORMATTING Line spacing Proportional < 100% looks different in 4.3.4 than be...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.4.1 release
Hardware: Other All
: highest normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2015-03-02 21:45 UTC by Cor Nouws
Modified: 2015-12-15 11:03 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
test file table paragraphs line spacing 95% (29.04 KB, application/vnd.oasis.opendocument.text)
2015-03-02 21:46 UTC, Cor Nouws
Details
Bug 89788 Git Bisect Log (1.49 KB, text/plain)
2015-03-07 06:26 UTC, Gabriel Diosan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2015-03-02 21:45:04 UTC
I'll attach a document
One table
Multiple cells
Paragraph style line spacing 95%

All fits on one page in 4.2.x and 4.4.0 alpah0
In 4.4.0 aplha1 and newer, part the table is on the next page
Comment 1 Cor Nouws 2015-03-02 21:46:27 UTC
Created attachment 113840 [details]
test file table paragraphs line spacing 95%
Comment 2 Cor Nouws 2015-03-03 09:21:54 UTC
double checked with clean user profiles.
  OK in 4.3.3.2 / not OK in 4.3.4.1
  > regression
Comment 3 Cor Nouws 2015-03-05 08:09:53 UTC
let's just set to new
Comment 4 V Stuart Foote 2015-03-05 16:24:06 UTC
@Cor,

Confirming. First incorrect appearance is with 4.3.4

@Kendy, would a piece to your broader line spacing UI work inserted in 4.3.4 maybe be the issue?

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-4&id=5929a87b8137bf6326adfd4ddfd8075e585ae15c
Comment 5 V Stuart Foote 2015-03-05 16:30:36 UTC
Hmm, or guess maybe it could be related to Michael S. work for bug 79602

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-4&id=9605763e3dc8c85137787c77c31e8639553a35ed
Comment 6 Jan Holesovsky 2015-03-05 16:32:42 UTC
Wrt. comment 4 - I read this is an import problem, very unlikely to be related to the UI change...  If you can bibisect this, that would be most appreciated! - thanks in advance :-)
Comment 7 Robinson Tryon (qubit) 2015-03-05 20:04:40 UTC
Setting priority to highest as this is a 4.3 MAB. This is part of an effort to
make the importance of MAB reflected in priority too.
Comment 8 Gabriel Diosan 2015-03-07 06:26:40 UTC
Created attachment 113941 [details]
Bug 89788 Git Bisect Log

Hi

I had a go at bisecting this bug. I have attached a copy of the log. I'm still pretty new to git bisect so hopefully I have done things correctly. Please let me know if I messed up the bisect in some way.

Gabriel
Comment 9 Michael Stahl (allotropia) 2015-03-13 22:07:21 UTC
the problem was that before 4.3.4 the 95 % was actually rendered as 0.95 ^ 2 = 0.9025 = 90.25 %, and that was fixed by:

commit 4e223fab04279c3583689e69fa1342966e81de36
Author:     Michael Stahl <mstahl@redhat.com>
AuthorDate: Wed Oct 29 23:50:21 2014 +0100

    fdo#79602: sw: fix text formatting of proportional line space < 100%
    
    SwTxtFormatter::CalcRealHeight(): Apply the special treatment of < 100%
    line space shrinking the Height() of the line only to the first line
    in a paragraph; the subsequent ones are shrunk again (to the square of
    the desired proportion) 30 lines later.
    
    Also set the Ascent of the line, as the wrong base-line causes the lower
    part of the line to be clipped.


so if it looks different it's not a bug but a feature :)
Comment 10 Cor Nouws 2015-03-18 08:53:33 UTC
(In reply to Michael Stahl from comment #9)
> the problem was that before 4.3.4 the 95 % was actually rendered as 0.95 ^ 2
> = 0.9025 = 90.25 %, and that was fixed by:
> ...
> so if it looks different it's not a bug but a feature :)

Thanks a lot for explaining.
So this is in the category 'incompatible bug-fixes/improvements' ..

>     SwTxtFormatter::CalcRealHeight(): Apply the special treatment of < 100%
>     line space shrinking the Height() of the line only to the first line
>     in a paragraph; the subsequent ones are shrunk again (to the square of
>     the desired proportion) 30 lines later.

If I understand the commit message well, the spacing gradually shrunk from value set to it's square 30 lines later..?
If so, that would make an advise: was the spacing set to eg. 0.9 now make it 0.81 invalid too..
Comment 11 Robinson Tryon (qubit) 2015-12-15 11:03:25 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]