Bug 89845 - EDITING: Undo of deletion of document text from beginning of ranged comment places the text outside of range
Summary: EDITING: Undo of deletion of document text from beginning of ranged comment ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 148398 (view as bug list)
Depends on:
Blocks: Undo-Redo Writer-Comments
  Show dependency tree / graph
 
Reported: 2015-03-05 13:49 UTC by Gordo
Modified: 2024-11-01 03:14 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordo 2015-03-05 13:49:40 UTC 
1. New Text Document.
2. Type "This is a test.".
3. Select "test".
4. Insert Comment.
5. Type "test" in comment.
6. Insert cursor at beginning of "test".
7. Delete first two letters.
8. Undo deletion.
Expected Result:
All of "test" appears as part of the ranged comment.
Result:
First two letters are no longer part of the ranged comment.

If you delete the whole word and undo, it preserves the range.

This is really minor or trivial I guess.

Is there ever going to be moveable comment anchors and resizable ranges?

Version: 4.4.1.2
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432
Comment 1 Joel Madero 2015-03-06 05:53:02 UTC 
Ubuntu 14.10 x64
LibreOffice 4.4.1.2 release


Confirmed

New
Minor - can slow down but will not prevent high quality professional work
Low - default

@Gordo - for your question - we don't comment whether there "will ever be" - if a volunteer does it, then yes, else, no. We can't predict what volunteers will do.
Comment 2 tommy27 2016-04-16 07:26:14 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2017-05-22 13:22:09 UTC Comment hidden (obsolete)
Comment 4 Roman Kuznetsov 2019-04-17 06:02:08 UTC 
still repro in

Version: 6.3.0.0.alpha0+
Build ID: 3083fe569f96bf0289da1e9d0ef7da15ab22e2f6
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-04-16_01:39:55
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 5 QA Administrators 2021-04-17 04:08:00 UTC Comment hidden (obsolete)
Comment 6 Telesto 2022-04-21 09:02:17 UTC 
*** Bug 148398 has been marked as a duplicate of this bug. ***
Comment 7 Telesto 2022-04-21 09:03:16 UTC 
From bug 148398

Found in

Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba

MSO behaviour (not being able to delete), but it undo doesn't restore highlighting
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

everything fine with
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28
Comment 8 raal 2022-11-01 20:17:16 UTC 
This seems to have begun at the below commit.
 dfddc33f09f7c28fb49a9cea99e9a2be8a67f4fd is the first bad commit
commit dfddc33f09f7c28fb49a9cea99e9a2be8a67f4fd
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Thu May 28 18:10:05 2015 +0800

    source-hash-0761f81643a6890457e9ef7d913ab5c88c2593a4
    
    commit 0761f81643a6890457e9ef7d913ab5c88c2593a4
    Author:     Oliver-Rainer Wittmann <orw@apache.org>
    AuthorDate: Thu Dec 19 18:50:58 2013 +0000
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Wed Jan 8 15:58:35 2014 +0100
    
        123792: complete annotations on text ranges feature
    
        - rely annotations on text ranges on new annotation marks
        - support arbitrary text ranges for annotations
        - fix undo/redo regarding annotations an text ranges
        - support annotations on overlapping text ranges
        - fix *.docx import for annotations on overlapping text ranges
        - fix ODF import of annotations on text ranges
    
        cherry-picked from branch ooxml-osba
    
        (cherry picked from commit ebd2922ebd3cf2d3899fb80780d38f367197aadf)
Comment 9 QA Administrators 2024-11-01 03:14:12 UTC 
Dear Gordo,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug