Bug Hunting Session
Bug 90273 - Formatting Regression: Filling background page image can't be linked anymore, only embedded
Summary: Formatting Regression: Filling background page image can't be linked anymore,...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.1.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: confirmed:4.1.1.2:windowsVista multip...
Keywords: bibisected, bisected, regression
: 93174 (view as bug list)
Depends on:
Blocks: Area-Fill-Tab DrawingLayer-FillStyles-regressions
  Show dependency treegraph
 
Reported: 2015-03-26 23:17 UTC by João Paulo
Modified: 2019-08-24 21:57 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description João Paulo 2015-03-26 23:17:00 UTC
This is a regression from LibreOffice 4.3.6 final.

On Writer, I used to link an image when formatting the page background, instead of embedding it, to save storage space on multiple documents.

Upgraded today to LibreOffice 4.4.1.2 (was using 4.3.6 final without this bug).

Now it is not possible anymore, when formatting the page background, to link an image instead of embedding it. It is still possible to use earlier documents created with linked images, but not to change it to another linked image or create a new document and add a linked image to the page background.

Steps to reproduce it:

On Writer, access menu Format, Page, Area, Fill, choose Bitmap (should be called Image, as it allows to add bitmaps and vectors), Import Graphic. At the file selection box is not possible to select the option to link the image, so only embedding is possible now.
Comment 1 m.a.riosv 2015-03-26 23:55:43 UTC
Hi @João Paulo,

reproducible, win7x64 LibreOffice 4.4.1.2 and master.

Link option appear in the browse files window, but it's not available.
Comment 2 Robinson Tryon (qubit) 2015-03-31 13:54:29 UTC Comment hidden (obsolete)
Comment 3 João Paulo 2015-03-31 22:57:11 UTC
(In reply to Robinson Tryon (qubit) from comment #2)
> Removing comma from Whiteboard (please use a space to delimit values in this
> field)
> https://wiki.documentfoundation.org/QA/Bugzilla/Fields/
> Whiteboard#Getting_Started
> 
> (To list repro results in the Whiteboard, see the format used here:
> https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#confirmed:
> VERSION:OS
> https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#noRepro:
> VERSION:OS
> )

Thanks for the info, I will add the markups :-)

Also, I discovered that when saving the .FODT file with the linked image as .ODT, the linked image is saved inside the file, i.e., my .FODT document with a .SVG linked image (on some places of the document) was saved as .ODT and, upon inspecting it with 7-Zip, I found random numbered .PNG images embedded.

Excluding those .PNG images with 7-Zip and reopening with LibreOffice didn't show major issues, not even an error before opening, but the .PNG images were recreated from the linked .SVG and embedded on the document. Don't know if its a related bug, thoug. Should I create another one for this issue?
Comment 4 raal 2015-12-05 09:15:36 UTC
(In reply to João Paulo from comment #0)
> Steps to reproduce it:
> 
> On Writer, access menu Format, Page, Area, Fill, choose Bitmap (should be
> called Image, as it allows to add bitmaps and vectors), Import Graphic. At
> the file selection box is not possible to select the option to link the
> image, so only embedding is possible now.

This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara & Armin Le Grand; Could you possibly take a look at this one?
Thanks

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
e642812606be49244f2f775e90169fbd1be29a97
d3a0e6c621ceb08e11867a2e17f155ae1977cee2
We cannot bisect more!

author	Caolán McNamara <caolanm@redhat.com>	2014-06-20 11:42:59 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-07-01 11:30:09 (GMT)
commit	c7853b5b5cb71899b6b60fd2175763785b8afb7f (patch)
hook up new drawing support to .uis

author	Armin Le Grand <alg@apache.org>	2014-06-02 15:00:50 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-07-01 11:30:09 (GMT)
commit	7d9bb549d498d6beed2c4050c402d09643febdfa (patch)
Related: #i124638# Second step of DrawingLayer FillAttributes...


bibisect-44max$ git bisect log
# bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
# good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
git bisect start 'latest' 'oldest'
# bad: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4
git bisect bad 8cf60cc706948588e2f33a6d98b7c55d454e362a
# bad: [d9885f526fc7a09cc8f9f8ee643af1b966be24bb] source-hash-d1465c64c6f64ad8dd25e40cdc69649b24b305ea
git bisect bad d9885f526fc7a09cc8f9f8ee643af1b966be24bb
# good: [e3eab511ffbcd2e1e2c67e7a4fec162bb0b26b7a] source-hash-dc9cc46f3223aff3f85d3ce9696178a5f4d3d087
git bisect good e3eab511ffbcd2e1e2c67e7a4fec162bb0b26b7a
# good: [1477f347fb61b5b07de64312247b49371812f5b4] source-hash-4598bbe41d0906a34ceb1126c7fce2108642cd8e
git bisect good 1477f347fb61b5b07de64312247b49371812f5b4
# good: [fdbfc593506d9f38152b80f14c9e7afdbef0b40a] source-hash-6024ddbfac8e62db50dd5352d610c87d279627de
git bisect good fdbfc593506d9f38152b80f14c9e7afdbef0b40a
# good: [b1d1e3e3ac1515cf33be95eba837476142fb6ca8] source-hash-f55ddffd7e81cc8f3314047a6aa62991e2d293b1
git bisect good b1d1e3e3ac1515cf33be95eba837476142fb6ca8
# good: [163b7bd042acbad89907ad1e16c268229c8468a0] source-hash-e123226d874d59799ba4ca2a8919e50e7eb2ba3b
git bisect good 163b7bd042acbad89907ad1e16c268229c8468a0
# good: [5f58bd9cfbc5685748d354f12827ebda6c034708] source-hash-4e7f1f7f1113a1f0d60ed17d7712700683c35a24
git bisect good 5f58bd9cfbc5685748d354f12827ebda6c034708
# good: [552acdffffc36cc51fbb2266909af74febd76b5a] source-hash-cbfaf0c7945c68befac41a1e6561a49398cb6826
git bisect good 552acdffffc36cc51fbb2266909af74febd76b5a
# good: [0a3179e3faf94d913aed6fca59118ab1d9e67f0c] source-hash-69ea62a069f89f5efae8d3cee93a64a4b7ba8ba8
git bisect good 0a3179e3faf94d913aed6fca59118ab1d9e67f0c
# skip: [e642812606be49244f2f775e90169fbd1be29a97] source-hash-7d9bb549d498d6beed2c4050c402d09643febdfa
git bisect skip e642812606be49244f2f775e90169fbd1be29a97
# bad: [cc4b2429f5608f132e2d374bc320ac31a197cd65] source-hash-c3f70303cf3725cfd64d3b07c0e7e895f8ac629d
git bisect bad cc4b2429f5608f132e2d374bc320ac31a197cd65
# good: [1b9125c983db686bc5a1711c5030e30b600b4c1b] source-hash-42fcd888ae537152f9d59c03e945d4bf9aaeb7dd
git bisect good 1b9125c983db686bc5a1711c5030e30b600b4c1b
# bad: [d3a0e6c621ceb08e11867a2e17f155ae1977cee2] source-hash-c7853b5b5cb71899b6b60fd2175763785b8afb7f
git bisect bad d3a0e6c621ceb08e11867a2e17f155ae1977cee2
# good: [e3c84f2b17b881007208ac54c45cbfcd7dc395b2] source-hash-a5e137eb1d37361c60175e8fba780fc46b377a23
git bisect good e3c84f2b17b881007208ac54c45cbfcd7dc395b2
# only skipped commits left to test
# possible first bad commit: [d3a0e6c621ceb08e11867a2e17f155ae1977cee2] source-hash-c7853b5b5cb71899b6b60fd2175763785b8afb7f
# possible first bad commit: [e642812606be49244f2f775e90169fbd1be29a97] source-hash-7d9bb549d498d6beed2c4050c402d09643febdfa
Comment 5 Armin Le Grand 2015-12-07 12:37:15 UTC
It is a follow-up for changing the FillStyle attributes to the broader standard. Graphics used for FillStyle do not support linked data currently - see draw objects in any application. I experimented in the xml format to check if this would be possible. In principle, it is, but would need some more work.
- Support linked graphics for FillStyle
- In all apps
- For all FillStyles (objects, frames, page, Header/Footer, ....)
- UI: Link button in Area and Bitmap dialog + support in cores
- UI: In Writer's Link editor (probably all apps) support editing links originating from Graphics in Styles (change, break, ...)
Comment 6 Robinson Tryon (qubit) 2015-12-09 18:18:57 UTC Comment hidden (obsolete)
Comment 7 Xisco Faulí 2016-10-13 21:51:42 UTC
*** Bug 93174 has been marked as a duplicate of this bug. ***
Comment 8 QA Administrators 2019-03-01 03:49:19 UTC Comment hidden (obsolete)
Comment 9 João Paulo 2019-03-02 01:22:18 UTC
Hi, I tested this bug on Windows 10 version 1809 with LibreOffice version 6.2.0.3 (x64), build ID  98c6a8a1c6c7b144ce3cc729e34964b47ce25d62.

This bug is still present.

The last version I used without this bug was LibreOffice 4.3.6 final.
Comment 10 Grantler 2019-08-21 21:50:19 UTC
Bug still on LO 6.3.0.3 (LinuxMint 19.2-64)
Comment 11 Leandro Martín Drudi 2019-08-24 21:57:46 UTC
Reproducible in:
Versión: 6.3.0.4 (x64)
Id. de compilación: 057fc023c990d676a43019934386b85b21a9ee99
Subprocs. CPU: 8; SO: Windows 10.0; Repres. IU: predet.; VCL: win; 
Configuración regional: es-AR (es_AR); Idioma de IU: es-ES
Calc: CL