Created attachment 114420 [details] example files When saving the .xls spreadsheet external links are not stored as relative. If file is moved external links not update nor in the LO or in MSO. When you open the spreadsheet created in MSO external links updating succeeds. For .xlsx the problem does not occur. In attachment: lo_master.xls - the spreadsheet with external link created in LO. mso_master.xls - the spreadsheet with external link created in MSO. down/slave.xls - the spreadsheet for external link. lo_master.xlsx - the .xlsx spreadsheet with external link created in LO.
Hello geeker, thanks for reporting bug. Please try following: - In down/slave.xls rename name of the sheet "Лист1" - new name for example "list1". No cyrillic characters. - in lo_master.xls delete all formulas and create new link to slave.xls. Let me know if it works for you and set to bug to unconfirmed. Thank you (ref.85617)
There is an option for save with relative/absolute paths. Menu/Tools/Options/Load-Save/General - Save URLs relative to file system. Is the option marked?
(In reply to m.a.riosv from comment #2) > There is an option for save with relative/absolute paths. > > Menu/Tools/Options/Load-Save/General - Save URLs relative to file system. > > Is the option marked? Yes, it's marked.
(In reply to raal from comment #1) > Please try following: > > - In down/slave.xls rename name of the sheet "Лист1" - new name for example > "list1". No cyrillic characters. > - in lo_master.xls delete all formulas and create new link to slave.xls. > > Let me know if it works for you and set to bug to unconfirmed. > Thank you > > (ref.85617) No, it don't work
Tested now with 4.4.1.2 ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432, win7 and can not confirm. I created new files. Please test with 4.4.1.2, https://www.libreoffice.org/download/libreoffice-fresh/
Created attachment 114468 [details] test with 4.4.1.2
(In reply to raal from comment #5) > Tested now with 4.4.1.2 ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432, > win7 and can not confirm. I created new files. Please test with 4.4.1.2, > https://www.libreoffice.org/download/libreoffice-fresh/ I tested with 4.4.1.2 yesterday. And repeated now (see "test with 4.4.1.2" attachment). Can you load your new file?
I can reproduce with Version: 4.4.3.0.0+ Build ID: 3eba5eb1774ab621a1f0f4dcc7e82cce6c025b0a TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-4-4, Time: 2015-03-27_09:07:12 reproducible with LO 3.5
It's reproduced in Version 5.0.0.5.
version 3.5 per comment 8. Possibly inherited from OOo ?
I have a set of Calc (.ods) spreadsheets which I share between a Linux and a Windows computer. There are references between the files, which used to work fine. I upgraded the Linux from Ubuntu from 12.04 to 14.04 and now references across files don't work when I open the files on the Windows computer. The references appear to be "absolute", when using Windows. I see the Linux paths/filenames in cell formulas. However, if I copy the files to a different directory on the Linux machine, Libre Office 4.2.8.2 happily opens them, dealing with the references. On Linux I use Libre Office 4.2.8.2. On the Windows machine I have Open Office 3.4.1. My conclusion: LO 4.2.8.2 and OO 3.4.1 both deal correctly with relative file references, but somehow they don't agree on the file format (like LO 3.5 (?) and OO 3.4.1 used to.
If I open the files (unzipping and inspection the content.xml) it turns out that both newly modified files and older ones actually contain "absolute paths". Somehow these must be dealt with when the file is opened, but I can't figure out how. I guess I am suggesting that there has been a change (although I can't figure it out) as to how file paths/names are managed in new LO versions. Possibly the same change fools not only OO 3.4.1 but also Excel... Sounds vague, I guess...
(to be honest, I get the feeling too that links tend to work not always reliable, in the various scenario's.. Have seen, tested and commented quite some issues about it.)
Win7x64 Version: 5.1.1.3 (x64) Build ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d Unfortunately, work with external links was broken also in xlsx.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Dear geeker, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
(In reply to geeker from comment #14) > Win7x64 Version: 5.1.1.3 (x64) Build ID: > 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d > Unfortunately, work with external links was broken also in xlsx. Confirming the problem in the Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
Code pointer: The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl (sc/source/filter/excel/xehelper.cxx). The latter *unconditionally* tries to store *drive* relative to base, but *does not* try to save directory path relatively. There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, that does the opposite cf. to lclEncodeDosUrl. Basically the task of the easy hack is: check with an Excel-generated XLS containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; then implement passing the value of XclExpRoot::IsRelUrl() down to lclEncodeDosUrl; and then in the latter, implement proper generation of relative address depending on the passed IsRelUrl value.
(In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I am working on this bug, so far I could find that: 1. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001\002down\003slave.xls". 2. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001down\003slave.xls"
(In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I am working on this bug, so far I could find that: 1. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001\002down\003slave.xls". 2. when XclImpUrlHelper::DecodeUrl is called using mso_master.xls doc, the value of rEncodedUrl is "\001down\003slave.xls"
(In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I use GDB to debug, but I do not know how to invoke XclExpRoot::IsRelUrl() and lclEncodeDosUrl methods. using "call lclEncodeDosUrl()" won't work until I step into the file "sc/source/filter/excel/xehelper.cxx" can you please provide some hint regarding this?
(In reply to Vaibhav Malik from comment #21) Please use gerrit for discussion of code. Your task is to create a change, even if it doesn't work; it will show your code, and there you may include code comments, or post gerrit comments, explaining your ideas, the specific problems (including specific points, passed values, expected and actual results, call stacks etc.), and would enable review and advices.
Łukasz Leszko committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/59ddcb0445da12f2b912f1a8a876117fec112c41 tdf#90299 Fix saving external links as relative It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can this be closed as fixed?
(In reply to Buovjaga from comment #24) > Can this be closed as fixed? I just checked if my patch still works, and it does, so I guess we can close it.