Bug 90336 - Make it visible in "Options - LibreOffice - OpenCL" whether OpenCL will be used, and which implementation
Summary: Make it visible in "Options - LibreOffice - OpenCL" whether OpenCL will be us...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-30 03:00 UTC by Matthew Francis
Modified: 2016-08-22 06:52 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Francis 2015-03-30 03:00:41 UTC
Currently there's no easy way to see what the result of the settings in "Options - LibreOffice - OpenCL" will be.

It would be useful to show whether OpenCL will be used based on the active OpenCL whitelist and blacklist settings, and if possible which implementation.
Comment 1 Markus Mohrhard 2015-03-30 03:04:01 UTC
The setting around OpenCL are available in opencl/source/openclconfig.

The OpenCL dialog is in cui/source/options/optopencl.cxx and cui/uiconfig/ui/optopenclpage.ui
Comment 2 How can I remove my account? 2015-03-30 06:03:43 UTC
Ideally we shouldn't have the white and black lists visible in the UI at all. I don't have any expectation that actual end-users will ever understand what they mean, or edit them. (This is my personal opinion.)
Comment 3 Robinson Tryon (qubit) 2015-12-13 10:57:58 UTC Comment hidden (obsolete)
Comment 4 Robinson Tryon (qubit) 2016-02-18 14:52:13 UTC Comment hidden (obsolete)
Comment 5 JIří Burant 2016-03-05 09:04:16 UTC
I will try to fix this bug.
Comment 6 jani 2016-03-05 10:54:49 UTC
(In reply to JIří Burant from comment #5)
> I will try to fix this bug.

Super, let us (me) know if you need help. Also have a look at:
https://wiki.documentfoundation.org/Development/GetInvolved

happy hacking
Comment 7 JIří Burant 2016-03-20 15:52:07 UTC
I'm currently struggling with this bug. I went through the files concerning openCL, but I cant find a method which would give me the actual openCL setting on the computer, so I can compare it with the black and white lists.

The only reasonable thing I found, that could be doing this is

'gpuEnv' from 'openclwrapper.cxx':


GPUEnv gpuEnv;

respectively:

gpuEnv.mpDevID


But I am not sure what does this variable mean, or what does it do.

Thanks for help
Comment 8 jani 2016-04-20 05:50:44 UTC Comment hidden (obsolete)
Comment 9 JIří Burant 2016-04-20 09:04:19 UTC
Yes, I have submitted it for a review, I got some feedback, but the reviewers didnt really agree how it should look like, so I am waiting for a decesive response.
Comment 10 jani 2016-05-29 08:05:07 UTC
Unassign due to lack of work
Comment 11 Commit Notification 2016-06-29 17:07:12 UTC
JBurant committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c58ef7f10839d78859c470c160fe20ae2d49e6ab

tdf#90336, make it visible in options, if openCL will be used

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Michael Meeks 2016-06-30 12:27:54 UTC
Still needs some cleanup based on Tor's comments ... =)
Comment 13 Michael Meeks 2016-07-01 17:41:41 UTC
I've pushed a cleanup patch here - unfortunately - this is no longer an easy hack; there is some nasty thinking to be done around how OpenCL is enabled or not enabled - pwrt. its first use.

So - taking the rest of this =)
Comment 14 Commit Notification 2016-07-01 19:03:53 UTC
Michael Meeks committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef47ce2397d4ed453fe01d994d13a13f442ec3bb

tdf#90336 - further cleanup of OpenCL options page.

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 How can I remove my account? 2016-08-22 06:52:21 UTC
I think this can be resolved now. As we now do the OpenCL verification early on first-time start (with an empty profile), probably the indication matches reality.