Bug 90596 - Press Shortcut ctrl-w twice and changes are lost
Summary: Press Shortcut ctrl-w twice and changes are lost
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.3.2 release
Hardware: Other Linux (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 20:21 UTC by niederwipper
Modified: 2015-04-15 16:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description niederwipper 2015-04-13 20:21:30 UTC
CTRL-w is a favorite shortcut to close an application, so it is in calc or writer. If changes are unsaved, you get a confirmation dialog (after pressing CTRL-w). In the confirmation dialog CTRL-w calls the function "close without saving". This is dangerous because if you want to close several windows you press CTRL-w several times and trust to be stopped if there is unsaved data in the dialog trying to close. Not so in Libreoffice. If you now press CTRL-w (in the confirmation dialog) the unsaved changes of the document are lost. CTRL-w should close the confirmation dialog (like cancel or ESC), but not call the "close without saving" function.

Thanks for free software !
Comment 1 Yousuf Philips (jay) (retired) 2015-04-13 21:29:59 UTC
Hello niederwipper,

Thank you for submitting the bug. I can confirm the bug is available in the version you specified, but it has been fixed in version 4.4, so i'd like to recommend that you upgrade.

It seems the close confirmation dialog in 4.3 has 'w' underlined in 'Close without saving' and pressing W or Ctrl + W is clicking the button. In 4.4, the button has been renamed 'Don't Save', so there isnt a W in it.

@qubit, beluga: Please decide whether this should be closed or should be fixed, as i was going to set it to WORKSFORME.
Comment 2 Robinson Tryon (qubit) 2015-04-13 21:38:54 UTC
(In reply to Jay Philips from comment #1)
> ... it has been fixed in version 4.4, so i'd like to
> recommend that you upgrade.
> ....
> @qubit, beluga: Please decide whether this should be closed or should be
> fixed, as i was going to set it to WORKSFORME.

If the bug is fixed in master, then please RESOLVE as WORKSFORME. If desired, you could put backportRequest:4.3 in the Whiteboard, but I think the devs might just encourage people to upgrade to 4.4.

Whiteboard: (remove) needQAAdvice
Status -> RESOLVED WORKSFORME
Comment 3 Yousuf Philips (jay) (retired) 2015-04-13 21:42:43 UTC
(In reply to Robinson Tryon (qubit) from comment #2)
> If the bug is fixed in master, then please RESOLVE as WORKSFORME. If
> desired, you could put backportRequest:4.3 in the Whiteboard, but I think
> the devs might just encourage people to upgrade to 4.4.

Was planning to set it to backportrequest, but we cant change the name of the button because of the string freeze. The only solution would be to disable ctrl + w from working.
Comment 4 niederwipper 2015-04-13 22:33:43 UTC
Thanks a lot for the information update and your affords in free software and sorry that I did not check in a more recent version.

Yours Frank
Comment 5 Buovjaga 2015-04-14 05:19:31 UTC
niederwipper: let's keep the status as WFM as we don't know what commit fixed it.
Comment 7 Adolfo Jayme Barrientos 2015-04-15 15:08:49 UTC
(In reply to Beluga from comment #5)
> niederwipper: let's keep the status as WFM as we don't know what commit
> fixed it.

It was this one: http://cgit.freedesktop.org/libreoffice/core/commit/?id=10abd657aacea884f520c97054625a94184c4aca
Comment 8 Robinson Tryon (qubit) 2015-04-15 16:36:26 UTC
(In reply to Adolfo Jayme from comment #7)
> (In reply to Beluga from comment #5)
> > niederwipper: let's keep the status as WFM as we don't know what commit
> > fixed it.
> 
> It was this one:
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=10abd657aacea884f520c97054625a94184c4aca

Reasoning for status of RESOLVED INVALID? If we know which commit fixed the bug, I think status should be RESOLVED FIXED, right?