Bug 90792 - Enable toolbar code to load HiDPI bitmaps
Summary: Enable toolbar code to load HiDPI bitmaps
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.2.3.3 release
Hardware: Other Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
Depends on:
Blocks: HiDPI Toolbars
  Show dependency tree / graph
 
Reported: 2015-04-22 21:40 UTC by Keith Curtis
Modified: 2017-07-12 20:32 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Curtis 2015-04-22 21:40:03 UTC 
People are working on HiDPI toolbar bitmaps, but the LibreOffice code still needs to support to loading them.
 
The current code just doubles all the bitmaps: http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox2.cxx#1112

This is a nice little hack that can stay around as long as we still have some themes without better bitmaps, but one day someone needs to write a bit of code that fixes (some of) the callers of this routine, and make them load larger bitmaps if they exist for a theme.

One open issue is whether it worth it using the SVG format.

I believe this is an interesting Easy Hack that could make a nice visual improvement on these pretty screens. For now, it would probably only apply to Linux and Windows, and somewhat different code would be needed for the Mac.
Comment 1 Robinson Tryon (qubit) 2015-12-14 05:00:14 UTC Comment hidden (obsolete)
Comment 2 Robinson Tryon (qubit) 2016-02-18 14:51:23 UTC Comment hidden (obsolete)
Comment 3 Keith Curtis 2016-12-12 06:14:05 UTC 
I saw this was fixed in 5.3.