"Save As" can't be used on a file opened in view mode to overwrite the original file. This is related to bug 65498, but was introduced by a different commit. (This one is specific to "Save As") Steps to reproduce: - Open any LO document (Writer, Calc, ...) with the --view option - Enable editing - Save As... and accept the original filename Expected result - The file is saved Actual result - Error dialog
Taking the liberty of setting this to NEW myself as a commit has been identified. Bisection narrowed this down to e70c4a279c2a8f93d917c0a43fc39ac017ecc463^1..e2799d253b1dc62967693aa5bccd7360a9520967 but ignoring the irrelevant and/or broken commits in that range, it's e2799d253b1dc62967693aa5bccd7360a9520967 which looks like it has changes relevant to read-only mode Adding Cc: to michael.meeks@collabora.com; In the unlikely event you have time to take a look at this one... commit e2799d253b1dc62967693aa5bccd7360a9520967 Author: Michael Meeks <michael.meeks@suse.com> Date: Thu Jul 5 20:18:35 2012 +0100 re-base on ALv2 code. Includes: Patches contributed by Mathias Bauer: cws mba34issues01: #i117713#: remove superfluous assertions about field unit fallbacks http://svn.apache.org/viewvc?view=revision&revision=1172341 cws mba34issues01: #i117718#: provide filter name in case storage of medium does not allow to detect one cws mba34issues01: #i117712#: fix several resource errors introduced by IAccessible2 implementation http://svn.apache.org/viewvc?view=revision&revision=1172343 http://svn.apache.org/viewvc?view=revision&revision=1172350 cws mba34issues01: #i117708#: status indicator for inactive documents http://svn.apache.org/viewvc?view=revision&revision=1172358 cws mba34issues01: #i116025#: fix typo and add missing treatment of new parameter http://svn.apache.org/viewvc?view=revision&revision=1172359 cws mba34issues01: #i117024#: rework parameter conversion for load/save slots http://svn.apache.org/viewvc?view=revision&revision=1172360 cws mba34issues01: #i116803#: possible crash on Linux when dispatch.cxx is compiled with optimization http://svn.apache.org/viewvc?view=revision&revision=1172367 cws mba34issues01: #i114600#: fix compiler warning for name clash found on Solaris http://svn.apache.org/viewvc?view=revision&revision=1172371
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]
Adding Cc: to Michael Meeks
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Dear Matthew Francis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Dear Matthew Francis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
This hits objserv.cxx "Fatal IO error during save" exception p aErrorEx $2 = (const com::sun::star::task::ErrorCodeIOException &) @0x555559be99a0: {<com::sun::star::io::IOException> = {<com::sun::star::uno::Exception> = { Message = "SfxBaseModel::storeSelf: 0x507 /persistent/git/libreoffice2/sfx2/source/doc/sfxbasemodel.cxx:1685", Context = empty uno::Reference}, <No data fields>}, ErrCode = 1287} This comes from sfx2/source/doc/docfile.cxx The document is still considered read only because bReadOnly = !( GetOpenMode() & StreamMode::WRITE ); Ultimately, the error is set by if ( !bLoading || (pReadOnlyItem && !pReadOnlyItem->GetValue()) ) SetError(ERRCODE_IO_ACCESSDENIED); since it is not bLoading.
I'm not sure I would classify this as an bug/regression. With the view flag, you are effectively flagging the file as a read-only medium. In any case, this will be an extremely dangerous working area. Not for me.
Hmm -I get this: --- a/sfx2/source/doc/objstor.cxx +++ b/sfx2/source/doc/objstor.cxx @@ -2639,6 +2639,7 @@ bool SfxObjectShell::Save_Impl( const SfxItemSet* pSet ) { if ( IsReadOnly() ) { + SAL_DEBUG("SAVE_Impl at the top"); SetError(ERRCODE_SFX_DOCUMENTREADONLY); return false; } triggering the error for me - it seems we switch to 'Save_Impl' if the destination file is the same as the source file - and it seems rather a reasonable error that we give; and a reasonably safe behavior. Will push a patch to clarify the error message =)
Michael Meeks committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/170a2b9da7848b66d93e10aed29f7f5ac2c8ebca tdf#90837 - clarify the error message re: over-writing readonly files. It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/3f578443d92b0c56f8f2c1fb6c6bb5be8ab4ea54 tdf#90837 - clarify the error message re: over-writing readonly files. It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.