Load LibreLex; create a new / empty document; open the place-document dialog click the '...' expander to select a file-name; enter random stuff, hit 'ok' Crash =)
Cor filed; poked at it - some unsafe handling of the case with no file filters in the 'save' path - not a terribly common use-case; protected those.
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=58b76d531b7fe3a810b39a38b0a2ba62b710eee7 tdf#91043 - attempted fix of filer-less gtk+ save dialog crash. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
prolly fixed =)
Thanks for picking this up. Alas, still crashes in Version: 5.0.0.0.alpha1+ Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-05-07_00:08:39 Locale: nl-NL (nl_NL.UTF-8) Will dive into the LibreLex part of the stuff and report here more clearly what is going on. (And test the same scenario in other versions too.)
You will need a stack-trace taken vs. a build with debug symbols to make this useful I think; fixing such things blind is a bit of a pain =)
(In reply to Michael Meeks from comment #5) > You will need a stack-trace taken vs. a build with debug symbols to make > this useful I think; fixing such things blind is a bit of a pain =) Some combined ugliness going on there. Also an unhandeld basic exception, but solving that does not end the crash. So will get the needed stuff.
(In reply to Michael Meeks from comment #5) > You will need a stack-trace taken vs. a build with debug symbols to make > this useful I think; I repaired some errors for corner cases, but indeed, unrelated. Two more things: - choosing the LibreOffice file dialog makes that it does not crash. - I'm doing lots of praying/meditation these days in my normal operations, since my laptop can't handle all the load, so little hope to do a build with debug symbols myself..
Dear Bug Submitter, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INVALID due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team
Dear Bug Submitter, Please read this message in its entirety before proceeding. Your bug report is being closed as INVALID due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team This INVALID Message was generated on: 2016-05-09
still crashes with non libreoffice file dialog in Version: 5.3.0.0.alpha0+ Build ID: 1ef48f3bebe80a386490e2a0f8fd0ae40de07ada CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-09-18_23:46:24 Locale: nl-NL (nl_NL.UTF-8); Calc: group
downloading master_dbg~2016-09-18_23.51.47_LibreOfficeDev_5.3.0.0.alpha0_Linux_x86_archive.tar.gz for retrieving a stack trace..
Created attachment 127579 [details] strace log of the crash Mind! LibreOffice starts with document recovery, unrelated to the crashing problem.
Created attachment 127580 [details] gdbtrace log of the crash Mind! LibreOffice starts with document recovery, unrelated to the crashing problem.
@michael: does this help :) ?
Trace is very helpful; #4 0x00007fffda86fc57 in std::__debug::list<FilterEntry, std::allocator<FilterEntry> >::end (this=0x0) at /opt/rh/devtoolset-2/root/usr/include/c++/4.8.2/debug/list:193 Shows that m_pFilterList is nullptr - and we de-reference it thus: FilterList::iterator aListIter = ::std::find_if( m_pFilterList->begin(), m_pFilterList->end(), FilterTitleMatch(sFilterName) ); bang ! =) So - the fix is simple enough; although - I've not fully thought through whether this is really meaningful; I assume you're creating this with UNO and not populating the filter list somehow (?) =)
Testing appreciated for: https://gerrit.libreoffice.org/29238 tdf#91043 - vcl: gtk file picker should tolerate empty filter list. as/when/if it is merged etc. =) Thanks !
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3be5deadcb46e09d84d99b2b108b65b06ff356e9 tdf#91043 - vcl: gtk file picker should tolerate empty filter list. It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #17) > Affected users are encouraged to test the fix and report feedback. Thanks - fixed the problem! (In reply to Michael Meeks from comment #15) > So - the fix is simple enough; although - I've not fully thought through > whether this is really meaningful; I assume you're creating this with UNO > and not populating the filter list somehow (?) =) Heh ;) The simple version of what is used to populate the dialog: = = sFilePickerArgs = Array(com.sun.star.ui.dialogs.TemplateDescription.FILESAVE_AUTOEXTENSION_PASSWORD ) With oFilePickerDlg .Initialize ( sFilePickerArgs() ) Select Case PsDocType .AppendFilter( "OpenDocument Text (.odt)", "*.odt" ) .AppendFilter( "OpenDocument Drawing (.odg)", "*.odg" ) .SetCurrentFilter( "OpenDocument Text (.odt)" ) .SetValue(com.sun.star.ui.dialogs. ExtendedFilePickerElementIds.CHECKBOX_AUTOEXTENSION, 0, true) .SetValue(com.sun.star.ui.dialogs. ExtendedFilePickerElementIds.CHECKBOX_PASSWORD, 0, false) End With If oFilePickerDlg.execute() > 0 Then sFilesPicked() = oFilePickerDlg.getFiles() GetNameUsingFilePicker = sFilesPicked(0) End If = =
Hi Cor; what would be lovely would be creating a unit-test that sets up a file-picker with no filters like this and exercises it so the issue doesn't come back =) Anyhow - glad it fixes it, will pick to -5-1.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=60f87b899ba856b1c71a73e12f169f4fed3da121&h=libreoffice-5-2 tdf#91043 - vcl: gtk file picker should tolerate empty filter list. It will be available in 5.2.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=651c6aaa44c9748d6900296b1227c89c2a43e3ed&h=libreoffice-5-1 tdf#91043 - vcl: gtk file picker should tolerate empty filter list. It will be available in 5.1.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.