Bug 91112 - replace use of o3tl::compose1 by lambdas
Summary: replace use of o3tl::compose1 by lambdas
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Jorenz Paragas
URL:
Whiteboard: target:5.1.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2015-05-06 15:03 UTC by David Tardon
Modified: 2016-10-25 19:17 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Tardon 2015-05-06 15:03:36 UTC
Search for expressions that use o3tl::compose1 and rewrite them using lambda expressions. This should significantly improve readability of the code :-)

As the last step, remove compose1 itself and the helper class unary_compose.
Comment 1 Jorenz Paragas 2015-06-22 02:13:49 UTC
Hello. I'm new to contributing to LibreOffice, and I'm going to start working on this Easy Hack.
Comment 2 tommy27 2015-06-22 07:15:03 UTC
nice to hear that. put youself under the "Assigned to" field
Comment 3 Commit Notification 2015-06-25 10:17:58 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f571a17484032bc2a09144ea8b97e91e1f8cc5a5

tdf#91112 replace o3tl::compose1 with lambdas in dbaccess

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2015-06-30 13:30:05 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=02d3ae938d92988bb24b370ca0beece17bb275fa

tdf#91112 replace o3tl::compose1 with lambdas in reportdesign

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2015-07-13 12:24:08 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e7c923d632c757c9a38a724cad2d55a84755570

tdf#91112 replace o3tl::compose1 with lambdas in connectivity

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2015-07-29 06:53:59 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e9999b01e8a6932cbd30ca117038c9dd990414f

tdf#91112 replace o3tl::unary_compose with lambdas in connectivity

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Daniel L Robertson 2015-08-01 12:14:11 UTC
I just commited a patch related to this issue while working on tdf#92459

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5916d5866c109b17471a9c8604635612a0aa69ae
Comment 8 Jorenz Paragas 2015-08-01 18:37:22 UTC
(In reply to Daniel L Robertson from comment #7)
> I just commited a patch related to this issue while working on tdf#92459
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=5916d5866c109b17471a9c8604635612a0aa69ae

I saw it. Thanks :)
Comment 9 Commit Notification 2015-08-03 07:02:00 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a2e0fa708bb00d35febe9e8939dcc0c2197e2f4

tdf#91112: replace o3tl::compose1 with lambdas in sd and svx

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2015-08-03 07:03:11 UTC
Jorenz Paragas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=37ec6cbeebc5dc9bf642eedcf45f0441edd3d610

tdf#91112: pass by const reference to lambdas

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 11 Jorenz Paragas 2015-08-17 18:57:40 UTC
o3tl::compose1 was removed by this commit here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c4d75bea581266ccfc186da4db2c04901c9f862

Thus, this Easy Hack is resolved.
Comment 12 Robinson Tryon (qubit) 2015-12-16 00:11:09 UTC Comment hidden (obsolete)
Comment 13 Robinson Tryon (qubit) 2016-02-18 16:37:32 UTC Comment hidden (obsolete)