Search for expressions that use o3tl::compose1 and rewrite them using lambda expressions. This should significantly improve readability of the code :-) As the last step, remove compose1 itself and the helper class unary_compose.
Hello. I'm new to contributing to LibreOffice, and I'm going to start working on this Easy Hack.
nice to hear that. put youself under the "Assigned to" field
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f571a17484032bc2a09144ea8b97e91e1f8cc5a5 tdf#91112 replace o3tl::compose1 with lambdas in dbaccess It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=02d3ae938d92988bb24b370ca0beece17bb275fa tdf#91112 replace o3tl::compose1 with lambdas in reportdesign It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e7c923d632c757c9a38a724cad2d55a84755570 tdf#91112 replace o3tl::compose1 with lambdas in connectivity It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e9999b01e8a6932cbd30ca117038c9dd990414f tdf#91112 replace o3tl::unary_compose with lambdas in connectivity It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I just commited a patch related to this issue while working on tdf#92459 http://cgit.freedesktop.org/libreoffice/core/commit/?id=5916d5866c109b17471a9c8604635612a0aa69ae
(In reply to Daniel L Robertson from comment #7) > I just commited a patch related to this issue while working on tdf#92459 > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=5916d5866c109b17471a9c8604635612a0aa69ae I saw it. Thanks :)
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a2e0fa708bb00d35febe9e8939dcc0c2197e2f4 tdf#91112: replace o3tl::compose1 with lambdas in sd and svx It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jorenz Paragas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=37ec6cbeebc5dc9bf642eedcf45f0441edd3d610 tdf#91112: pass by const reference to lambdas It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
o3tl::compose1 was removed by this commit here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c4d75bea581266ccfc186da4db2c04901c9f862 Thus, this Easy Hack is resolved.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup ) [NinjaEdit]
Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit]