On pc Debian x86-64 with master sources updated today (0ac80267730300f53e2410ffe9c0883f19f656a6), I don't have a crash when running the macro in Basic editor.
But if I close the window, I got a "crash like" behavior and this on console:
warn:legacy.osl:6224:1:vcl/source/window/window.cxx:271: Window ( 23SfxFrameViewWindow_Impl ()) with live children destroyed:  9ScrollBar () 9ScrollBar () 12ScrollBarBox () N6basctl6TabBarE () N6basctl17ModulWindowLayoutE ()
Window ( 23SfxFrameViewWindow_Impl ()) with live children destroyed:  9ScrollBar () 9ScrollBar () 12ScrollBarBox () N6basctl6TabBarE () N6basctl17ModulWindowLayoutE ()

I confirm the initial report is now solved. no more problem on basic or dialog statement

The error on exit is confirmed.
Should I open a different bug report ?

IMHO since there has been no comment from users or generated comments by gerrit, I'd be ok to "convert" this one, so no need to create a new one.

With this patch:
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 2d8d794..b8ffde1 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -1483,8 +1483,8 @@ ModulWindowLayout::~ModulWindowLayout()
 
 void ModulWindowLayout::dispose()
 {
-    aWatchWindow.disposeAndClear();
     aStackWindow.disposeAndClear();
+    aWatchWindow.disposeAndClear();
     pChild.clear();
     Layout::dispose();
 }
diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx
index 1c01f29..1cd01cd 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -225,6 +225,12 @@ Shell::~Shell()
     SetWindow( 0 );
     SetCurWindow( 0 );
 
+    pTabBar.disposeAndClear();
+    aObjectCatalog.disposeAndClear();
+    aScrollBarBox.disposeAndClear();
+    aVScrollBar.disposeAndClear();
+    aHScrollBar.disposeAndClear();
+
     for (WindowTable::iterator it = aWindowTable.begin(); it != aWindowTable.end(); ++it)
     {
         // no store; does already happen when the BasicManagers are destroyed

I get now:
warn:vcl.gdi:7355:1:vcl/source/outdev/outdev.cxx:228: OutputDevice::~OutputDevice(): OutputDevice::Push() calls != OutputDevice::Pop() calls
warn:legacy.osl:7355:1:vcl/source/window/window.cxx:271: Window ( 23SfxFrameViewWindow_Impl ()) with live children destroyed:  N6basctl17ModulWindowLayoutE ()
Window ( 23SfxFrameViewWindow_Impl ()) with live children destroyed:  N6basctl17ModulWindowLayoutE ()

Then I noticed in basctl/source/basicide/basides1.cxx this:
   1011             SetWindow(pLayout);
   1012             pLayout = 0;
I removed line 1012 for the test but had this:
soffice.bin: /home/julien/compile-libreoffice/libreoffice/include/vcl/outdev.hxx :283 : void OutputDevice::release() const:  l'assertion « mnRefCnt>0 » failed

I'm a bit stuck :-(

Patches look plausible =)

Ultimately, we need to try to work out who are the owners of these widgets; and ensure the owners disposeAndClear them - if we look to the situation beforehand; where there was (perhaps) some boost::shared_ptr or unique_ptr in the class header; we want to manually disposeAndClear those in the reverse order in either a ::dispose method or the destructor really.

Thanks for chasing ! =) do you want to carry on ? or should I look at it ?

(In reply to Michael Meeks from comment #5)
> Patches look plausible =)
> 
> Ultimately, we need to try to work out who are the owners of these widgets;
> and ensure the owners disposeAndClear them - if we look to the situation
> beforehand; where there was (perhaps) some boost::shared_ptr or unique_ptr
> in the class header; we want to manually disposeAndClear those in the
> reverse order in either a ::dispose method or the destructor really.
> 
> Thanks for chasing ! =) do you want to carry on ? or should I look at it ?

For the moment I must wait the end of the build since I've updated my local repo.

I can submit patches on gerrit but would prefer to submit a complete one obviously.
The problem is I don't know how to deal "pLayout". It seems there are at least 2 ways:
- remove "pLayout = 0" but got the error I indicated and don't know how to keep on (perhaps http://nabble.documentfoundation.org/tool-for-chasing-elusive-VclPtr-lt-gt-crashers-td4148531.html ?)
- replace "pLayout = 0" by "pLayout.disposeAndClear()" but it fails when opening Basic dialog (not at then closing) with even more live children destroyed than when I began.

In brief, I don't think I can make it so if you've got some time...

I can't reproduce with bd4f62dfcefa2dad749431f80a1e6c00c28751ca - I run 'Print "Hello"' - it opens a window, and I close it nicely - bother; now I see I wasted my time and this bug turned into another one half way down [ urgh that's really not ideal ]

Julien - thanks for the patch; I pushed that in your name; but there was a fair bit more badness there that I've nailed too.

Thanks for the report !

Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=72e6c70738a8c78f824319ec2bbf864e9997806b

tdf#91239 - add missing disposeAndClear logic for basctl.

It will be available in 5.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Michael Meeks committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=33414c8bf7a4eb8fa912bc0062237637a8e05be2

tdf#91239 - return VclPtr's from Create Fn.s and add missing dispose logic.

It will be available in 5.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.