Bug 91378 - Custom properties: Empty Custom Properties are lost while saving in .pptx format
Summary: Custom properties: Empty Custom Properties are lost while saving in .pptx format
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 10:28 UTC by Heena Gupta
Modified: 2021-01-13 12:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
The unit test document before and after save in current master (85.83 KB, image/png)
2021-01-13 12:10 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heena Gupta 2015-05-19 10:28:55 UTC

    
Comment 1 Muthu 2015-05-19 10:37:36 UTC
@Heena: Can you please provide details of the bug, please?
Comment 2 Heena Gupta 2015-05-19 11:04:11 UTC
Problem Description

In some scenarios, empty properties are created in the impress file(in .pptx format), which are later populated automatically through some tool (example work flow scenarios). Impress removes empty custom property while saving the document in .pptx format

Steps to reproduce:
1. Open Impress and use a .pptx format
2. Add it a custom property. Donot enter any value for the property
3. Save it and close Impress
4. Open again Impress and use same pptx file recently saved.
5. Custom property is lost.

Current behavior:

Expected behavior:
Impress should retain empty custom property also while saving the file in .pptx format
Comment 3 Commit Notification 2015-06-25 13:34:58 UTC
Heena Gupta committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=16e8ffbd5ec1fe7b81835ea6584547669d55d751

tdf#91378-Empty Custom Properties are lost while saving in .pptx format

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2015-07-03 22:24:50 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf17befa261fd64f95bb4db932ce4d7e149f4a72

tdf#91378: sax, oox: avoid sending empty strings to character callbacks

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2016-09-15 22:10:14 UTC
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Comment 6 Xisco Faulí 2017-07-13 10:09:41 UTC
Setting Assignee back to default. Please assign it back to yourself if you're still working on this issue
Comment 7 QA Administrators 2018-07-14 02:45:50 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2020-07-14 04:03:47 UTC Comment hidden (obsolete)
Comment 9 NISZ LibreOffice Team 2021-01-13 12:10:24 UTC
Created attachment 168852 [details]
The unit test document before and after save in current master