Bug 91873 - Textbox border doesnt appear on bullet point textboxes
Summary: Textbox border doesnt appear on bullet point textboxes
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Textbox
  Show dependency treegraph
 
Reported: 2015-06-05 11:00 UTC by Yousuf Philips (jay) (retired)
Modified: 2023-04-06 16:59 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-06-05 11:00:28 UTC
Steps:
1) Open Impress
2) Select 'Title, Content' Layout
3) Click in the content section and type some text after the bullet point
4) Deselect the textbox
5) Click to edit the text you just typed in
6) Border around the textbox isnt visible

This behaviour doesnt happen with the title textbox or a newly drawn textbox. Regression that began in 4.1, as this works correctly in 4.0.6.

Version: 5.1.0.0.alpha1+
Build ID: 9f01951b858453684f2622541af0eb85d4544fc6
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-03_00:58:10
Comment 1 raal 2015-06-05 12:47:45 UTC
Reproducible with LO 4.4.3, win7
Comment 2 Michael Weghorn 2015-07-17 21:37:41 UTC
bibisect result (using bibisect-43all repository):
 4e6ca16994d8627b4d31fe2399391ab82f06ba12 is the first bad commit
commit 4e6ca16994d8627b4d31fe2399391ab82f06ba12
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Wed Oct 16 13:43:30 2013 +0000

    source-hash-68c3dfc3119a50ee9c9c6d65f4c656637152bbad
    
    commit 68c3dfc3119a50ee9c9c6d65f4c656637152bbad
    Author:     navin patidar <patidar@kacst.edu.sa>
    AuthorDate: Mon Mar 11 09:06:45 2013 +0300
    Commit:     Fridrich Strba <fridrich@documentfoundation.org>
    CommitDate: Mon Mar 11 14:34:29 2013 +0000
    
        fix fdo#62143: set TEXT_LAYOUT_BIDI_STRONG flag.
    
        Change-Id: I19ed1874ff73c3a8002934fa3456d718e383c5d6
        Reviewed-on: https://gerrit.libreoffice.org/2664
        Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
        Tested-by: Fridrich Strba <fridrich@documentfoundation.org>

:100644 100644 81220454e91e5cef7eb7120ae31333a440021222 b705dc1dceec16c40ec9aa1cfc22497c7bf59be8 M	ccache.log
:100644 100644 1ec40b2ef4cb8c510bdd38d65ee884c1f7a76b8b 49f986c8a78217b76e7a11195e4d686e49d73be4 M	commitmsg
:100644 100644 984dc378fc5b2c08fbe6563acff514d29b8bf838 038c6da92770a07e32d43ac3c4ac44a190ef1e10 M	dev-install.log
:100644 100644 cee4a97744cd68ddd8db090edc9745aa9132b8b1 42fa6993f3e8dfe3c9c4dee81b2d9dbbc9c57957 M	make.log
:040000 040000 b6045560f83b0a2316114222831e78a4256715f9 e62bf99593bfa573f70e250f6f1d1198e8e812a5 M	opt

---

$ git bisect log
# bad: [c2069a369d738078124812312d51f21ea1ce2421] source-hash-f160e4935c474a5293b3d3c11b3d538efb4767a0
# good: [2e0fa432485d1db6abd355dad8ccb06f0b97e4fb] source-hash-ce90f99a2d66c2b998ad3f9f028e2ea623a757f5
git bisect start 'last41onmaster' 'last40onmaster'
# bad: [c1631ee90606d0a7928496fb9548bcd0dbe69dbf] source-hash-28fb57daa77438f5e63132d3417062a11a44461e
git bisect bad c1631ee90606d0a7928496fb9548bcd0dbe69dbf
# good: [cd762eb968ba8783f726b67d9d70b0a76f4eb55d] source-hash-c9562064740baed3a9978723c5fe77b44a13a7aa
git bisect good cd762eb968ba8783f726b67d9d70b0a76f4eb55d
# bad: [5a52acff89c712acbd4be6896748c76a010cb507] source-hash-07352f07ce40ef40e9b73fd05aa4f9c5eac38290
git bisect bad 5a52acff89c712acbd4be6896748c76a010cb507
# good: [6f1a441db6e60b3b26e8cb23a731e0ac9695a230] source-hash-ca44650259e9388bd7dfd0603e4c9908a116c59b
git bisect good 6f1a441db6e60b3b26e8cb23a731e0ac9695a230
# good: [89dc8a802d1625e0efd88ba0fb720b22be87f3f0] source-hash-da03bb1ee6a69d2f4fef4c3ca0adc0ba9588bd19
git bisect good 89dc8a802d1625e0efd88ba0fb720b22be87f3f0
# good: [08ea576f1b683ae47f02d632576bd7b785471191] source-hash-0670c3f3dac55b7070f4980e3c58720ac76a1b0a
git bisect good 08ea576f1b683ae47f02d632576bd7b785471191
# bad: [4e6ca16994d8627b4d31fe2399391ab82f06ba12] source-hash-68c3dfc3119a50ee9c9c6d65f4c656637152bbad
git bisect bad 4e6ca16994d8627b4d31fe2399391ab82f06ba12
# first bad commit: [4e6ca16994d8627b4d31fe2399391ab82f06ba12] source-hash-68c3dfc3119a50ee9c9c6d65f4c656637152bbad
Comment 3 Robinson Tryon (qubit) 2015-12-13 11:13:17 UTC Comment hidden (obsolete)
Comment 4 raal 2016-11-20 07:17:09 UTC
This seems to have begun at the below commit.
Adding Cc: to Armin Le Grand  ; Could you possibly take a look at this one?
Thanks


 014a1562eea85ea8004b0b7ff5b938d5041f27f8 is the first bad commit
commit 014a1562eea85ea8004b0b7ff5b938d5041f27f8
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Fri Sep 18 10:42:42 2015 +0800

    source-hash-3137258e346a9c16b2e61747fd926a1e7d358d02
    
    commit 3137258e346a9c16b2e61747fd926a1e7d358d02
    Author:     Armin Le Grand <alg@apache.org>
    AuthorDate: Thu May 3 10:59:32 2012 +0000
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Mon Mar 11 07:50:32 2013 +0000
    
        Resolves: #i118905# Changed EditEngine to be able to paint to overlay directly
    
        i.e. paint to VirtualDevice as well, not only to Window.
        Removed the no longer needed switch between buffered and unbuffered overlay,
        this removes the flickering white block.
    
        (cherry picked from commit 5ab32faf2426fa60f975d0b544cfd671cdc7983b)
    
        Conflicts:
        	editeng/inc/editeng/outliner.hxx
        	editeng/source/editeng/impedit.hxx
        	editeng/source/editeng/impedit3.cxx
        	editeng/source/editeng/impedit4.cxx
        	svx/inc/svx/sdr/overlay/overlaymanager.hxx
        	svx/inc/svx/sdr/overlay/overlaymanagerbuffered.hxx
        	svx/inc/svx/sdrpaintwindow.hxx
        	svx/inc/svx/svdpagv.hxx
        	svx/source/sdr/overlay/overlaymanager.cxx
        	svx/source/svdraw/sdrpaintwindow.cxx
        	svx/source/svdraw/svdedxv.cxx
        	svx/source/svdraw/svdpagv.cxx
    
        Change-Id: Ibf4fcba77b120187fbae2454d136d2acd74be119

bibisect-41max$ git bisect log
# bad: [e8a1c54dfe8a4bc03d2ce9cb9906bf06d9affa7d] source-hash-863d38fbfa4fb4861e476828c46410602100919e
# good: [8cb222c656c0444f66cfa5a35ed204169bb91e09] source-hash-efca6f15609322f62a35619619a6d5fe5c9bd5a4
git bisect start 'latest' 'oldest'
# good: [789cb134f3000918fe031ffce19c57e505cab328] source-hash-8669ad398a2971706ce22b6e5fe316991977452a
git bisect good 789cb134f3000918fe031ffce19c57e505cab328
# skip: [0699ea5ef4cb907f6f387cdf2aac183bd8fc5643] source-hash-ba6989df7dffb4fd2c62dbb9f5b1c9b000b4abdd
git bisect skip 0699ea5ef4cb907f6f387cdf2aac183bd8fc5643
# bad: [3032632d514891fc82a76f3526f4a61cb064d8ca] source-hash-2f205ee79ea929c6fce5686512bd468ab78a877a
git bisect bad 3032632d514891fc82a76f3526f4a61cb064d8ca
# bad: [62e04a3511acab40dccdf02fde6b1fcef0cb2b39] source-hash-e518ef52bbda3449130f51dbbf6f0a60bb76298f
git bisect bad 62e04a3511acab40dccdf02fde6b1fcef0cb2b39
# bad: [6ee77b3f9cf5cc21ee3f66ad467c900bf390aabe] source-hash-f25fcba2f2ef699e8366d3681ae6c636798569a8
git bisect bad 6ee77b3f9cf5cc21ee3f66ad467c900bf390aabe
# bad: [d43254ba1cc8307ce6f4b17038a173f0a4054e4a] source-hash-e8620b247dcba55f67ad7eaf63cfe5ac3831b187
git bisect bad d43254ba1cc8307ce6f4b17038a173f0a4054e4a
# bad: [90483904b5be51b4182806da02dd188669261b79] source-hash-c1ba64c2d90dfe73eece410a86f630a0032d0ffe
git bisect bad 90483904b5be51b4182806da02dd188669261b79
# bad: [f0b34019f9584a7831632d7f676a3e75ab7b795b] source-hash-3c1eba7314d3a0dae925cbe90e0cd98cfb79c81b
git bisect bad f0b34019f9584a7831632d7f676a3e75ab7b795b
# bad: [5ff688bad0fd64d63856e6b56e1bfda446e712c9] source-hash-3e736d50b920726eee85568257bed2001e6abbf2
git bisect bad 5ff688bad0fd64d63856e6b56e1bfda446e712c9
# bad: [0e033d10749e42ba798e085324291f165c67df3f] source-hash-4ec9f68f25f1d75f63e57570eb24f30ebfcfe2b2
git bisect bad 0e033d10749e42ba798e085324291f165c67df3f
# good: [cd608d072c7bdf197130b78c211215cb14b98c65] source-hash-b56e53f1358ab48173aa8f17acc6d40352320d9c
git bisect good cd608d072c7bdf197130b78c211215cb14b98c65
# bad: [014a1562eea85ea8004b0b7ff5b938d5041f27f8] source-hash-3137258e346a9c16b2e61747fd926a1e7d358d02
git bisect bad 014a1562eea85ea8004b0b7ff5b938d5041f27f8
# good: [e23e6eb734c47db55fcb52eb604ca5f14912b946] source-hash-09fa9ff842544f68f874e5b505b3e797c3767156
git bisect good e23e6eb734c47db55fcb52eb604ca5f14912b946
# good: [93dd0033b45d17a18612e0d43db037ae9b058d0f] source-hash-d242c4a441964837e6a68343dfef9eb530fb41f7
git bisect good 93dd0033b45d17a18612e0d43db037ae9b058d0f
# good: [e27c70c51f124c34b3de7163e302b04e71edd6a9] source-hash-6874c25f98dcfe5116d96a1282c4231c3f2d623a
git bisect good e27c70c51f124c34b3de7163e302b04e71edd6a9
# first bad commit: [014a1562eea85ea8004b0b7ff5b938d5041f27f8] source-hash-3137258e346a9c16b2e61747fd926a1e7d358d02
Comment 5 Telesto 2017-05-07 15:34:51 UTC
Reproducible with
Version: 5.4.0.0.alpha1+
Build ID: 274ecb49b70b3f01d47546e3b44317946c106042
CPU threads: 4; OS: Windows 6.2; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-05_22:45:07
Locale: nl-BE (nl_NL); Calc: single
Comment 6 Andrew Watson 2018-02-20 13:05:27 UTC
Reproduced with:

Version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-GB (en.UTF-8); Calc: group
Comment 7 Andrew Watson 2019-02-21 08:34:12 UTC
Reproduced with:

Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx; 
Locale: en-GB (en.UTF-8); UI-Language: en-US
Calc: threaded
Comment 8 QA Administrators 2021-02-21 03:57:53 UTC Comment hidden (obsolete)
Comment 9 Andrew Watson 2021-03-09 15:18:55 UTC
Reproduced with:

Version: 7.1.1.2 / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 10 Andrew Watson 2021-12-12 10:36:50 UTC
Reproduced with:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 11 Armin Le Grand 2022-01-05 10:18:04 UTC
This commit was developed for another code base, and not merged by me. For complex changes like this, side-effects are to be expected; sadly I dont't have the cycles to deal with all the fallout. Un-Ccing myself for the while.
Comment 12 Andrew Watson 2023-04-06 16:53:26 UTC
Reproduced with:

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded
Comment 13 Andrew Watson 2023-04-06 16:59:10 UTC
Checked with:

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

Bug no longer present. Border around content text box now re-appears when mousing within text in that text box.

Set status to RESOLVED - WORKSFORME