Steps to cause crash: 1. Open Base and open a relational database file. 2. Open the relation design dialog (Tools > Relationships). 3. Add a table. 4. Close the relation design dialog. 5. LibreOffice crashes! Expected behavior: A popup window asking me if I want to save the changes. Additional comments: This does not happen when 4.4.4.3 (Deb version for both x86 and x86_64) It doesn happen for both RC1 and RC2 for 5.0 for both Deb versions. Also, I have had it to happen on RC1 and RC2 when I just opened the relation design dialog and then closed it again.
I can confirm a crash on Win8.1 with 5.0.0.2 64bit but mine is a bit different Here Base crashes when I save the file after a change while in the relation design dialog
On pc Debian x86-64 with master sources updated today, I could reproduce this. Here are the console logs: warn:legacy.osl:7864:1:vcl/source/window/window.cxx:271: Window ( N5dbaui18ORelationTableViewE ()) with live children destroyed: N5dbaui20ORelationTableWindowE () Window ( N5dbaui18ORelationTableViewE ()) with live children destroyed: N5dbaui20ORelationTableWindowE ()
part of the bt: #0 0x00002aaab1b4e1e4 in vcl::Window::dispose() (this=0x2f084c0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/window.cxx:271 #1 0x00002aaacef7b452 in dbaui::OJoinTableView::dispose() (this=0x2f084c0) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/querydesign/JoinTableView.cxx:201 #2 0x00002aaacf0113fc in dbaui::ORelationTableView::dispose() (this=0x2f084c0) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:84 #3 0x00002aaab1cae1be in OutputDevice::disposeOnce() (this=0x2f084c0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/outdev/outdev.cxx:203 #4 0x00002aaacef78da9 in VclPtr<dbaui::OJoinTableView>::disposeAndClear() (this=0x305ded0) at /home/julien/compile-libreoffice/libreoffice/include/vcl/vclptr.hxx:215 #5 0x00002aaacef7879a in dbaui::OJoinDesignView::dispose() (this=0x305dc80) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/querydesign/JoinDesignView.cxx:69 #6 0x00002aaab1cae1be in OutputDevice::disposeOnce() (this=0x305dc80) at /home/julien/compile-libreoffice/libreoffice/vcl/source/outdev/outdev.cxx:203 #7 0x00002aaab05502cf in VclPtr<OutputDevice>::disposeAndClear() (this=0x7fffffff3d50) at /home/julien/compile-libreoffice/libreoffice/include/vcl/vclptr.hxx:215 #8 0x00002aaab059cc6a in VCLXWindow::dispose() (this=0x3049360) at /home/julien/compile-libreoffice/libreoffice/toolkit/source/awt/vclxwindow.cxx:927 #9 0x00002aaac6c3993e in (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (this=0x30c2c30, xComponentWindow=empty uno::Reference, xController=empty uno::Reference) at /home/julien/compile-libreoffice/libreoffice/framework/source/services/frame.cxx:1579 #10 0x00002aaac6c3a36d in (anonymous namespace)::Frame::close(sal_Bool) (this=0x30c2c30, bDeliverOwnership=0 '\000') at /home/julien/compile-libreoffice/libreoffice/framework/source/services/frame.cxx:1781
Have set the system to all. Happens for Debian, here for OpenSUSE 64bit rpm and also for Win 8.1 (comment 1).
Looks like a pre-existing problem with erasing items from a vector while iterating over it, and also a missing disposeAndClear - testing a fix.
Fixed Julien's issue, and also a rats nest of others - hmm; base needs significantly more testing I suspect - particularly with the new gtk3 / a11y foo enabled. Pushed some fixes as: remote: https://gerrit.libreoffice.org/16671 tdf#92434 - fix iteration, and remember to disposeAndClear. remote: https://gerrit.libreoffice.org/16672 tdf#92434 - A series of hideous knock-on dbaccess crasher fixes.
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=356bc0f697299e5fb6156ce25dc69845eaa6f9e6 tdf#92434 - fix iteration, and remember to disposeAndClear. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please give it a whirl and see how the fixes bite you in a new master build. Thanks ! =)
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=996b16dcb590ebf779f5d95caf15e9ab18036b07 tdf#92434 - A series of hideous knock-on dbaccess crasher fixes. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f5721a9de60f614519be383fec2c97b2dd19b289&h=libreoffice-5-0 tdf#92434 - fix iteration, and remember to disposeAndClear. It will be available in 5.0.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=88b06253359dfa91242757ceb39d7276786a0587&h=libreoffice-5-0 tdf#92434 - A series of hideous knock-on dbaccess crasher fixes. It will be available in 5.0.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
On pc Debian x86-64 with master sources updated today, I could still reproduce this. warn:legacy.osl:14964:1:vcl/source/window/window.cxx:281: Window ( N5dbaui18ORelationTableViewE()) with live children destroyed: N5dbaui20ORelationTableWindowE() Window ( N5dbaui18ORelationTableViewE()) with live children destroyed: N5dbaui20ORelationTableWindowE()
Created attachment 117042 [details] hs_err_pid Forgot to say last commit retrieved: 3c45bfb0cabf206f6217f1de9eb5cfa12b78e46f
Created attachment 117044 [details] bt with debug symbols (gtk3)
Created attachment 117045 [details] bt with gtk version<3 To retrieve it, I put a break on vcl/source/window/window.cxx line 281
Michael: I retrieved some bts (with and without gtk3) on pc Debian x86-64 with master sources updated today, thought you might be interested in these.
Version: 5.0.0.2.0+ Build ID: 64b4ed9de3852494416cdcb8c25d2e24fc4d0253 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-5-0, Time: 2015-07-03_09:08:51 Locale: en-US (en_US.UTF-8) Run from terminal Tools > Relationships Add a table: table added Add relationship: relationship added Delete a relationship: relationship deleted Save the dialog: dialog saved Close dialog: dialog saved Delete a table: program crashes Terminal output: pure virtual method called terminate called without an active exception Observation: Most of the problems I had with this dialog before have been cleared. Perhaps the terminal output along with the back trace may point to the one bug still hiding somewhere
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bb2d015b332aa5e7623b4edba53f0503c64bbba Related: tdf#92434 children cleared but parent hasn't completed dispose yet It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd1a27995a1444c8bc96fa09293bc2a47106bc67&h=libreoffice-5-0 Related: tdf#92434 children cleared but parent hasn't completed dispose yet It will be available in 5.0.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I still get this from master at 5d19f90eb247275420a6774403cb77940ac6131b: warn:legacy.osl:19474:1:vcl/source/window/window.cxx:281: Window ( N5dbaui18ORelationTableViewE()) with live children destroyed: N5dbaui20ORelationTableWindowE() N5dbaui20ORelationTableWindowE() Window ( N5dbaui18ORelationTableViewE()) with live children destroyed: N5dbaui20ORelationTableWindowE() N5dbaui20ORelationTableWindowE() Will have a poke at that =)
Pushed to CI for now; if there are further bugs in this area please open a new issue =) https://gerrit.libreoffice.org/16893 tdf#92434 - dispose the table contents.
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b54f22302731784d7bd462bf2cef0621eea8b22a tdf#92434 - dispose the table contents. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8791cff003afc323601dd43289e642471ac26863&h=libreoffice-5-0 tdf#92434 - dispose the table contents. It will be available in 5.0.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
On pc Debian x86-64 with master sources updated today, I don't reproduce the crash. I just noticed these on console: warn:legacy.osl:5757:1:include/cppuhelper/interfacecontainer.h:479: object is disposed warn:legacy.osl:5757:1:vcl/unx/gtk3/a11y/../../gtk/a11y/atklistener.cxx:144: OSL_ASSERT: m_aChildList[n].is() but this is another story. Thank you Michael! :-)
Yeesss... the gtk3 / turning atk/a11y on by default decision of course makes everything less stable on Linux / master -> but then ... eventually we'll need to fix all our atk bugs too so =) Thanks for verifying.
Version: 5.0.1.0.0+ Build ID: 5df3725f81564a8380209881b6f2c48b2fe158b3 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time: 2015-07-22_17:20:20 Locale: en-US (en_US.UTF-8) Today, I checked the relational dialog problem again using the above build. When I tried to delete a table in it, the warning window appears as it should about deleting a table. When I click Yes, LibreOffice crashes. We still have a problems here.
Have tested this one. Opened a database. Opened Tools → Relationships Deleted one table in the relationship Whole LO crashes immediately. My System: OpenSUSE 13.2 64bit rpm Linux, LO Version: 5.0.0.4 Build-ID: cf112dc905650fb985306a7a03d2fe3fcc6c978f Gebietsschema: de-DE (de_DE.UTF-8)
Version: 5.1.0.0.alpha1+ Build ID: 74d4168f8830f7bbec6b784c3fb774296d9adafa TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-07-22_06:06:19 Locale: en-US (en_US.UTF-8) I used this build to test this bug on a relational database. When I tried to delete a table in the relation design dialog, I got the proper warning pop-up. But when I click Yes, LibreOffice crashes. (Ubuntu 14.04 32 bit)
Created attachment 117587 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today (+gtk3), I could reproduce the crash when deleting the table.
Michael: just wonder if we should make a new bugtracker for delete part. Indeed, the original problem can't be reproduced now but, on the other side, we could say both actions are closely related.
Hi Julien - yes - thanks that would be great; opening a new bug would be much appreciated in place of re-opening old ones for new issues =) (or having bugs with over-broad subjects). Thanks ! please do CC me etc.
Thank you Michael for your feedback. Following creation of tdf#93069, let's close this one.