Bug 92506 - Creating new AutoFormat style will hang with certain formatting pattern
Summary: Creating new AutoFormat style will hang with certain formatting pattern
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.4.3 release
Hardware: All Windows (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-02 16:28 UTC by gmarco
Modified: 2017-01-06 10:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (45.25 KB, image/jpeg)
2015-07-02 16:28 UTC, gmarco
Details
autof-sample-ods1 (sample ods sheet) (13.99 KB, application/vnd.oasis.opendocument.spreadsheet)
2015-10-19 15:30 UTC, gmarco
Details
autoformat1 (screenshot) (103.58 KB, image/jpeg)
2015-10-19 15:32 UTC, gmarco
Details
autof-app3 (screenshot) (145.15 KB, image/jpeg)
2015-10-19 15:33 UTC, gmarco
Details
autof-add1 (screenshot) (137.96 KB, image/jpeg)
2015-10-19 15:53 UTC, gmarco
Details
autof-add3 (screenshot) (110.90 KB, image/jpeg)
2015-10-19 15:54 UTC, gmarco
Details
Backtrace from the hanged process (3.50 KB, text/plain)
2016-04-17 11:46 UTC, mahfiaz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gmarco 2015-07-02 16:28:13 UTC
Created attachment 117010 [details]
screenshot

I already posted the question to Q&A but no replies.
The help (https://help.libreoffice.org/Calc/Using_AutoFormat_for_Tables/it) says:

Per applicare una formattazione automatica a un foglio o a un'area di celle selezionata
1.	Selezionate le celle da formattare, incluse le intestazioni di righe e colonne.  (nota: almeno 3x3)
2.	Scegliete Formato - Formattazione automatica.
3.	Per selezionare le proprietà da includere nella formattazione automatica, fate clic su Extra.
4.	Fate clic su OK.
Il formato viene applicato all'area di celle selezionata.

(EN version: Select the cells, including the column and row headers, that you want to format. Choose Format - AutoFormat. To select which properties to include in an AutoFormat, click More. Click OK.
The format is applied to the selected range of cells.)

I observe:
- at item 1 "including the column and row headers" is superfluous being implicit; you should point out to select at least 3x3 cells, otherwise the option is inhibited.
- at item 3 "fate clic su Extra" (click More) but I don't see any of that (look at the attachment).

Then over in the help:

Per definire una formattazione automatica per fogli elettronici
Potete definire una nuova formattazione automatica che sia disponibile a tutti i fogli elettronici.
1.	Formattate un foglio.
2.	Scegliete Modifica - Seleziona tutto.
3.	Scegliete Formato - Formattazione automatica.
4.	Fate clic su Aggiungi.
5.	Nella casella Nome della finestra di dialogo Aggiungi formattazione automatica, inserite un nome per il formato.
6.	Fate clic su OK.

(EN version: Format a sheet. Choose Edit - Select All. Choose Format - AutoFormat. Click Add. In the Name box of the Add AutoFormat dialog, enter a name for the format. Click OK.)

I observed that "Choosing Edit-Selecting All" LO crashes("does not reply" on the top line).
No crash if I select a block of cells (but almost 4x4) instead of "all sheet".

Can you verify?  Thanks
Comment 1 raal 2015-07-02 20:10:33 UTC
(In reply to gmarco from comment #0)
> 
> (EN version: Format a sheet. Choose Edit - Select All. Choose Format -
> AutoFormat. Click Add. In the Name box of the Add AutoFormat dialog, enter a
> name for the format. Click OK.)
> 
> I observed that "Choosing Edit-Selecting All" LO crashes("does not reply" on
> the top line).
> No crash if I select a block of cells (but almost 4x4) instead of "all
> sheet".
> 
> Can you verify?  Thanks

No crash with Verze: 5.0.0.1 (x64)
ID sestavení: 9a0b23dd0ab9652e0965484934309f2d49a7758e
Win7
Comment 2 gmarco 2015-07-05 12:41:35 UTC
After installing 4.4.4.3 I confirm what said
Comment 3 Joel Madero 2015-10-18 01:10:09 UTC
Hi Gmarco -

I'm sorry but it's a little unclear exactly what you are reporting here. It seems to me to be partly a UX issue (suggestion pertaining to the headers being superflous) and partly a crash (doing different steps).

Is this the case? If so, this bug needs to be closed as INVALID and the issue needs to be reported separately as we need one bug report per issue. If this isn't the case, can you better explain what the *single* issue is. If possible, English only :) Thanks!

Mark as UNCONFIRMED after clarifying. Thanks again
Comment 4 Joel Madero 2015-10-18 01:10:48 UTC
Also, with 4.4 you see the issue also? If so, please update the version field (version is oldest version that the problem is seen, not the latest). Thanks one more time
Comment 5 gmarco 2015-10-19 15:11:40 UTC
(In reply to Joel Madero from comment #4)
> Also, with 4.4 you see the issue also? If so, please update the version
> field (version is oldest version that the problem is seen, not the latest).
> Thanks one more time

Hi Joel, I am using now 4.4.5.2 and nothing has changed
LO update check says "LibreOffice 4.4 is updated").
Comment 6 Joel Madero 2015-10-19 15:17:33 UTC
Please try with 5.0.0.2 & with a fresh profile: https://wiki.documentfoundation.org/UserProfile

Thanks
Comment 7 gmarco 2015-10-19 15:30:41 UTC
Created attachment 119753 [details]
autof-sample-ods1 (sample ods sheet)

(In reply to Joel Madero from comment #3)
OK I have now subdivided the questions and will post two other reports.

Sorry, but my LO is in Italian language, so I cannot show all in English (attachments are in Italian).
Referring to help (https://help.libreoffice.org/Calc/Using_AutoFormat_for_Tables/it  and attach. "autoformat1" mark2), it says:

To Define an AutoFormat for Spreadsheets
You can define a new AutoFormat that is available to all spreadsheets.
1.Format a sheet.
2.Choose Edit - Select All.
3.Choose Format - AutoFormat.
4.Click Add.
5.In the Name box of the Add AutoFormat dialog, enter a name for the format.
6.Click OK.

Well, after step 6, if I click OK  LOC hangs (see attach. "autof-app3" and "autof-app4" where "Non risponde" means "Not 

responding").
I have to click Chiudi (in IT), I think Close in EN.
But ... clicking OK (even if it would be a mistake), it is not good to get a crash.
Comment 8 gmarco 2015-10-19 15:32:24 UTC
Created attachment 119754 [details]
autoformat1  (screenshot)
Comment 9 gmarco 2015-10-19 15:33:35 UTC
Created attachment 119755 [details]
autof-app3  (screenshot)
Comment 10 gmarco 2015-10-19 15:53:48 UTC
Created attachment 119756 [details]
autof-add1  (screenshot)
Comment 11 gmarco 2015-10-19 15:54:46 UTC
Created attachment 119757 [details]
autof-add3  (screenshot)
Comment 12 gmarco 2015-10-19 16:00:29 UTC
errata-corrige, please correct:

Well, after step 6, if I click OK  LOC hangs (see attach. "autof-add1", "autof-app3" and "autof-add3" where "Non risponde" means "Not responding").
I have to click Chiudi (in IT), I think Close in EN.
But ... clicking OK (even if it would be a mistake), it is not good to get a crash.
Comment 13 gmarco 2015-10-26 15:40:23 UTC
I further verified as follows.
Given that the CLOSE button is visible only after having opened an Add or Delete or Rename dialog, but the OK button also is simultaneously visible and clickable, then, clicking OK, LO hangs.
Comment 14 gmarco 2015-11-19 22:26:54 UTC
Using now LO 5.0.3.2
nothing has changed, following instructions as in comment 7 and 12, LO still hangs.
Can someone reproduce it?
Comment 15 mahfiaz 2016-04-17 11:46:31 UTC
Created attachment 124425 [details]
Backtrace from the hanged process

I can confirm this on 5.1.2.1

So steps to reproduce:
1. Open the attached .ods document (copying the table to a new document WITH formatting also works, copying without formatting does not work, so it has something to do with the formatting).
2. Select all cells (selecting just the data does not work)
3. Format → Autoformat styles → Add, type in a name
4. OK, OK

After the last OK the dialog disappears and LibO will hang.

If all the alternating background colors are removed before running these steps, it will not hang.
Comment 16 Joel Madero 2016-04-17 16:39:55 UTC
Hangs deserve major. Because of the specificity of the bug ("with certain formatting pattern") I'm leaving as medium.

If it's a regression please let us know and we'll bump to high.
Comment 17 gmarco 2017-01-06 08:54:56 UTC
Retesting the question in LO 5.2.3.3 I get no more the hang problem, so I edit the status as RESOLVED-FIXED, edit yourself it as you like.
Comment 18 Cor Nouws 2017-01-06 10:31:37 UTC
thanks for testing again - great that it works now.