The file core/sfx2/source/appl/workwin.cxx contains resource ids as numeric constants. They should be replaced by defined names. Exemple: { 18005, "moreformcontrols" }, { 18006, "formdesign" }, { 20050, "toolbar" }, //math { 30001, "objectbar" }, //chart { 30513, "toolbar" }, //chart should be { RID_XXXX_YYYY, "moreformcontrols" }, { SID_TTTT_UUUU, "formdesign" },
(In reply to Philippe Jung from comment #0) > The file core/sfx2/source/appl/workwin.cxx contains resource ids as numeric > constants. > > They should be replaced by defined names. Sounds like something for a dev to triage: Keywords -> needAdvice
All the numbers in the file have already defined constants, find the constant and replace the number with the constant.
Does the patch need to have all the numbers with defined names?I would like if i can submit a patch with partial completion.
(In reply to krishna keshav from comment #3) > Does the patch need to have all the numbers with defined names?I would like > if i can submit a patch with partial completion. It would be nice to have all names, but a house is build of bricks so are issues, so a small patch is better than nothing :-) rgds jan I.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b276db51dcb5a9f5a2390a23880ba0a10bed0f4a remove dead resource names, related to tdf#92518 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5fc4c29e12c2c8ae8b0c8f57f7f1d6036dfd72 remove dead resource names, related to tdf#92518 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=962719df881a8aefdec7f564293d1e0cd42a5540 remove dead resource name, related to tdf#92518 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c6d594df392e7cb6c7a340454be69555f0e208b tdf#92518 replace hard coded resource ids It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.