Created attachment 117352 [details]
What it says on the tin (and the screenshot).
I confirm that under Win8.1 x64
in LibO 4.3.5 that option was enabled while in 188.8.131.52 and following releases (including recent 5.1.0 daily builds) that option is disabled
I don't know if that was done on purpose or not.
should we call it a regression?
Sure – thanks for testing, Tommy.
With this patch + make postprocess + brand new profile, it works:
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 7e722ca..f0b3c04 100644
@@ -1347,7 +1347,7 @@
<desc>Specifies if single quotes should be replaced.</desc>
<label>Single quotes - Replace</label>
<prop oor:name="SingleQuoteAtStart" oor:type="xs:int">
<!-- OldPath: AutoCorrect/Options/All -->
The problem is I don't see in the historic of the file why it was working before 4.4.0
Perhaps I'm on a wrong lead.
Julien, that patch looks okay to me.
Pending review for master sources:
(In reply to tommy27 from comment #1)
> in LibO 4.3.5 that option was enabled
This is not true. The default option for single quotes has always been disabled since the year 2002, which can easily be seen with git annotate. If you experienced differently it is because of a local configuration.
I suspect there is some reason the single quote replacement is disabled while the double quote replacement is not, but I don't know which, maybe related to apostrophe uses.
I suggest to resolve this as NOTABUG.
Yes it was disabled in OpenOffice because of problems, including Apostrophe. There had been discussions on mailing lists. Read issues https://bz.apache.org/ooo/show_bug.cgi?id=5839 and https://bz.apache.org/ooo/show_bug.cgi?id=22271 and its duplicates.
I support NOTABUG.
Just for the record, I abandonned the patch.
I had found an interesting location too http://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx#241 but since I had found the location of the patch, I hadn't dig more.
*** This bug has been marked as a duplicate of bug 38395 ***